From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E22513EF0DE for ; Wed, 21 Jan 2026 12:34:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768998860; cv=none; b=In97vjo5n11u9+kqluAnRtREAunVJavd3+xG0Lg8NnD+u/r9marHamrRMPgasoMJqPBmLhhgIfNSZg0evaLddgUBNKl1zrq0oByAwWZZ9RXeMXQDy+H7NBm05fJ9n7ZvrSgpwmC9lHEHruRAfXI0P8MGAqASwiesaiky5p+Lbtc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768998860; c=relaxed/simple; bh=NHfHZDd24zh5pxHhEUlvHD6TndIv5G4G66d1Utra0Hc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hx6z5V4yeZymG4uxfm5Kv8nNk2jlBMlVtWJ6MZz1x1lTcIqLZ0Ub7j5//Itw9SjeMx5EquRwchtujm385zsFvBNBde7mfimFkjKCo4QoYAKG2ADJHKWDSKZtL0QRNmFmyxiWUyZTtJLrUomkYi/lY9mnmNNSXE9IYKJkGFVTlaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WCxkW4bY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WCxkW4bY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 452A7C116D0; Wed, 21 Jan 2026 12:34:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1768998859; bh=NHfHZDd24zh5pxHhEUlvHD6TndIv5G4G66d1Utra0Hc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WCxkW4bY6T5fK39fEDklx0VnNmqbjkahNCp2BSBoSFGA2ctok1s+J6YNmPk/8ilrX ECieSxpelEvtkRhFnFSG0d7I6lnEYa30LgZth4DO6h3rWfXEm/+eJqJ90qIzAlui1R ilxyMrMSeltze2a2/ZNuSH2Z7oU8FURzaIUVpQw1gc3aHfqK3YU8wY7u/K23Di34fY XWer/XFaRtaW6U9ez4BmfbZGPgsh4YKlZEg60MGpU8DGAAXi30mJ+QMfS9QK2w67iv 9u/BIl3jGB5nNipJg2aShcZd/C5j0lXbRpyTRZbdalIYx0zFtabAFEzsftijkINgbo GQQRVBurECXng== Date: Wed, 21 Jan 2026 20:34:15 +0800 From: Tzung-Bi Shih To: Bartosz Golaszewski Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , linux-kernel@vger.kernel.org Subject: Re: [PATCH] revocable: Remove redundant synchronize_srcu() call Message-ID: References: <20260121040204.2699886-1-tzungbi@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Jan 21, 2026 at 11:38:18AM +0100, Bartosz Golaszewski wrote: > On Wed, Jan 21, 2026 at 5:03 AM Tzung-Bi Shih wrote: > > > > When allocating a revocable provider via revocable_provider_alloc(), > > there is no revocable consumers (i.e., RCU readers) yet. Remove the > > redundant synchronize_srcu() call to save cycles. > > > > Signed-off-by: Tzung-Bi Shih > > --- > > To address the performance impact reported in > > https://lore.kernel.org/linux-gpio/CAMRc=McrFa42mNWmZtD1HKKKZ+USUKpQAAME50wbfxPM7L72gA@mail.gmail.com/. > > > > drivers/base/revocable.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/base/revocable.c b/drivers/base/revocable.c > > index f6cece275aac..b068e18a847d 100644 > > --- a/drivers/base/revocable.c > > +++ b/drivers/base/revocable.c > > @@ -99,7 +99,6 @@ struct revocable_provider *revocable_provider_alloc(void *res) > > > > init_srcu_struct(&rp->srcu); > > rcu_assign_pointer(rp->res, res); > > - synchronize_srcu(&rp->srcu); > > kref_init(&rp->kref); > > > > return rp; > > -- > > 2.52.0.457.g6b5491de43-goog > > > > Do you have an up-to-date integration branch with all the series and > fixes you posted that I could use for testing with GPIO? Please use https://git.kernel.org/pub/scm/linux/kernel/git/tzungbi/chrome-platform.git/log/?h=gpio_rev for the purpose which is based on driver-core-next and gpio/for-current branches.