From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001ae601.pphosted.com (mx0a-001ae601.pphosted.com [67.231.149.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 458DC3A1A48 for ; Wed, 21 Jan 2026 13:28:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=67.231.149.25 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769002136; cv=fail; b=QAZLXSfFtHq+tDi0VKrJlaUU0Uv+j0lNSLqgz+o5PW95pTx+4WriTWNR1+n8bJSL4PYKNC2OLBExkAgPTcH98iR9ZHC5VxH0nHN91QZLdWhMP+J3qVENKrzlDbLMaHuP5D8GXr6ezSy1vMQS/ExbEmYWJMwneMFfr7Lf1NgqYuY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769002136; c=relaxed/simple; bh=6sZ4ShbHItO5bR8st3XCoF5tV97X1j8T89M5BmpaTH8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ilV/8MSjW35wrNM1EME+NAdrFVgvQWKKfFqKct74AsOGcVBYR2lCxGtfdrRZSlJjxzHSKr2OF2sNgMfHBsxfCUKNGWiuZ9bEU9AmLRnYyCLkR0yj0bJtiV3L4MBsPMmHU1C2qwEp0YH231a5YrrKIbn5Nhe9t69SsZSKf4Aey2Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com; spf=pass smtp.mailfrom=opensource.cirrus.com; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b=B4jyLe83; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b=Pd97mFrQ; arc=fail smtp.client-ip=67.231.149.25 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=opensource.cirrus.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cirrus.com header.i=@cirrus.com header.b="B4jyLe83"; dkim=pass (1024-bit key) header.d=cirrus4.onmicrosoft.com header.i=@cirrus4.onmicrosoft.com header.b="Pd97mFrQ" Received: from pps.filterd (m0077473.ppops.net [127.0.0.1]) by mx0a-001ae601.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60L6HWS42941770; Wed, 21 Jan 2026 07:28:49 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=PODMain02222019; bh=6jPO9r5ETZijaKt2F8 n7j195D5uC8a69RY6lR7U2rUc=; b=B4jyLe83jljFZU5kzQGALPCTvlWJhYmjsC Qo1HO3yvOVwKuM016aSclB0ZwXICl+B+RGkjQT2vKKw20ng2WIfv5jaL76ZKzLG0 PsKbWyU1XdsYV31ONzwv7/1j1s1owVM6hCoNjpDhNLakf9jVohk0o6mqVTCk0Gjk 1BDEaAwVk2n/RffDee5pGzHbYa7nG5KL7s648lhxqGZLkJVxSZdxii5dtQFzJyce ZXiKudWk/VQ9pyvZwClwoeq77oKdOiYGlajIUcSSsg1gNQnaLZxMji6qDEZz0Sgk brz07uh+lPRCrUo2uRGWChPtyw5B5aIrE2OuYzIAxgo8v/rlP/ig== Received: from co1pr03cu002.outbound.protection.outlook.com (mail-westus2azon11020128.outbound.protection.outlook.com [52.101.46.128]) by mx0a-001ae601.pphosted.com (PPS) with ESMTPS id 4br8q1vp5w-1 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 21 Jan 2026 07:28:49 -0600 (CST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=K3zaCGvfMzTJRzuN9MntlHNE+H2+yUbDijL1+xTGbtdsnp2YKMgXeXX5bVO8UqH5RuP5KEckyorYLUpMUj1MwvQZt3nDqAtoBeTvgWgNXl5LoZWBRfJZkZsUcMsoS66M2u4SHVCaQS3wfKEcqb5auHYOaqLZD4FhYnoZdnkFkyQe2+gp1YIOKPZPi76uLdANIJOPbGcz0FY0381EiBifdTEDO5M7B+wOCyuUmEB+K4Ea8NrhM9g5MtRtJNmMC2eEv4vR1rijdNJPBpsKQ+Oqt3xKwtfiuIm9XmPDV9E9yII5PK9Xj1G0eX3mOTx+7BCtQNaTqSB1D9SF4aDPwDmZ+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6jPO9r5ETZijaKt2F8n7j195D5uC8a69RY6lR7U2rUc=; b=lLuZ0HAzX4E6u5rfRX4MWf8RsM3drH2n4FIy1PAmw2dQ8hf80EZJsnmNF/QPi13QRHN5WBoEI4gh4QKk9pSCGJLTAgvZX3i5BfuWjTg6ahV6j44Mko6mMwoE5IxCPuEddfNdneik1ap9ZVJbH++RqOOlmZieWi+P/nrJdB5uzzC7pN8ucQ9FT06X9Hh1652p3Jg7iwBJeyWT1UiCensFkZLIUxK0p+uq6YOTZHfRhaLLNMs8ck4Bwd37/a7/puN4+Ddou8CHs5ATW9eE71h1kAodziazhqqYWzgLNysQuWs0yjamO1VgCcLi9aqq1w1GtXPZHz8q4AtZ9I4yrcFW5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 84.19.233.75) smtp.rcpttodomain=cirrus.com smtp.mailfrom=opensource.cirrus.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=opensource.cirrus.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus4.onmicrosoft.com; s=selector2-cirrus4-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6jPO9r5ETZijaKt2F8n7j195D5uC8a69RY6lR7U2rUc=; b=Pd97mFrQUL6Jq8IN1Q2SGDg4ZYDOzeFMheQ2MhZ0ZLpO+FIUbu8QL8L2hQZDAKd1wf0bZVfGErh9ZewpxEwqyiOx9p29yRdp6CCXHs7OdNnVEPwnNy/E/QBeGC1QAxYOGtit3g+ncqqu/VGvslOEtP8YgyiusadVk1KT8a96olY= Received: from BL0PR02CA0084.namprd02.prod.outlook.com (2603:10b6:208:51::25) by MW4PR19MB6823.namprd19.prod.outlook.com (2603:10b6:303:207::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.9; Wed, 21 Jan 2026 13:28:46 +0000 Received: from BL6PEPF0001AB57.namprd02.prod.outlook.com (2603:10b6:208:51:cafe::3c) by BL0PR02CA0084.outlook.office365.com (2603:10b6:208:51::25) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.10 via Frontend Transport; Wed, 21 Jan 2026 13:28:45 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 84.19.233.75) smtp.mailfrom=opensource.cirrus.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=opensource.cirrus.com; Received-SPF: Fail (protection.outlook.com: domain of opensource.cirrus.com does not designate 84.19.233.75 as permitted sender) receiver=protection.outlook.com; client-ip=84.19.233.75; helo=edirelay1.ad.cirrus.com; Received: from edirelay1.ad.cirrus.com (84.19.233.75) by BL6PEPF0001AB57.mail.protection.outlook.com (10.167.241.9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9542.4 via Frontend Transport; Wed, 21 Jan 2026 13:28:45 +0000 Received: from ediswmail9.ad.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by edirelay1.ad.cirrus.com (Postfix) with ESMTPS id D54AB406540; Wed, 21 Jan 2026 13:28:44 +0000 (UTC) Received: from opensource.cirrus.com (ediswmail9.ad.cirrus.com [198.61.86.93]) by ediswmail9.ad.cirrus.com (Postfix) with ESMTPSA id BEC42820249; Wed, 21 Jan 2026 13:28:44 +0000 (UTC) Date: Wed, 21 Jan 2026 13:28:43 +0000 From: Charles Keepax To: Richard Fitzgerald Cc: Sebastian Andrzej Siewior , patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Lee Jones , Andy Shevchenko Subject: Re: request_irq() usage in wm8350_register_irq(). Message-ID: References: <20260121111617.quQxFcZK@linutronix.de> <20260121113659.CCJtYuQS@linutronix.de> <90b80379-6799-4600-886d-08ef48d9a35f@opensource.cirrus.com> <20260121115723.oVTfTOS5@linutronix.de> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB57:EE_|MW4PR19MB6823:EE_ X-MS-Office365-Filtering-Correlation-Id: 9336c9e7-ae96-488d-b8c0-08de58f100e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|82310400026|61400799027|36860700013|54012099003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?mFHUccxDA7AvqSULZwpmYLZxetd1Ix657MHm3elGLldAz3/4nSYQIG8FfxuB?= =?us-ascii?Q?QcRuYHK5cNwhMiuR+gu1idnRGWfcCK7Qzj1RLH8SpcFSQYx5wL4cOxKJC6FE?= =?us-ascii?Q?PEbLyWGuEu+qfNJhHOrFFTFN8IrcGFRdMeUQufS8o9/PP1bfNv6YGkZuOI5l?= =?us-ascii?Q?97cReKwd+ZGWDOlYH8kg5NzuNRCN06qzrDCH3+RtSlzoBAMfoMkMsNmoJ6iy?= =?us-ascii?Q?NQUD1jG6zyvrScXicK5Eb3LhzMQlgVyZ9SyoeB12JHfMMwPlpI8L3p/XeirN?= =?us-ascii?Q?hXbRRaQ4wrXeyqCv+w9VyZG4HKCkwm1SFgUIABNMUSR0wLS8512uf3xAi3xp?= =?us-ascii?Q?zJhivZ3V9rHZVb+ai5xY2JQbFqnoFzW+Ied/cUi1fpTS2RXGPmwNWa3RksaP?= =?us-ascii?Q?j+qJiMO4YLdVleZ9ljB8ZZO5LyAOqOacIyMgVDxsgK8OeylpDFyvKkIFWTYa?= =?us-ascii?Q?LAY6fxmaCodaBLLddktbQBAtbS0Hc++7+dxmbLrrNIiOxXnY3cvRpsmjUMEJ?= =?us-ascii?Q?2VLrrR2hL5GPxRs1zPbJSEBaIq33UWtth/n4o8tLjI3EBsIdpefnPdrEGQyN?= =?us-ascii?Q?7Emk+EdPBEceRkJrqcjU+Zb6R+BspzHaE4wQDAhEjyIAoGMnTet6hkYThU+Y?= =?us-ascii?Q?kjXyaqY9KUUC9+f7Bc3uJwlGzhuF+jS68ISbp4V1BPSJW5R12nEuRfKs84IK?= =?us-ascii?Q?ab0Hg3dbXD+6cF8NUwl7Zb/e8dcMjMIsl4/vWts5IXmK2UqeFKDgqSXrKvkM?= =?us-ascii?Q?bzViiNc+fLbAR4dkW+9rm73DVG7yJ+shlkFToSaZi3SQvPgZJ44NElxfq23N?= =?us-ascii?Q?7fEJ+q+QDyFcU4Qs2/T5kZkfAAtCx5tl4v99eOHU+yI1C6KMty1WFZuvjNAO?= =?us-ascii?Q?3k/g1LM3Nqnu3g8PpUrgvUYbzBqhhL9kfOSfyug3aqjnAM/ixs7fcCItuNfE?= =?us-ascii?Q?gv4Tgbssc4mTGixbPE7S1vP6qEVyjnrlXpmI4Lpxz26o4UpMWA1Irow1JHoR?= =?us-ascii?Q?xsmDMk7U9StDo7qBB98ZVMZyQAeJyhyQh+ZvI29YTQITu+oXc0Ovji5j+1y5?= =?us-ascii?Q?QLwPJ9CYsOmF/bO8f0Sy308KlnRRgsLC6Roj/+qSnTYwrl00LTsbyI7on96L?= =?us-ascii?Q?7t1PhZ/Jhgms5kSep6H/J0utfM13TzECc2o1Oi7RaEu3PkZcHDKXJMUiYD7x?= =?us-ascii?Q?vpYkS35kEuWQXowjUaXKt7qEkWqrKNAdOY2RSZbUwo+eVefOBwj8djWcFBX3?= =?us-ascii?Q?/7cxlsCQND76d/qwixGWuRwie66+cGx2neSosOKYVxgHhg/ZkbEjxN92Y8Dk?= =?us-ascii?Q?Da5KYr/30AH5ouTFqP17LHA44TuVqPx4kSRGOC0l9A9pq3N/mrEF8EuDnLOs?= =?us-ascii?Q?oXBMLO3zEnIuELsQPEmte/voYyziyfkQMKddJ+3a0iy74gGQcT3F6dn0bJyE?= =?us-ascii?Q?Fr5lUeubKQnvziRRe4HAoNto0t/2F4cWeAQebhhI4KckQQBO+K3IIjvTAkwt?= =?us-ascii?Q?PZ7hjeSCAhf2FTrL28A5iYhWO9GbtGQL2+KVNYBf9ZsIIpg5KYiP87FB0MOQ?= =?us-ascii?Q?CuGsnDTwIXD107LLk+NdwajEZQl+J9Qyi1nV+qvGxittnAYmhpwk43Ggwf7G?= =?us-ascii?Q?MH6PYwS7sap5MtM9Yz5Na0FympGm2Gf8maUCPdrxo6emp0Ic7Oi7huSvGZj1?= =?us-ascii?Q?iOtQIg=3D=3D?= X-Forefront-Antispam-Report: CIP:84.19.233.75;CTRY:GB;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:edirelay1.ad.cirrus.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(82310400026)(61400799027)(36860700013)(54012099003);DIR:OUT;SFP:1102; X-OriginatorOrg: opensource.cirrus.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2026 13:28:45.6633 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9336c9e7-ae96-488d-b8c0-08de58f100e7 X-MS-Exchange-CrossTenant-Id: bec09025-e5bc-40d1-a355-8e955c307de8 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bec09025-e5bc-40d1-a355-8e955c307de8;Ip=[84.19.233.75];Helo=[edirelay1.ad.cirrus.com] X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: TreatMessagesAsInternal-BL6PEPF0001AB57.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR19MB6823 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIxMDExMyBTYWx0ZWRfX6aY3WPHhawJ+ 70Zu6e9nZcoHl4o827rgFN8IsqsWn2SBbkKBf+QoQGy27lv2gD1byloth4vi8PUIDgiUJZfQ22i 7P7Dx2F2KBxz1Mt3kV6tb5ESSRrncJr5oVhCyer//HIPchdc31tlbYMKWsiungg69OSZ8M2jUFx SRklvr+7SzpTrRKGYDBv6GkkEz9HEE/+3f1ihShDnewqd2q2u9E5eUgwYbQHxo8uihkyUY1xSZH 0n3YdT5M6hg9IQv+BQOKQr+chlqeFODgVlsJ0YLrRp2XOihjYnzVp/lGf51WcNC8nVOvphiZLl8 ZDSU1nFptUWPBVZdY6ZE+sGdo+m8oYUb8q/8uPfdqIl/j/x6X9h/54SzGFn6XyKGDnHw/hiih+C 4+76+YGMJqARmEyvn9QYGOBovjsrmrV2jMjwZmj+P+Y1moCMX4zHRJmnYwq/RfIBS157lGSIi2w XnOr+YaNS56RCkl2ozQ== X-Proofpoint-GUID: tIjx-xSDLorgHhIh1IB8PQzW8MOVWmr9 X-Proofpoint-ORIG-GUID: tIjx-xSDLorgHhIh1IB8PQzW8MOVWmr9 X-Authority-Analysis: v=2.4 cv=JbmxbEKV c=1 sm=1 tr=0 ts=6970d491 cx=c_pps a=gFm19s7yh3VV2LjzJhowOw==:117 a=h1hSm8JtM9GN1ddwPAif2w==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=s63m1ICgrNkA:10 a=RWc_ulEos4gA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yY2TmA5H_jcUYtwn87IA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-Spam-Reason: safe On Wed, Jan 21, 2026 at 12:49:11PM +0000, Richard Fitzgerald wrote: > On 21/01/2026 11:57 am, Sebastian Andrzej Siewior wrote: > > On 2026-01-21 11:53:28 [+0000], Richard Fitzgerald wrote: > > > Ah. I didn't notice that. Confusing error message. It says > > > "handler=NULL" but handler != NULL. More like "handler=default". > > > > The supplied argument was NULL. > > Anyway. Do you happen to have an answer to my original question. > > > > Sebastian > > Afraid I'm not familiar with the WM8350. > > But I note that call is not registering against a real interrupt pin. > It's registering against a virtual irqchip that is itself a threaded > IRQ handler. Maybe that makes a difference. That top-level virtual IRQ > handler is ONESHOT. Yeah I suspect there is some trickery like this which means this doesn't actually cause a problem in practice, since these are internal IRQs to the chip, and the IRQ coming out of the chip is marked as one shot. So the alluded to IRQ storm probably can't happen as the chip level IRQ is still masked. I also note the driver predates the check by a good few years, so it wouldn't have generated any errors whilst being developed. To be fair it has also never been the most heavily used driver, so quite plausible no one has noticed the error message since. I would wager the correct thing to do here is just to add the ONESHOT flag in. Thanks, Charles