From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC96F3559C5 for ; Thu, 22 Jan 2026 01:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769045542; cv=none; b=UwW0/Qyxhb4uf3bgB/XGJ29jUluHGJSBdB127c3XiG0focPgzUdq0hLJ6NcuwDENTi0Hd7YrAWc0bxF0bbxP27DRwSuG4TKD45pUhsZS9FsB6ZL1/LRJh/UylEPZvgTYeBiRNZ1/iG6HxIKef4dC0QXq2+BvOaLz0hhvs/3c1hM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769045542; c=relaxed/simple; bh=ms5pWR92u/Sb/qm5qVz6BRpgwmPmV2/bOD5kn3A20VE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=N99Gg/re1/OOuKpz4qat/mkUd/SMq6SHRwPGDiPnLc1NFLvY3QCasRQ2OGTLfP91+sdoQLOmUvcJ2xa+rz0j+2rRFdfj4KP6q8iRjGh31/fBNE8RhEecF7OAAk6Q4Bt+1gCgD+KBED9luoPSjlf2C6IChl3qNNhwl3fCvejHItA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Ly4zBtNG; arc=none smtp.client-ip=209.85.210.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Ly4zBtNG" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-7cfdf7e7d19so414324a34.2 for ; Wed, 21 Jan 2026 17:32:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769045540; x=1769650340; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pGEOJU/uiNboJwAtLEE6S07BEXT+vA5BV+sOD/aPObo=; b=Ly4zBtNGOsWuenFBXqarXsc1pXMk8kmEdwgxFT3OaFiHgmxS9sw12CxYYbnCDyuZ3X rAJfq4HI4AG0PNjfojREp404Tsx5oakRGvOSi2WfEtrAQniVYH2mKarfo799tnmOiEY3 lmRnOvU1UzZ0+xOPZBgG1zsnUY919tOCUEDlRsFNc8pG9FkLTLilWYv+kuCx+r5yRLHg orTqTlM7ehDgkovYEzL7Sf6Lea6Qf4hCV8oYRGvfXxxJGBJ14cTZLPoVYOKS/kPU0CFv puwtpzrIJev6fX3D8YMnLkbK/Fxl4giky4SuQH99G6u/oWiUDsmEhzdu9O8QyAP0Ylqn I/iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769045540; x=1769650340; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pGEOJU/uiNboJwAtLEE6S07BEXT+vA5BV+sOD/aPObo=; b=PpPEQxZicjFJKE6iHqHb0ASCqBBquvkfcZv73P26uEAmDdE+H1DZFD56/+wTp52lHS gzg7Gc2IG5QHu6ygQHQZlgvWwBUo37A/hTWs+Z7czimuHfsyuzo4CiXIkHlaO6zn7hup iTzttlyInyH79+RGGgIu6P8YaHBHs+C+4jtEiOlBGFLIVXNpGeCAox820TBwPmtRJztY NIM286yDL5tTAQjlaqHtUwsv0xMTIb6yHwJ+zEEcUHccccVA0FbDqoOsoYzFbxuNJP9F 19E7kJzl4yn5+UWR8Vf2Na2YSxw3W+oijjBepo0n+LitdpbDIEID5Yxa+bMgULFlvxZD qGnQ== X-Forwarded-Encrypted: i=1; AJvYcCUMBwfxVxuH0H1Ib/it36cAuUC2Az1YJ+jxBQuQjbE51033RjChCBXXwvr7b3qzmRn2/Q1ykDlQazOJAcQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyLWgwoC59Y6Kj82JC38MqNu+vc2GGU9ZnF7c29XiJuJVo9De39 ibdS4vR8fr7KBbeEVf6Lnj03y/uQZK9XrxT47gK9oRg74shz9IvtUeRlDrt7rE28 X-Gm-Gg: AZuq6aLYFnAcQXTAoGnhSvOKXYdhRev5Bg1eKoyFiOnCkfIzGsE6sF1WQHXSn2diIll zMZsWzersjrcR+kxTJ4indBp9HzfB8i6ZLUnQEDDret01fhCA7AXKcLqGMbe3Nb1cUp/PuZ8EUQ kWmdcv5Z4P2Xjd2xYeZ3wmMa/LA836acQ0RYDNl3XLi0a5hP6dpLhsxmal8OJvgNH60HAlBbzBZ JZEOtle/FISgaXZCLES5e9pKZTnVoyfVEiY4800jGVXK3USt3X9xJMNh7gfdi+JGtrcwPkLxiEO RCNnVI2rkCnYmQ5KjIcF7ZIBkoFkbQZzbji/efESLWZDi4HETTLXUEq4KE9Gyd/r4wCAPVqC6bp qhYf/O+bybULWjIGladTDLDyhBl9LB+Z4m+k3xAJWCMlyIAw7UaeHGel/s03/UyxlrnRT8ZXfmZ 73hARdjGfOlmsPRLLBbWsF X-Received: by 2002:a05:7301:408c:b0:2b7:143a:9a8f with SMTP id 5a478bee46e88-2b7143a9e6bmr2183820eec.7.1769039928585; Wed, 21 Jan 2026 15:58:48 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b6b361f5d4sm23459514eec.17.2026.01.21.15.58.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 15:58:48 -0800 (PST) Date: Thu, 22 Jan 2026 07:58:37 +0800 From: Inochi Amaoto To: "Russell King (Oracle)" , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yao Zi , Yanteng Si , Vladimir Oltean , Lad Prabhakar , Chen-Yu Tsai , Choong Yong Liang , Shangjuan Wei , Jernej Skrabec , Boon Khai Ng , Maxime Chevallier , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next v2 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260121071315.940130-1-inochiama@gmail.com> <20260121071315.940130-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 21, 2026 at 12:05:30PM +0000, Russell King (Oracle) wrote: > On Wed, Jan 21, 2026 at 03:13:11PM +0800, Inochi Amaoto wrote: > > + mask = RGMII_RX_DLINE_STEP | RGMII_TX_DLINE_CODE | RGMII_TX_DLINE_EN | > > + RGMII_TX_DLINE_STEP | RGMII_RX_DLINE_CODE | RGMII_RX_DLINE_EN; > > + val = FIELD_PREP(RGMII_TX_DLINE_STEP, tx_config) | > > + FIELD_PREP(RGMII_TX_DLINE_CODE, tx_code) | RGMII_TX_DLINE_EN | > > + FIELD_PREP(RGMII_RX_DLINE_STEP, rx_config) | > > + FIELD_PREP(RGMII_RX_DLINE_CODE, rx_code) | RGMII_RX_DLINE_EN; > > So your reply where you basically stated that all the RGMII.*DLINE.* > constants here should be the same was nonsense. How can we trust your > replies? > Sorry, I have found there is a mistake for replying you. Now I give a detailed description about this registers. You can check it at https://lore.kernel.org/netdev/aXFnmXIwSdKCS9Uc@inochi.infowork/ Regards, Inochi > > +static int spacemit_dwmac_fix_delay(struct plat_stmmacenet_data *plat_dat, > > + struct regmap *apmu, > > + unsigned int dline_offset, > > + unsigned int tx_delay, unsigned int rx_delay) > > +{ > > + bool mac_rxid = rx_delay != 0; > > + bool mac_txid = tx_delay != 0; > > + unsigned int rx_config = 0; > > + unsigned int tx_config = 0; > > + int rx_code; > > + int tx_code; > > + > > + plat_dat->phy_interface = phy_fix_phy_mode_for_mac_delays(plat_dat->phy_interface, > > + mac_txid, > > + mac_rxid); > > Maybe Andrew can confirm, but this function was to fix up existing > broken DT, and shouldn't be used by brand new drivers. > > > + plat_dat->clk_tx_i = devm_clk_get_enabled(&pdev->dev, "tx"); > > + if (IS_ERR(plat_dat->clk_tx_i)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(plat_dat->clk_tx_i), > > + "failed to get tx clock\n"); > > As stated on the previous series, please don't abuse clk_tx_i for > soemthing that isn't the dwmac's clk_tx_i signal. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!