From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8211F2D8797 for ; Thu, 22 Jan 2026 00:29:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769041801; cv=none; b=h6s/3Oi6rBzzZ75WCfQvYP8xFzfqj2d/KYO2CgdA870GhVobD7l1aBw3seW78jFSZIKZEMWG4NVfDhZ0vNerOW24gngWMMDa6IWbp5aWHLNxauM3JvHJ1/v54YMOpbJAVWeiFfodADn1M+aLWmh3zNQ3CBGk59YjNvhrOa6WbGM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769041801; c=relaxed/simple; bh=lxbS6mXH2DJytQVGlFnthobG4ZmqTQXYckFy549cSX8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=TE+B0Sl9C/nnbkwHJk+rt8TfaXlVYmcepu28fSQ2GcIa5DZqtKJgPPR6vxbshijQIg5tLYdv2kDHtL1fSEORa4yt0p1uYxMCnSvi7c62S4GM0VTAAo9IlXQWE+1FtoZBm2KtOrVmQEDQ7ZQiVEP5T/QOzw9GzxBVQdTnH+rut8A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YhC44JoQ; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YhC44JoQ" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2b6fd5bec41so790700eec.1 for ; Wed, 21 Jan 2026 16:29:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769041798; x=1769646598; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=aLRvrHf0GT+SLm7VDguQ+pvYrJH4LqQuaP1lqxnXl2s=; b=YhC44JoQVr0iyA0O3VykimbOCV40j71fYGcbpElOEQNPYJvM+AP206sH1GZspiKNPW FTtGvn28GRXJK/68tXjH/NJtQLLlQCQABt1fJN/uiCcBRxC9gA9konYRwZWP5ILjdesG rfP+iY6c2jC/9RzYMgbOi0NdsFlNgEdwnqlfJfu3U1GxBrzJrKB3fFSgyp3GBQcV2rT8 hPBEMnWjIlvB36sI2dFzyvTUKQcrkiOsfv9hgUXJ69dBl0DoOGRJTwe7R50JFR7B+zpx ZW4COeoQmh2tdWkefPVo1Im2XgH81xZ0fFzzQZ0M20tTkL4YKCg2/AUvnzOZIDmt1y68 LL5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769041798; x=1769646598; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aLRvrHf0GT+SLm7VDguQ+pvYrJH4LqQuaP1lqxnXl2s=; b=g3MPLpLxzClg3vWTypHN5AusjxqJdd7T/Gp0OKWq4e+kRqPnVyg/V1wMx2hXXSFHza zNnDLS+b7w5EHE6w/eiXmMo/GEHCqZhGM9ZkIN7tnItKr8DjY9wfPD39mqeG7eF9Y0OW 8G0+XAnH+ZJNHykSRlBD+0FGdaR3fJc8ilQCD8lZQ+gktvwqCDd2VpgqrxjMz2Ud2Jg+ sqVsC+4wgy5cHGANy7NTvv68quOXfJ15F797brRlUHQiwlOritMM3KC9XVljCV9hA3iz dpLRm1ipLf01KlIvAMMuyr793avCxVO0WIBS86/0Gi7Tpe21sI0AcncZv+btKPWo4Z8i rvzw== X-Forwarded-Encrypted: i=1; AJvYcCXkchqSWcdQTR+pf92hJ55IWL7O/Sd0cfd4fKsCokDhU9Rm4eLxsahTZF64tYp4GS8SWK8Ad4uZuTGlUW4=@vger.kernel.org X-Gm-Message-State: AOJu0YzytC+eOBuN99XYTrQrkIKC6pXi6KXlaXmjuSwH6++V6QcUy6kL G/kvTwn+QE+f49eAa9ujDaejnzemZx8lsAineNtVpNEBaWHC5aL0XN74 X-Gm-Gg: AZuq6aLA+Y9UaYzb7lF/sAWpLjXkKH7K71vxn2fN1/oQnh5j5blf+KhKN1xaGejuIZE d4Rp/ITpRnCCvMsWo+RK0988vGyQzMs7LD7wunYoKivRNwC5XUE5BrBtGcM6xmaKoByWhcB+bhm NAkahgnkmBAhLD84ooDR4p/9zJzHS8JgV5P83CU67UW44Cr4V1nW2xSOr3D8Wz+G3hNjgElb42+ nV422lo7NSTxoEJm4Cqt06heyB2ap51/YlUMyGUwjArG5ZVzJF2QXFL7WpTta5ZF7QyUPPx5bXZ lPc8vW6XY0qSgee5G5Rp5mVlBk2JhTUy3uduueB+8NgOjg+Vo2lirx5hCYzrNcQNChXVOi2yWXC b+mIyCMFQhEtN5HGiqwfXxyAN3JNgzUQQhB4ymxUWNlhobleU02Tw0juXOatv1znaBgXq364GO9 0thpk5NEGdUra49MKItNdB X-Received: by 2002:a05:7300:324b:b0:2b0:580b:856c with SMTP id 5a478bee46e88-2b6b41005a9mr13294371eec.28.1769041796817; Wed, 21 Jan 2026 16:29:56 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1244ac6c2besm29548495c88.5.2026.01.21.16.29.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 16:29:56 -0800 (PST) Date: Thu, 22 Jan 2026 08:29:46 +0800 From: Inochi Amaoto To: "Russell King (Oracle)" , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yao Zi , Yanteng Si , Vladimir Oltean , Lad Prabhakar , Chen-Yu Tsai , Choong Yong Liang , Shangjuan Wei , Jernej Skrabec , Boon Khai Ng , Maxime Chevallier , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next v2 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260121071315.940130-1-inochiama@gmail.com> <20260121071315.940130-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Wed, Jan 21, 2026 at 12:05:30PM +0000, Russell King (Oracle) wrote: > On Wed, Jan 21, 2026 at 03:13:11PM +0800, Inochi Amaoto wrote: > > + mask = RGMII_RX_DLINE_STEP | RGMII_TX_DLINE_CODE | RGMII_TX_DLINE_EN | > > + RGMII_TX_DLINE_STEP | RGMII_RX_DLINE_CODE | RGMII_RX_DLINE_EN; > > + val = FIELD_PREP(RGMII_TX_DLINE_STEP, tx_config) | > > + FIELD_PREP(RGMII_TX_DLINE_CODE, tx_code) | RGMII_TX_DLINE_EN | > > + FIELD_PREP(RGMII_RX_DLINE_STEP, rx_config) | > > + FIELD_PREP(RGMII_RX_DLINE_CODE, rx_code) | RGMII_RX_DLINE_EN; > > So your reply where you basically stated that all the RGMII.*DLINE.* > constants here should be the same was nonsense. How can we trust your > replies? > > > +static int spacemit_dwmac_fix_delay(struct plat_stmmacenet_data *plat_dat, > > + struct regmap *apmu, > > + unsigned int dline_offset, > > + unsigned int tx_delay, unsigned int rx_delay) > > +{ > > + bool mac_rxid = rx_delay != 0; > > + bool mac_txid = tx_delay != 0; > > + unsigned int rx_config = 0; > > + unsigned int tx_config = 0; > > + int rx_code; > > + int tx_code; > > + > > + plat_dat->phy_interface = phy_fix_phy_mode_for_mac_delays(plat_dat->phy_interface, > > + mac_txid, > > + mac_rxid); > > Maybe Andrew can confirm, but this function was to fix up existing > broken DT, and shouldn't be used by brand new drivers. > > > + plat_dat->clk_tx_i = devm_clk_get_enabled(&pdev->dev, "tx"); > > + if (IS_ERR(plat_dat->clk_tx_i)) > > + return dev_err_probe(&pdev->dev, PTR_ERR(plat_dat->clk_tx_i), > > + "failed to get tx clock\n"); > > As stated on the previous series, please don't abuse clk_tx_i for > soemthing that isn't the dwmac's clk_tx_i signal. > I have seen this comments, I will switch to a local variable in the next version Regards, Inochi