mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xu Yilun <yilun.xu@linux.intel.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: mdf@kernel.org, yilun.xu@intel.com, trix@redhat.com,
	linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fpga: bridge: Use sysfs_emit() instead of sprintf()
Date: Thu, 22 Jan 2026 18:03:59 +0800	[thread overview]
Message-ID: <aXH2D06eZ5DRTVi0@yilunxu-OptiPlex-7050> (raw)
In-Reply-To: <20260117043626.2188219-1-dinguyen@kernel.org>

On Fri, Jan 16, 2026 at 10:36:26PM -0600, Dinh Nguyen wrote:
> According to Documentation/filesystems/sysfs.rst, show() functions
> should use sysfs_emit() when formatting the value to be returned to user

The doc says "New implementations ... should only use ...". The existing
code is OK, the patch is also OK, but sorry I expect we don't churn code
just for doing it. We could also append these trivial changes along with
patchsets that make real improvements.

Thanks,
Yilun

  reply	other threads:[~2026-01-22 10:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-17  4:36 Dinh Nguyen
2026-01-22 10:03 ` Xu Yilun [this message]
2026-03-02  3:39   ` Xu Yilun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXH2D06eZ5DRTVi0@yilunxu-OptiPlex-7050 \
    --to=yilun.xu@linux.intel.com \
    --cc=dinguyen@kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=trix@redhat.com \
    --cc=yilun.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®