From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D157C2EC08C for ; Thu, 22 Jan 2026 12:25:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769084729; cv=none; b=u1dJj6EIhIOH4K2Z31Wm0+6jpGIATvDlKpD0tHifeIaZ2RnntR8jYbwkREtk4GQdqlaBO2Qj5hb+FJhh8FRIf+NA9F6FIXqMdxpbOzeU7FPQRyFKLq0chQV0EmllskD07bI4cK2MytEVbxlgLh/Cdk/dG25ORYM87dB3rt/G4r8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769084729; c=relaxed/simple; bh=PCkOwqNi3U6oGSdDkbyRnZsslygP62vGIxEK1b/bxQ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VpGG2ZmT0eKWgj/H5CvhFV8iP/Hcl1/xMgBq5TCvsH43Lmlq1AVc7lnv7zDyYZLjQ8V8pLTSNYU/VzYNJZyu+uEtf2UuQW6gjYjyUQ+dPh69iTtWvH90V5StsccybjkMGpTLZYy+uZgu3ayOJjovYB/ik6fAWVI9kbzT5gCwmAY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PQZMG8wW; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PQZMG8wW" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F4A6C116D0; Thu, 22 Jan 2026 12:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769084729; bh=PCkOwqNi3U6oGSdDkbyRnZsslygP62vGIxEK1b/bxQ0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PQZMG8wWZN9e21tL896qXExBf7Ly8WOAxcQfgRRBjdV6c6MB5ESaYKNZ/2KMxoiW7 CEkJA4YasricHEv39yRk1rCaoeHwXaCkH35QI/T3ltW+D9wVl3xlwzE5d2B2FAf2nF U/xDGrHK+cYsRSMDLkevmErJFF+lHFAkuod9FY9uiJuTIY9JvZvRt2xpaVuiuLqv0d fn+Fi6hBDHOYEjM4dtBg2HVZ0vBtXoM0xnBxS5iRROpt27H8Ku0N9ctgRWOb7IO9E3 HbcLDNorXm4IDySDEM+U2zT9kvZA6VIxyXw9RC9k89aF1vH8KN73OCb9H3UYb8lwuQ 1DKiIMglmMPXQ== Date: Thu, 22 Jan 2026 12:25:24 +0000 From: Will Deacon To: "zhaoyang.huang" Cc: Catalin Marinas , James Morse , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com, jeson.gao@unisoc.com, xuewen.yan@unisoc.com Subject: Re: [PATCH] arch: arm64: set __nocfi on swsusp_arch_resume Message-ID: References: <20260122114925.624309-1-zhaoyang.huang@unisoc.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260122114925.624309-1-zhaoyang.huang@unisoc.com> On Thu, Jan 22, 2026 at 07:49:25PM +0800, zhaoyang.huang wrote: > From: Zhaoyang Huang > > A DABT is reported[1] on an android based system when resume from hiberate, > which is root caused as CFI will plant stub code[2] to verify the > swsusp_arch_suspend_exit's authentication, where the hash value is stored > before the page that alloced by create_safe_exec_page. We also have > tried to copy the hash value together with the function but get failed since > the value is not on the desired position(src_start - 4). So we solve > this issue by setting __nocfi on swsusp_arch_resume and it works. Acked-by: Will Deacon Will