From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5078C367F53 for ; Thu, 22 Jan 2026 16:57:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769101058; cv=none; b=gwqOvhZ13+5yowFzaZCKEUFJtN99VFQ/ApOVes6HFhRqrGijmiLfTN6QvZDZrcP3YkOjp/vEgPjvjyuKuJ86Sz+gIPBAi9rqPpROYwy8l6/ZfRtELCEf1/XgUCsRj/5u+gyRcNyEVZD5u1prEDvDYqADz+do0C2tAELDA3Y+uMM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769101058; c=relaxed/simple; bh=LSXVwsb7oP6hszGcSKJ2CS+0o3d0D/NeZ6boyq0aY4M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mxhbJMHLClo8dcSIZEe9lsMt3Uhd25FkaT41P7r51yKxKk5U3+qxpXD7EGYqzknUZzPMxd8SeRfYMTSLcMzuMC80gorALvE1pIuo5YnivLbpIgvp3tHL74VUQ4JkbUXegWxXFKw02CAGB2dEkPd43zWkG1MmKqW76klrtq3xdtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=DzEiakQB; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="DzEiakQB" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-81f46b5e2ccso822544b3a.0 for ; Thu, 22 Jan 2026 08:57:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769101043; x=1769705843; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hw0kz17cu1JML7M8LP+uoFtfaF2aE69iQQ3t4jbarDY=; b=DzEiakQBLbs0f5g5nBTecM1ubfwuRCqFmOzKMb/Sjj+NwhQelMg6kiIF2ZILvE70VV 2rSKJBuT5wWCHkbbbpaaYZS+hS/dxjp15liw4/Q/PRjlP/cW1sqxkUvrY265gowWlOfc KbzEVCkxsKIh0z8yzrXku++vGntazTxHDEAhR+d4ezoT9uySqiX8OSWZL49z/SArrsSG nk1NieJvrcrBcwdVV/PEv7EmoT/TgfmQbifgTBpUxoQ+Ek6HA5/ivkTb+6YPjEdG6Nzn 6EoarPKp97PawggeFN5Uw1Cq0icZswMprjmp9K62ojTLN04k2NmXGeuRlwmDWzNbAJYw CgBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769101043; x=1769705843; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hw0kz17cu1JML7M8LP+uoFtfaF2aE69iQQ3t4jbarDY=; b=c0ZDfWdTt12SXG2R+rxeIR3MFg80+S3ApZ54x/xfONUZYX5kBXXAdSmf4IC9p/PgNx Jz/MxkrQse//+weYqty4urDGJcXeESYVPEJLOXCnzdjIvLxxDWASqfO5I63Qe5bunJE4 5Rv0MUXQ8yJoKjLP68oBv9v0KX8ywmO84yOUXZOFaRTUkiyW5/pFMNdRIaQb6H3vWoqL PpwXbWbpN1rEDn8To931B2ySS+4uQAkGS7PDNYdWEkjfsZa9Cy0fWiJcrX7pecAmPtb5 6OMJF6pjrwi7e7mSnud65Y8ZhGA6DZdX7z+JnqYsFLfK9Dax4UeWVqcwyiYqhEljXkp1 VGDg== X-Forwarded-Encrypted: i=1; AJvYcCXCY4yoHH3f4hB78sjYfJr+0V553hc+qVQaKumAS3pdHU13AhdZIYxSAoT2wds08T8LI/+kEAZnWIk+iYo=@vger.kernel.org X-Gm-Message-State: AOJu0YyN4g44pa7NPxFgS9Ofhh3CINkqI8wIB5TPnBJnWCcgXMnHLOlp Qj0MheGyd86diO9GruuisYzcJ01qPjQAhcOtQQh5c120wKcVOSAsqmho X-Gm-Gg: AZuq6aJxDDcF32I1x0AP128uLF09crQroV1xjdiTJFCJlO4OfNtuNnjKSQscCFbCwV9 LnRNksIOxfLOPS52IcSzqpu1k4NneYJj6h6gSA5Mala4K5kd7hiRHZTIxOkLHl7xp8gkLDIRZOw RHiMvONQdcWu8a0jFfb0WmRRMilCjytWi9t4GEzLnN5S9cWOvAZkZGsdOevGKFgsXLXUDmTWneR dgRJKDVlON3o1SXVEBTEn5bADCnTAjcr83EH4K6qQb1cvCCGEqwLPdnmME33/w1qfeJQYsiKueh 3osplkfTZLKLmuCNxJ0RceQ8b+pvhvu9utAAFDmCKHazv+EN/pIUPbQgWTZFe/n98NF65TwVm6e E26D0GhareSKHh4UgGyXbmQ7OJgoLdhGAIDiJAQ9979Ro9yVfP+ulTHccXaQJhtmZ4cQ1xzyF+I RU2yLCTqGgX/m6zXJDAOrdA3V5r1k= X-Received: by 2002:a05:6a00:6d59:20b0:821:7307:44cf with SMTP id d2e1a72fcca58-82173074604mr5405381b3a.15.1769101042810; Thu, 22 Jan 2026 08:57:22 -0800 (PST) Received: from chandna.localdomain ([106.222.229.181]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-81fa12b51fcsm18515667b3a.68.2026.01.22.08.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Jan 2026 08:57:22 -0800 (PST) Date: Thu, 22 Jan 2026 22:27:14 +0530 From: Sahil Chandna To: syzbot Cc: jack@suse.com, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [udf?] WARNING: bad unlock balance in __wait_on_freeing_inode Message-ID: References: <69717cbf.050a0220.706b.001d.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <69717cbf.050a0220.706b.001d.GAE@google.com> #syz test --- a/fs/inode.c +++ b/fs/inode.c @@ -2521,14 +2521,18 @@ static void __wait_on_freeing_inode(struct inode *inode, bool is_inode_hash_lock wq_head = inode_bit_waitqueue(&wqe, inode, __I_NEW); prepare_to_wait_event(wq_head, &wqe.wq_entry, TASK_UNINTERRUPTIBLE); spin_unlock(&inode->i_lock); - rcu_read_unlock(); + if (rcu_read_lock_any_held()) + rcu_read_unlock(); + if (is_inode_hash_locked) spin_unlock(&inode_hash_lock); schedule(); finish_wait(wq_head, &wqe.wq_entry); if (is_inode_hash_locked) spin_lock(&inode_hash_lock); - rcu_read_lock(); + + if (rcu_read_lock_any_held()) + rcu_read_lock(); } static __initdata unsigned long ihash_entries; --