From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA9BE32AAB2 for ; Tue, 27 Jan 2026 06:26:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769495209; cv=none; b=isaVIBSV164WaFKUE/R6fv59rwkkLbbtzGnl/PWaCr8FN68n7u8XHjgPlWM/CBxt3fBJdrwiLDRvsU0iUmLoME2IwE9jO1ly63mGwjTBCxPbvirj1T0bol4tl/kEUuY5Vppt9uzNEki5rCaQ9leInkp40sP5JYs2yBcU6Ovg+A0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769495209; c=relaxed/simple; bh=mvGSzdFrf6ktT23Wvc2fARPlRM9iZ/TGeuMGvdnhMsc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uiiVUmqaBYWYqI19I1nFDvadhONHT3GF1pMYRocjya9KwY2NDER+tIFRP15Wt1LtZtcho04RpxC47JNiIYrqXx9X75fYhmBY8FrqM9GTthdUNnRL1IHY5Xuaph4swFLqq1dBFxXRAbceI6n0VHU3VghK7VvDWptQN6zB9LyoAw8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=a3U4voYX; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="a3U4voYX" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-47ee974e230so47502905e9.2 for ; Mon, 26 Jan 2026 22:26:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769495206; x=1770100006; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cHceQO5mKauFppm7gw7JuG5uFaf5j0b4wTe4U6o8e6A=; b=a3U4voYXgp3BUGScFP+auPsMkhCg1PtPDeSG/bllVX6F1XOpolaIxfZRgGL/lQa0DC HPmHc2nfjFDoeqzuBytfRDF5orkpn6MvdFdzpiZ36RNCMvoKjMGOY/3qORsrHClrN9CR ExpXywLabKiqvMub28ltGQVA8ID7ZvAY08MjOKIpR5Teo0ZUg+2J90F85d6gx5rzWYc8 axf/3ziHov59q3wL2+IKv1SyzInfOmhDl0npklQod3DVtQR/62hPuJUZ1jrOW6UdnaPk fA6DI70ciZjK3YIzkLJ7xI7XM6k0OHktcniYWL/NdFYaUAceDrM2Bo+OltLIKxbouKR/ jrwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769495206; x=1770100006; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cHceQO5mKauFppm7gw7JuG5uFaf5j0b4wTe4U6o8e6A=; b=kFeyKYwwt2GKhhnhS7HrERzrlHqvLP2UfpHdqlgwcaG0NTk/6YLZnJPFdqaDWwuYdY s43s4qsguyd03zkIW1K7qc737/MIq1o4dzIPJEOKBZEExBXgtpFMDoJhixGcyNhbl2Up kTky7sZWJ5smsiKk7xIYAYwO4QAkqlUlwW07Ig8c6B8+bjgb/KAd1I4A70+U4LpYtPUU VnpKYydWZ++MqsY7irvE62zcHp+J5RzD2IP7KYzps9M7ZCzfMtY2q63RAnbTKerBKKM5 Qle+xin2ykalGWEGE/aaV2NB/dZOmwqzipNVrErtuNAajgvztRJ2LdfFBlvrj2EODZGR XtHQ== X-Forwarded-Encrypted: i=1; AJvYcCXqUxjFOszPtCypAaFQTC1H7adi4OPrcshwzJmB2P8JFMb8g3xq1FpQ+DQsUGTGg4PTrJzIiGa2zs5IJOM=@vger.kernel.org X-Gm-Message-State: AOJu0Yz4niqXUX2mPkAa6zh7+mmiQEF4tC8fmaEtcrDLjjEt/b+N5pAo AzbL7kWusjCP/sxr9jpOocgWNpfUgc5uGUHwmi/FY/t64KThoVt0yCPoUKigEYsOSd0= X-Gm-Gg: AZuq6aLflKe7WJLEPkIo+gOq6Qv1c4518Z8++NzQtAYaGom7SH2BZTB3VD6rk8019Iq xjRbyITgQ4ZB68Yp+TAY3Gc4LJlyl6xegzK4IaJGcpX4Tx8gkbSMiDuuYM6RSxMIxvSDeFJVjrx gKAUcZGHkA1aaiAaR7rEdGH7i7yfHOaYJ2NKOm4NLYV8E5ErknhpyHnU8qQwODM1arfDgTPR8kt 4KIcuaSIaxFVehkn5d+VSnZ6tDC2JlFryno9f0Zuo4E01ZEsdt0ZcNv0k4FFilr2OsKzJLuRBPe vWT3PcbNo8w29UpIj6VZOIt1oOYjyANQje2RMPXZpKJynjdOnu2qLBtcELTfRLyeNgRkkT1I/Qs uuZBbDOfn6sy818likft/YuZn1j+g7KeYfUJKmZwjUUJ/lEYA9MElpeix4NMyEmEqD/SiFifyGl RxNnGfoE5jWRKlhxg= X-Received: by 2002:a05:600c:e40b:b0:479:3a86:dc1c with SMTP id 5b1f17b1804b1-4806a5bef0fmr3624545e9.36.1769495206158; Mon, 26 Jan 2026 22:26:46 -0800 (PST) Received: from localhost ([41.210.143.248]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066be7730sm38491865e9.3.2026.01.26.22.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jan 2026 22:26:45 -0800 (PST) Date: Tue, 27 Jan 2026 09:26:41 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Michael Straube , Hans de Goede , Akiyoshi Kurita Subject: Re: [PATCH v1] staging: rtl8723bs: rename members of struct registry_priv Message-ID: References: <20260126141543.2527-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260126141543.2527-1-ethantidmore06@gmail.com> On Mon, Jan 26, 2026 at 08:15:43AM -0600, Ethan Tidmore wrote: > @@ -750,7 +751,8 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel, > > void PHY_ConvertTxPowerLimitToPowerIndex(struct adapter *Adapter) > { > - struct hal_com_data *pHalData = GET_HAL_DATA(Adapter); > + struct hal_com_data *pHalData = GET_HAL_DATA(Adapter); This is an unrelated white-space change. Don't make unrelated changes. > + struct registry_priv *r = &Adapter->registrypriv; I feel like you did this to avoid going over the 100 character limit, but please do that in a separate patch. I use a script to review these changes and I want it to be a straight s/old/new/ change. Plus, "r" is a bad name. regards, dan carpenter