From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 603F12C0F7A for ; Tue, 27 Jan 2026 09:39:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769506768; cv=none; b=tpejenr5Te3TbaGgyiy3yVfsFVrZr7RtgEF5yEWs5cE5otFT9PwUsNMwCBOtTHmliIe+6mkkDH7aRjOxLb/CHHAACWnDapWqIZ2P1gk/GetRdWDcfYAnckTX8AZPtXxujcDFY2jCL/aKNc0NONBapboHfuKV26eXQYYR2t2ThAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769506768; c=relaxed/simple; bh=I3s8D0ZU91T52VwzCxt8vLcmvK3I40yU4xTgHFtzys0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mPJES/N05drzIujoqNq9c9+FTpxRlkx2rdkYgIfDXUDZgQ4XkhJ0zIeLlpoKBDR8LQENvkZy1ZvbaorpRPHr84MpYEYnv8eVL/OzMQFELHeOAJ1Mzlo0EEn+bwrmzUm42cuDyXwjVsBxl6ea0dyHTjolSQAZVikU2r6Vtm1IEp8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KUqhSAIA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ju8wnL8u; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KUqhSAIA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ju8wnL8u" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60R4U08V3857536 for ; Tue, 27 Jan 2026 09:39:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=lovvu2GU251dCX9r+xMYucJV cTWVctZ/NYUkFjYRq1M=; b=KUqhSAIAxUBNkToxY1XnlQNHTFgwlV3Pvk8UcxLO b/LckxauVRVfL1XUOiHjOkFHtdDeccCyxzvim8RQ1rhZdTFOuzn7wkJmcmvt7EZC kOwUmobdM2MrIf77igTUORceFzHj03VTour8eHselj20AzBgbBxcthqaCQpWoqiD tjD5xVnFKAyg05ZMP3ndzVW3zibJqnv0fzjR1/FQ9BN6K7Jm13XzX4xFaBwPakwT QyP9hpY7kbh95GR9oNWFsIUCPbSHmiDDTvIk/fbdh8KOI1J5+vb1XBqeTQKqNKFU 4wczteMj78g7tan9SsbOMZkIA20INHzKf7ny8gEZ2S/cVg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bxffs25t3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 27 Jan 2026 09:39:25 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2a77040ede0so52101335ad.2 for ; Tue, 27 Jan 2026 01:39:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769506764; x=1770111564; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=lovvu2GU251dCX9r+xMYucJVcTWVctZ/NYUkFjYRq1M=; b=Ju8wnL8ugmM5S8TgTt0IhEh0Bg572TgZotM1R56piYlcCaq8GmtUnegnJS+TcUUK8b HP/7PFCoT6bi7PgpTyg40vyvJWdSlzr5iv3W47glUnhs3pPGE6RgwkpT1IFPhRc8EL2C I0rxkYMUlQIjQpkBREGJe8ysUQvdsdG6RsqNpm48ep/0hacikkuEYnxguZSGdRBhz3YQ p4cGHYaCLIA8+RqoQAWOMWivZko9tY4BAGP1QdiIdHrqhiuPeniFn/D5+59HfAVqPM9p oojKFNKtzfGqQGdgt2sJXixOH08tHcG5K9nKsnPX2IVSA/AwIYchXbBCJdOLMh8oY7i6 b/CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769506764; x=1770111564; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lovvu2GU251dCX9r+xMYucJVcTWVctZ/NYUkFjYRq1M=; b=BIl97jfjOdrhl3/jwwQjmmjfXeevQfWFU4d4oV99hJ1gxx5gz/yx0BzcOvySjxUFGr vAt3Zy7cmCihs++MRRZAJZTZvZqodW24o/0Zo3EM8NJG2B7HVgPx6qGJ4pCxmUii4JEt xQGdcNvrxwOkGqqXFHfFChrQv68dJ1YGGmzIc2zWLWJGR8rGNPWLe4o8vm8RggfQY+RW vr8o54rkb+NYRW3t1y+BTlFYwfhtK0PrxsG81pCp3hFvDI56eo7pe3QZwl+RI3Xy1ujW 3WIK7VZiKCBl1JNFQ0TtPiLXVzstbWhnXUxZKANEYpF/ve81eAQq9dojUiu2w4/F/dhc WWiw== X-Forwarded-Encrypted: i=1; AJvYcCW8iO4wWtwfgcFDfYDEfpsiIf9I0HRSUTLvhE1vbl3G8QwFZl6OtzEjVthj5yHsIg41zhkcmFF1egsQmlQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yyifpd+QLnnUhCG0mLMSehqIcL49FzGi0fszSqigI8TXPQDsK6B UpEUbyjn76T9E0YIFVNI5FM1mYSRiGrNf3gD0BSoz/Y8beHcNW/k9IyT5Igcn10aSl8zNuNaCAM joB2ECDqRtRNr+FaSOFH6JNpsTaM1r2Of/XaI6gzgEAZ+2xV7Sp3kP3qMk+E0F5oRago= X-Gm-Gg: AZuq6aKApcJeTeVLLhgPuTFLj9r1GwJoFu+98EqwIVAw+alxvOD6lGUayv9edyjyR70 kGf2YpBmHHGnnAcffntFWfg+STwDr70Ep9XtiyLcI+GyfCjwXBtvIKKMuiSVw+0EKZ77dj2aKZA 6f/UCNXr8bvBgxFtBSGftvFT4UOBdCvdDKVbP8yaxt2fpacytIedD5kMH1OvlyLM9cJEpUq0UIn u7DzU0NX2bD29a0hVxWO4vf1J6cGaSM/nkJEVRm7LC8AuqWOHi/VLQdWQAsNAlfaX+CujbCvyhB xpTFBnwBFoBCRtiUHtFHwlZXmLb08vo2bK+duaS2y/was2wlm7XucLSJbIh7CAXxobLXDE2nkM/ +cmVe4zzBww5X6cI5exEW/j0AsIMXoR6duLIYGvMzvlf+XdY= X-Received: by 2002:a17:902:ce8c:b0:2a7:d5c0:c661 with SMTP id d9443c01a7336-2a870d4cc31mr11874015ad.15.1769506764238; Tue, 27 Jan 2026 01:39:24 -0800 (PST) X-Received: by 2002:a17:902:ce8c:b0:2a7:d5c0:c661 with SMTP id d9443c01a7336-2a870d4cc31mr11873755ad.15.1769506763710; Tue, 27 Jan 2026 01:39:23 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a802fae223sm112148625ad.77.2026.01.27.01.39.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 01:39:23 -0800 (PST) Date: Tue, 27 Jan 2026 15:09:17 +0530 From: Abhinaba Rakshit To: Konrad Dybcio Cc: Dmitry Baryshkov , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v3 1/3] soc: qcom: ice: Add OPP-based clock scaling support for ICE Message-ID: References: <20260123-enable-ufs-ice-clock-scaling-v3-0-d0d8532abd98@oss.qualcomm.com> <20260123-enable-ufs-ice-clock-scaling-v3-1-d0d8532abd98@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: 3LpaxCsz3sPCn0pykzVYeU-nOzN1J-fk X-Authority-Analysis: v=2.4 cv=YpcChoYX c=1 sm=1 tr=0 ts=697887cd cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=8kCUroivCZrBtzWfW0sA:9 a=CjuIK1q_8ugA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: 3LpaxCsz3sPCn0pykzVYeU-nOzN1J-fk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI3MDA3OCBTYWx0ZWRfX6279kPi//7oo UhQGPBkneZvQIPKmU1K4llcScP82fYeYSuBzerNL0gt+LUJPY+H59h9HgDUdlUEi05fhpW2rFZS NrqOhkG4mvwAon3G09CphVrH9b98RgHXxhvPhc3X16wCXCdGo15NUiE4xCi4BvYHdOXPqrIrQ6c gDHPfaLqQZY2703J5JuHHcG+WVmhpnf2/ePNY/lj+y/2SR9e4ES46IOJjFpEV1ZfWFr2JZBotY7 GC1VNKAOEQ7rHOAMsxamQTJ0FmZPf52f5dwYK8yIh+XubMn2hnm5tb+ed27nJI6tKCn9vhVYRMU rh29j6ziCOAsNzWjJCQs+ci4ySQhkfShoMwoD/S727eiaOB8xnh/BN7q0MhAmsqhgXk68YqyYaE dR4DQqEjtOFw9lPErkmCXybH52vd8/IYQrtnez//QbDOP+Azw5iDv3G8P4LaPgAyH11jWmmSOjo StXGpkvGldUrPAIQQug== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-27_01,2026-01-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 clxscore=1015 phishscore=0 impostorscore=0 suspectscore=0 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601270078 On Mon, Jan 26, 2026 at 11:23:51AM +0100, Konrad Dybcio wrote: > On 1/23/26 8:21 PM, Dmitry Baryshkov wrote: > > On Fri, Jan 23, 2026 at 12:42:12PM +0530, Abhinaba Rakshit wrote: > >> Register optional operation-points-v2 table for ICE device > >> and aquire its minimum and maximum frequency during ICE > >> device probe. > >> > >> Introduce clock scaling API qcom_ice_scale_clk which scale ICE > >> core clock if valid (non-zero) frequencies are obtained from > >> OPP-table. Disable clock scaling if OPP-table is not registered. > >> > >> When an ICE-device specific OPP table is available, use the PM OPP > >> framework to manage frequency scaling and maintain proper power-domain > >> constraints. > >> > >> Signed-off-by: Abhinaba Rakshit > >> --- > > [...] > > >> +int qcom_ice_scale_clk(struct qcom_ice *ice, bool scale_up) > >> +{ > >> + int ret = 0; > >> + > >> + if (!ice->has_opp) > >> + return ret; > >> + > >> + if (scale_up && ice->max_freq) > >> + ret = dev_pm_opp_set_rate(ice->dev, ice->max_freq); > >> + else if (!scale_up && ice->min_freq) > >> + ret = dev_pm_opp_set_rate(ice->dev, ice->min_freq); > > > > Do we expect that there allways will be only two entries in the OPP? > > If so, it should be a part of the bindings. If not, please design the > > API with more flexibility in mind. > > hamoa: > > LOW_SVS: 100 MHz > SVS: 201.5 MHz > NOM: 403 MHz > Understood, will update the patch-series with multiple-frequency clock scaling support.