From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mvsmtppost23.nm.naver.com (mvsmtppost23.nm.naver.com [61.247.196.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCC852BE632 for ; Tue, 27 Jan 2026 09:50:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=61.247.196.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769507457; cv=none; b=rRWlBU/wMYyvD33OpZDVPLd60dvar2ItYO/m1FqpX0ICZOmQSDZGBNr44h+Na50XUHA9MrbAhIwJ9GNU2E6C01RejWwlvxJbl3KsI1nwMjDG14WdTnVs13tGYCBzPfe6Ofmodv32TpZrn7nxyGY14DJjCXXJvfqiriaIPWj7yi4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769507457; c=relaxed/simple; bh=ML+q55qoXSOPTyi44AcgK+slIpN+AUa4DpHF+hZ/ldg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OWLtIeX4YtPUb/F0I0t1uZeCUGhqa1/cXzusjtpGAY7GPIk5rC9VA0FEv6BcMtunnjFtLjomyCKFWVMGOBdkTfs9l/h+YfmCJhfvZRdhogr+KOK4OwdQSWjBu3GOQC9zRfMS+2sjlxoWXlpTaRD78xCoLDuDpqOAbixGZbXdLEo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=naver.com; spf=pass smtp.mailfrom=naver.com; dkim=pass (2048-bit key) header.d=naver.com header.i=@naver.com header.b=kyx1leyk; arc=none smtp.client-ip=61.247.196.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=naver.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=naver.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=naver.com header.i=@naver.com header.b="kyx1leyk" Received: from cvsendbo030.nm ([10.112.20.49]) by mvsmtppost23.nm.naver.com with ESMTP id VxptJ7BcTdaEat959tRfRw for ; Tue, 27 Jan 2026 09:40:46 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=naver.com; s=s20171208; t=1769506846; bh=ML+q55qoXSOPTyi44AcgK+slIpN+AUa4DpHF+hZ/ldg=; h=Date:From:To:Subject:Message-ID:From:Subject:Feedback-ID: X-Works-Security; b=kyx1leykCtQPjxmVG1tx6AXw6UhwsPEOo1AXDxbwI0izVBGWQz3g4EaIF4RJewXt6 70x5Is8rgI8C2cZ3SaU8wJGRAekfZTz3orq5rTp18m+Ni0riNEjlZiCHg6rCAlA2ZG MT0WMP+JbQq/iBt/DsTbtVjqjcz9DwY6Ix0laOdBvUCtgH2rlwi6fscQ2zwN6zMtDn 4VA5muMNAaa6ZnQFKb876FqImF2/SctrX5Xjfovv20oDrMdkVy/nxkd+0X7zWwqH33 7prm9gpU64sYNofGKL/noTCkLdg+qqACcmxkybUmLKgQ6hUNhX35O3pDnaO/ZnpJBw gMVk9BXRnTxYg== X-Session-ID: lD8u+2tZQjam9MPaDL3jOA X-Works-Send-Opt: LdYZjAIYjHmZaAKqKBmmKxbwKqpYkEljxBmwjAg= X-Works-Smtp-Source: VqbXFAvrFqJZ+Hm9FAtd+6E= Received: from JMW-Ubuntu ([14.38.141.199]) by cvnsmtp010.nm.naver.com with ESMTP id lD8u+2tZQjam9MPaDL3jOA for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 27 Jan 2026 09:40:45 -0000 Date: Tue, 27 Jan 2026 18:40:44 +0900 From: Minu Jin To: Lorenzo Stoakes Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, akpm@linux-foundation.org, david@kernel.org, kees@kernel.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] fork: clarify copy_mm() comment for kernel thread Message-ID: References: <20260127055321.2400480-1-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Jan 27, 2026 at 09:25:26AM +0000, Lorenzo Stoakes wrote: > On Tue, Jan 27, 2026 at 02:53:21PM +0900, Minu Jin wrote: > > The existing comment is misleading: > > > > 1. "steal a active VM" suggests this code performs the active_mm > > borrowing, but the actual borrowing happens in context_switch() > > where 'next->active_mm = prev->active_mm' is assigned. > > This code simply returns 0 to skip mm copying for kernel threads. > > Yeah but the comment as it stands implies that you are doing that elsewhere > so I don't think this is a problem. > > Referring to a specific other function in a comment unnecessarily makes > bitrot easier. > > > > > 2. "active VM" is outdated terminology, the kernel uses "active_mm". > > Well VM refers to the virtual address space so it's perfectly fine > terminology. > > > > > Update the comment to accurately describe what this code does. > > I hate to say it but this sort of enumerated list is very AI-like so if you > are sending a patch that is AI-generated please do indicate that this is so > (and put e.g. Co-Developed-by: ) if so. > > > > > Signed-off-by: Minu Jin > > Thanks for the patch but I honestly don't think this is all that > misleading. This original comment is from 2005 and I don't think anybody's > been all that confused by it in the meantime. > > So I don't think we should take this. > > Cheers, Lorenzo > Hi Lorenzo, Thanks for your feedback and historical context. I understand your point about preserving the existing comment. About 'AI-like' formatting: I am not a native English speaker, so I used an AI tool to help structure and refine my English sentences for better clarity. However, the technical analysis and the logic in the patch were entirely my own findings from studying the code. I'll keep your advice in mind regarding 'bitrot' and will focus on more impactful technical issues in the future. Thanks again for the review. Minu Jin.