From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE3B135EDDC for ; Tue, 27 Jan 2026 15:11:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769526693; cv=none; b=RBDWn8r2c+5xplSpBGcKh/fIBuuD8DcvSdEOioJz/i2waFWaTPQk5oQE3jny5+ysISj24IU68yv5Mh8tWSECaw9dwmq7iZq52pf8+Mi9j5wB/59X2YzFlh4fGznIbr8XWnS8tD2Y50o+pYXqeDdtRVDTYwIpaFzD8mLYa+cBwOM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769526693; c=relaxed/simple; bh=Blyg8N4zeGue27HmsSmO/bdRk6JHhRMc1NUiP/XT1BI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aPfphMyiXJpHKtBHdbeo93fo1KCf5Meddv22ziHAw699TzF9DTdsltHWc1vZUZ+cX6Gh2/ezX3+cOTVuDuAHpSYYZrDrrLoHWpCyQNFUaKeXHrP0bDX24mG8jFDEP7aSAq97Nz43hrywtvWCf4Lk5wi82J/MN5EiqyOyVtux4ls= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UaI65I1w; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UaI65I1w" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48069a48629so7759905e9.0 for ; Tue, 27 Jan 2026 07:11:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769526690; x=1770131490; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=ZiYOJIssOgLGJ3sqVKfxdywenJ86qmXkRu/RSeqz5RI=; b=UaI65I1wJEdhdhHNY5g4yd/swGFeeaVU5zSXxy4UlJZkQhQsSJjxT1ryKyL7NYsVUG vzhzUAQHljHgvTBgjeLUp3BUiKXqlHNpWkXyRSU6Qsybs9Cu9pc3mt9Y2OKkkHIIMf0b 9Vz3akvxXe5oV9u2bbccyc+4E84//bs9PPDQu9uOYzVFKhQVTECEtgHF7qTyQP4/iWXn 63vLNVd91YXvWryyJcQ5csQn8DJ4ZQe9XaC4SERr+OIl58PC3QkNDRMlATBlaFxjKGIU oiXOe4MuJXuOKIbw9+ASmIaHmisJk1UGWDL3dSwzmtni8RaskJd5Ts54h1lotns5b+5V n/iw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769526690; x=1770131490; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZiYOJIssOgLGJ3sqVKfxdywenJ86qmXkRu/RSeqz5RI=; b=aB4ShnhaodkADUvefB5Fk7XTHnBzUJlkeKF/fR5nFGZFYEzn1S7U1vJfVy2116KR3I B2HYFd5cKb9KBk1JmeoyBlvI1xfsg0MzjlXmbXCBJ6Ra/1HtdmF+ISh101987s5rGo9t xS9FVdO2WdGF2KjM8rfnr8J29K3kxlOFMI+FVnwxiuQd143+GJAjhXL37EU6pr/PRCLX M1Qlc4dfHDj4r0BMlJGkGcsqq+Ie3kovwBuQ9HLVHM3cw+qLr9/CSXk2NVUO8I7F2gLZ AEFzGXVjhEQDpSDYie0kZjeQ83wDy3SecuI74VCEhbiV23tSrQIhVxElfaTAZX6cA/3D CDIA== X-Forwarded-Encrypted: i=1; AJvYcCU1g1nvhDSILll7FSHBSAIEWynqelLISUTZspbaks6HdxpHc7bgQKXK5aZQo53dQWpTsNeyQRdOf/gCWC0=@vger.kernel.org X-Gm-Message-State: AOJu0Yywg3nQVWvqYkKt0HUMA8IVm71u7Os/l0QIyCd/emcX426Htgab S5RJzuQLna+kCtGzCs//1cV19y23ZACTGOqHpxDQPwttVi6my5N4fOug X-Gm-Gg: AZuq6aLDupnFnZONVd34L0wfnyavp3CTZ0uPvr48SyyCWeeRu/4UTQEaXpc8KXdF8BB Kii1GSG67aMkFiJPxQoTF3JU5QcBHnZkKkpsqmyW9JQeCEFt2PshQHSGse3ebZUNYsJDiA7pw4j 9OcvtPChdrI3DdhJBKfWKKoziwrNdVH+K5Sk/kzSVf8rB75RqV2g0+stUI2TbWcd9rLH+C0gxAn K1QqGttNSR0CiCiK6UdhuOKJl2TzoIWnrn9qoNAMSFS8LW48FsrCLkBxFcLVY/qPHa47mWn7h/W 8thtx0mR0LovdMd409IStnpNbI++XaBS0WjUc5w5itAiZ3m/O1F2OemHL58mWKMLHcy5R72L0VS Etjy8jOP0yDk/wOXhqEQN79Jd8yZhZQjXIiJsZjfHGxrgw8JNK6RsGrckWm47SkbGeXtC1ZCcah 7M7nQlEg+CaKEqfgQrwTDihZ/K4uJtJE7c0u9LWJBYC42TrAKSRsXIYNA= X-Received: by 2002:a05:600c:8211:b0:480:4c45:aff5 with SMTP id 5b1f17b1804b1-48069c755e6mr25187715e9.34.1769526689995; Tue, 27 Jan 2026 07:11:29 -0800 (PST) Received: from anton.local (bba-94-59-215-181.alshamil.net.ae. [94.59.215.181]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48066be7623sm63589915e9.2.2026.01.27.07.11.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Jan 2026 07:11:29 -0800 (PST) Date: Tue, 27 Jan 2026 19:11:24 +0400 From: "Anton D. Stavinskii" To: Mark Brown Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org Subject: Re: [PATCH v4 5/6] ASoC: sophgo: add CV1800B internal DAC codec driver Message-ID: Mail-Followup-To: Mark Brown , Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chen Wang , Inochi Amaoto , Jaroslav Kysela , Takashi Iwai , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , linux-sound@vger.kernel.org, devicetree@vger.kernel.org, sophgo@lists.linux.dev, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20260120-cv1800b-i2s-driver-v4-0-6ef787dc6426@gmail.com> <20260120-cv1800b-i2s-driver-v4-5-6ef787dc6426@gmail.com> <88ef974b-9fa8-490e-ba19-1fb31ca94342@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88ef974b-9fa8-490e-ba19-1fb31ca94342@sirena.org.uk> On Tue, Jan 27, 2026 at 12:49:52PM +0400, Mark Brown wrote: > On Tue, Jan 20, 2026 at 11:06:07PM +0400, Anton D. Stavinskii wrote: > > > help > > This driver provides an ASoC codec DAI for capture and basic > > control of the RXADC registers. > > - > > Say Y or M to build support for the Sophgo CV1800B > > internal analog ADC codec block (RXADC). > > The module will be called cv1800b-sound-adc > > Extra change here. Will fix, thanks. > > > +static int cv1800b_dac_hw_params(struct snd_pcm_substream *substream, > > + struct snd_pcm_hw_params *params, > > + struct snd_soc_dai *dai) > > +{ > > + struct cv1800b_priv *priv = snd_soc_dai_get_drvdata(dai); > > + int ret; > > + unsigned int rate = params_rate(params); > > > + cv1800b_dac_mute(priv, false); > > + /* minimal decimation for 48kHz is 64*/ > > Nothing ever mutes the DAC so this is a bit redundant. The mute should > probably be a mute_stream() operation. I'm not sure here. DAC mute feature was not implemented because I don't know how exactly do that. The public documentation is very weak for my taste. This call added here to be sure that override flag is not set (override feature replaces the output by setting it to constant value and ignoring the input, so it is some kind of mute from my understanding. So ensuring this off is needed be sure that DAC will output our I2S data). What do you think will be better to do here? I'm sure that is needed, but may be better to move it to some early stages, like probe function.