From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BAA4B257821 for ; Wed, 28 Jan 2026 11:55:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769601312; cv=none; b=f7T8HUch3Odw8Qy2qen1ZWaojmhI7IYN+4etveO9Zp+52zjT6SPu03EGnSPotCwwbQap8sMQDt0RXdxX1x6P7saGxHynfnz91CBLyf4zdSSJtPO3xiwm4n7jhYj5CoyclAVKJgNgn3aihgriFeElC1EIqvrLren04jGlzrUtExI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769601312; c=relaxed/simple; bh=PXNg2izECdZqLH5eteW2kxT1B8Pnh6OxK9bdrd2/Ewg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pV8gdvWVjtCA2CB0fLtRVGb+07dek7tE6uC2zff+9JLzI/GHuXPd73NzSSmr9U6FF+9n33mod5PtgBuFujQy1aN+jhXwc1BRevDGKY+yWum3QuEqbuFfeEEbdkKoE+ULFTmU3XprLBMMX+pb7zmv3kzTgxGkUAxGi0lk85f0eB0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=EnQs7Ak8; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="EnQs7Ak8" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43590777e22so4234544f8f.3 for ; Wed, 28 Jan 2026 03:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769601309; x=1770206109; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=NIZARC7cWLedCY7/Et8vUQyK6E+5feyX/hh/mMWrN5g=; b=EnQs7Ak8O4dvsreKmCW0moqzAWEttjnwEBnWPFyD0O/u+DmkQ7wyOd/wRfesFNANme Eiy91Emwk/hoV966NZ1dZuq3HK3ZiqkH3khL+yH/AM1fogj18VgsiKcvpoZWsUugrsds BcY65t19h2z/OmVcQKzEBcQZN6+jZUzB1aMIgI8x8IUVK2i+qmIUF0clTmrmL28urrPR d9bzB2jD3RD069nO+28vs0cNomTXLBicEh4s9Gtp6/hU/vVndxWUchL0qBAkklG4/xIs BTZfnmOARYwKHuL8TMeeGhggGRR1RU8J90D8wczYYF4nfdKSYI3uZ7EBam+AlAS7QkOY RNHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769601309; x=1770206109; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NIZARC7cWLedCY7/Et8vUQyK6E+5feyX/hh/mMWrN5g=; b=d1IpaaaMlMDHXQES8uGF9MQS1bNHQsjncgvggJpmRQQRgWyz7f7RnsSIYA+mtJTsI0 FwqHsSkKkc3GbF85xhb8+VrOnzbZvUzT2OcdobP8ExTos1LDa5XuA/x8kY0PtQdEs98c H99XQfZQRp0S1Y6EHdGjwWfS58IvqBwi0K3t1tjvHoMHPLMnlElZbrSJE1B13MYJoMD1 7MOPdFSmWmUh7Nk2gP9gIOeAqCH667WisdVz4nVECNPHzzRR8+2QXU4q0VOB+toigO9k QJDCpy4Hi1Hn6aAW9ZpRa2/C7aAN17yuWNDay3MgeJo2f0x9RFgIdsWwhTiC0FDfn6Z4 njlg== X-Forwarded-Encrypted: i=1; AJvYcCUt1Yvp7OOwGKZBVC033ZyZFxS/+Rt0g+Amisr4pda26jbY0mpdBls/fgqxAVLrHJhQ/DSeJnYbVDD8Ql0=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8JUbPk6Hvm3ETXveU4gEFUu7vCq8QKS6dhaunP+NA20lP6PXw eILwxppJLDfd9BMNajzXcf4UdotRhR5p2kyHX7bo2JKMqSlkXESxQmNrR9JAGPqVisI= X-Gm-Gg: AZuq6aL2hQJ1O5dg1dSBnuBynTTdRb2d4f410pTvwbxaccjw+fYy7A0KyyIOlB5KXX4 oI1+k4mbn/p6v+7KA2JwulrNfooK1vDZGeatm1FCSLmqraFqbQ7YSlxLB1flSq+QwIe8teQ/y8U U2P9zbQ9Fs4g5cpAYFFJAHaCiDUiN8Ox4xEO7PWVvvxIC50XsKebQaKW1skx1TxcWSFjrPmWjPJ qc1d7K+blAXo49rM2Wyy6QEhhRqa6vjpn2qnzo1uzJU9kylAc00/zfeX/zTxlKbIMrrBbmizdHk euBnXvRrsSiyXC5bTF6Y/Xz/BE2NSkgNaYfTD9xFMOqQLKOokpbKWyglsh/97e2giCjD7wpJObK M6B7Qq3Q3Zhdk5amAPDM+s9Olkf6KVa/WtWGEO/VlMcKvmZmievzGxjnvd4TthP7irnbJcyLhZr IEAc9+MzW/7hg0ll9SNETXFIovfHg= X-Received: by 2002:a5d:5c84:0:b0:42f:bc44:1908 with SMTP id ffacd0b85a97d-435dd0514f8mr6071296f8f.6.1769601308968; Wed, 28 Jan 2026 03:55:08 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10e474csm6545107f8f.2.2026.01.28.03.55.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 03:55:08 -0800 (PST) Date: Wed, 28 Jan 2026 14:55:05 +0300 From: Dan Carpenter To: Madhumitha Sundar Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: sm750fb: replace magic number with jiffies timeout Message-ID: References: <20260127154056.74855-1-madhuananda18@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127154056.74855-1-madhuananda18@gmail.com> On Tue, Jan 27, 2026 at 03:40:56PM +0000, Madhumitha Sundar wrote: > The hardware wait loop in hw_sm750_de_wait used a hardcoded loop > counter (0x10000000), which depends on CPU speed and is unreliable. > > Replace the loop counter with a jiffies-based timeout (1 second) > using time_before(). This ensures consistent delays across architectures. > > Signed-off-by: Madhumitha Sundar > --- This feels like an AI patch? AI patches need to be disclosed. Anyway, we couldn't merge something like this without testing. regards, dan carpenter