From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A7CC3112B2 for ; Wed, 28 Jan 2026 11:19:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599187; cv=none; b=ADs5Q9p1pvI2yk+PSgsdlup62VRDZE5wtQVpfkVlpxV+4WJ1j75mlYZVZuqcrRcz0R6+MXaKKMj24mTJL5s/viJT9FAubBALpFGzrot9kXeN2yXjf3HfpNaatowTmQ8l1Iw/p0+jWGj4jBauJlNKwpXvH6j0G5Lvj6f9obS9yCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769599187; c=relaxed/simple; bh=SBJs5VbM42Boeb9oqQft+UhTPTKk5TFdgYFFVoRflU8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=NYkqZc76BOhkdWfRFJLNB9qJIKyqYE5JQJPpdYVFgWIbQSlFWkLPdABTXpRxD6s71SOhE2aOz9zMCvPja8art//pBhs3K7PYNOfdwdPT0x03bN+6ZaS66Iw0Ma0qvDrZcGRvjl2r/UjQHIGeceFYcyEviJWugwB5inhL9fPMWhA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=CITYm0Zc; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="CITYm0Zc" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4805ef35864so28317975e9.0 for ; Wed, 28 Jan 2026 03:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1769599184; x=1770203984; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sE6tlLY2cerxXtkLllgRGINAxWflpeXsllvs5CeFxl4=; b=CITYm0ZcRKOm/UIdP1L5+BFioXil/tfZmQtBLQb+75hI1PMarl1Be1Vhw+Bh7dIqdG 9tMe3vfbyZ8JZOjEaZXkrP9Djii/8hpXaQHROGp07U2JFBKzUiOz6EKd6mzDWrYnE5/V sVjp4XdhhUsa5eNy5fEdGBxX24bLWHggDW5OCQeVwGO40LEqaJNRv8Ktf+Ft4q0XEffT B415EhM6xWR0wM+UeAAms1zYIAPvYxPgaPGYhIvm6jQ5tAx5MCfoZOGHqAYh8lHFwq7/ dZAq2R2upOLUm1yOgaMXfVaLsWndoY1yrKvyvqIaVEbGgm9jytrp3Z9yFhFHgiueA3a7 EWBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769599184; x=1770203984; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sE6tlLY2cerxXtkLllgRGINAxWflpeXsllvs5CeFxl4=; b=pZi0dxBxFzWZW+sNtjZLzZICbdDOxtZssZnd/eYeFt9k4P8Kmfrq1JgLSynrPndB7U cte5WWoqD1+bUPVIyeH2rbHO18ysn1TrYzAegD25liY4FgkEwd1SU75PGeBdyifi3BkZ ozFBGklDZz3smdMnfO8qOhYMHUVg2pOYs4s3piN4CGL4sp5xULTBwtAH6Te8974kQAz6 PLd18TJ/QRWCVUZMQLKoyLq7m5Tsdp6E9H+MtqYoJuvVYabvSZFLWsCZZJo1yvR5enzo No4Ma3LfyF14JQppv2z1PfnkmFA6mcISuC6HQQ8W5u6Z+92UsxN2wqlnMnPn3pk+XAnu 76sA== X-Forwarded-Encrypted: i=1; AJvYcCWxssKrVVb818LwNFFK77bWWDNMG25eBJMpU5OJdsDIsyw99NgETQkcMSMBvAhmNM3r92q1ZX3Y6BzAg4Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzPAPIqFky5l9h1EKhAPILXWZhmh87g32dxFzhLH/xZEbCpet9W I+PQv3SqKL5kz8ZPLhPH3OQDcsoZ5Ms7k2KP1ExWuUF26niyBPw1pw2UG41KIYUW4pQ= X-Gm-Gg: AZuq6aJydTIKe8FecqPZeQi5+Q4p8TcIm7wj6IBlQx1dkVvwaqKpn+nk8KABtZvINy5 pu76fnQAg6kM5tGsWrMUofR4u96P7yrBdfo9/CCXe6Fy8/G6eiQ2ZxMquRcEdcDeO5BBI4NIa0f y8mtyaA1TRGjvcj0jX1YlalyJOkTi/vzAm6pABiRQoyrbgUmjqvsOJSIBOA5Z2dplqE5rqH0Mt0 BVj+FWrD33Lji++r/kjj5POUh/fj6YzbwBk9h9b30Q7g8ScwKNpAq7RKm4CLVEzjCsr/+S6rGyF fT+ytqqs5pbKld5zlnr7xBTrZSRc4ovJYhEnVpOkQ31CkNc8lOzdcLxonJVGckCCXE+7MlFMNFS D+v5OlvXSBykVsrlQ8/66R4LlZiLiV/p7vtFV18mw5OyokzHcPScq+fBUijpzqONqWFay8dE0dz h0W1PDERaWjW25P771zrkte7O/ X-Received: by 2002:a05:600c:8b63:b0:480:4be7:4f53 with SMTP id 5b1f17b1804b1-48069c5fad8mr72206785e9.31.1769599183682; Wed, 28 Jan 2026 03:19:43 -0800 (PST) Received: from localhost (109-81-26-156.rct.o2.cz. [109.81.26.156]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c515sm55723105e9.11.2026.01.28.03.19.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 03:19:43 -0800 (PST) Date: Wed, 28 Jan 2026 12:19:42 +0100 From: Michal Hocko To: Roman Gushchin Cc: bpf@vger.kernel.org, Alexei Starovoitov , Matt Bobrowski , Shakeel Butt , JP Kobryn , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Suren Baghdasaryan , Johannes Weiner , Andrew Morton Subject: Re: [PATCH bpf-next v3 07/17] mm: introduce BPF OOM struct ops Message-ID: References: <20260127024421.494929-1-roman.gushchin@linux.dev> <20260127024421.494929-8-roman.gushchin@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127024421.494929-8-roman.gushchin@linux.dev> Once additional point I forgot to mention previously On Mon 26-01-26 18:44:10, Roman Gushchin wrote: > @@ -1168,6 +1180,13 @@ bool out_of_memory(struct oom_control *oc) > return true; > } > > + /* > + * Let bpf handle the OOM first. If it was able to free up some memory, > + * bail out. Otherwise fall back to the kernel OOM killer. > + */ > + if (bpf_handle_oom(oc)) > + return true; > + > select_bad_process(oc); > /* Found nothing?!?! */ > if (!oc->chosen) { Should this check for is_sysrq_oom and always use the in kernel OOM handling for Sysrq triggered ooms as a failsafe measure? -- Michal Hocko SUSE Labs