From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1B42299949 for ; Wed, 28 Jan 2026 13:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769605908; cv=none; b=Fq/L1Jwru435J9TsV37fFaB1Wcy4pp6D4ESr0BZkCqZNZbdI7OTZ39v/93kAmOMT2eSnEfaluvXpOg8JAay+DSuSDuUDwcDuN7uTAbDq7ToINCJhrxp1XpU9+u5nHZnQQxfmJRCm7fTf8SGeuOnhV4+nHLLzae9Fob59ceHSDLM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769605908; c=relaxed/simple; bh=/ZwfZB5pbjnZ7qsQn5jWNkYOOsJ6/4wx6bsQi6VowYY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EYEihF++VO5wQ/1j9HfuLJLMUuE6YSCYwPYZSjmLWEsBm9Q1M3AoyZvp+NmyLqp1zs1ERwiCFcSZ3U+vZrUUcfHY3BvlEHB07H9AL+h08PEC764vLy03kKjaAc8uLJLekS2OtkmbQ1VW7YHTSw25JzfnwyCR7mvyzBhbBLF1Ykg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=npCSdOiz; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="npCSdOiz" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4806dffc64cso5848115e9.1 for ; Wed, 28 Jan 2026 05:11:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769605903; x=1770210703; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QE5UXJfkrM2/s+DJa3wmxiaiFjGzF6QP8186WpGj+o0=; b=npCSdOizQ+yr/QLDJkVvcn58/sTgS77CQrCF5NRUrmqUEmNqE8xkZnZo6noSpOIuMG kHjNRTr/bMT3oLwwEUWK1uqsGXUfGkOXgllbQFbVbe4W0Q3w9og1D8O1GQ9Yye7JYEn3 ElT+qR57gOU4eLuU4ITPhr2vbXCtHSHooq7E8ElXITjeG3YufwN4nlx5pO2JXrCoDmkn c7dxw2GZlgM6Otv/w6ZO7TQrn6bi2SrLMaDX1MuUgafue/VaG8pn1BII4cppD1xp1Qeh 8a/t9rUUi3P4hWrJK5YXe1AhO2TlfMCWpiWiXZTq3fSdQ/HvngQvPWiWHCghLqnHJ8Ln Kfxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769605903; x=1770210703; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QE5UXJfkrM2/s+DJa3wmxiaiFjGzF6QP8186WpGj+o0=; b=AQ3Xp0FeCOF/zyJm8sAHVdNtEtKli6vVzO8YcPXcnqDmZ4FKcopP9G4GxZRckcuCj3 ijaB/FMURwPjB8Ag6kwo/Qmv/RSXqpHVRkwQXtM/Zr3lErQgKtkRn7B8tF602YxuM8D3 0qr71YlYw62c7rBf0FrYMycJALvBWgkRNOLlQ+ySlzDkkRQAsuKJDSBmzFBxOGtJAVGg 0VWDBcCMDAyke07YaBI2dRiL0lnmvOS+kaHn9c486eM7tEyJC3j0JSq0Lh/hh4q/V/Uc bhl6TWJ/CC8iBeuDkxyM92p0Jz4BpUxbgKtLZN+L04nPETNFpd2rTlwIKhHzGSCNd9Fn BDjg== X-Forwarded-Encrypted: i=1; AJvYcCWnc3K1GpBmD8/LwwE5gl7CZjCRhp94lHrxCZRGochnKFjA7v+x/t92EhrArcOcu4vUdn6mvxcq8qH44kc=@vger.kernel.org X-Gm-Message-State: AOJu0Yy74O43KdPyBestvIXHZZVMHgNOZyCyy2cNOV62oq+we8vutWMn ygU05oP2VSFyS+Cvez90BCUN5qa0KVYBdUnTrMw6DA1hezQyTAlC2f9vsopwJl5R4TQ= X-Gm-Gg: AZuq6aJuucnCk3GBJRw3bAye7GFHm49CJxv0C1A+ctghiKx9qTyLtfWi6imfumEgaxs BRHB1M2hP79ciO466Y8P2XiIWpuI2qOYXl0s6eZkOkYobpvw4/tNT6LNC1Rz0zKT1jq1XyEZNOX czgSwGmwYY2a9TJLgd0oNScTEWrxuiTNLUIVTsJR1CCj67gQKOJ3FnjGHBlW7yqeavaFh3c5Z6X hIdwn9cI9WDFpBQjjqBVJs5YgjqhIMvWCPthJj9XraAD9Hm94Y/TrYytcfKM2NKiNaeoiXwsTiE W4w/5z9V9AQGhpxv83nQZBpQot1053ATN4JP3bF7iTk9vwmXPBrUbDWOEPBvwhgoPye4NZ7aMV1 0lxqO9tY1NHbRX3pF2NZzK0tQS/9QXELA+dmxJrP1U7suV5sp4K5sm+z3jLShCEQEAwARv0rsfu BqCRPQQeogc2Dbipxb X-Received: by 2002:a05:600c:8b85:b0:480:52fe:58f5 with SMTP id 5b1f17b1804b1-48069c57137mr74819975e9.31.1769605902991; Wed, 28 Jan 2026 05:11:42 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e1322dc7sm6799578f8f.37.2026.01.28.05.11.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 05:11:42 -0800 (PST) Date: Wed, 28 Jan 2026 16:11:38 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: Greg Kroah-Hartman , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/3] staging: rtl8723bs: remove dead RX info reset logic Message-ID: References: <20260127224747.40305-1-ethantidmore06@gmail.com> <20260127224747.40305-2-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127224747.40305-2-ethantidmore06@gmail.com> On Tue, Jan 27, 2026 at 04:47:36PM -0600, Ethan Tidmore wrote: > The function rtw_reset_rx_info() and its associated counters in > struct debug_priv are used to track AMPDU and management frame > statistics that are never read by the driver. > > Remove the unused function, the write-only struct members, and the > now-unused pdbgpriv/psdpriv pointers in rtw_free_assoc_resources() > to clean up the MLME code. > > Signed-off-by: Ethan Tidmore If they're never used, why can we not remove them from the struct definition as well? > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 12 ------------ > 1 file changed, 12 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index f81a29cd6a78..411339ebab7e 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -819,15 +819,6 @@ static void free_scanqueue(struct mlme_priv *pmlmepriv) > spin_unlock_bh(&scan_queue->lock); > } > > -static void rtw_reset_rx_info(struct debug_priv *pdbgpriv) > -{ > - pdbgpriv->dbg_rx_ampdu_drop_count = 0; > - pdbgpriv->dbg_rx_ampdu_forced_indicate_count = 0; > - pdbgpriv->dbg_rx_ampdu_loss_count = 0; > - pdbgpriv->dbg_rx_dup_mgt_frame_drop_count = 0; > - pdbgpriv->dbg_rx_ampdu_window_shift_cnt = 0; > -} > - > static void find_network(struct adapter *adapter) > { > struct wlan_network *pwlan = NULL; > @@ -848,8 +839,6 @@ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_queue) > { > struct mlme_priv *pmlmepriv = &adapter->mlmepriv; > struct wlan_network *tgt_network = &pmlmepriv->cur_network; > - struct dvobj_priv *psdpriv = adapter->dvobj; > - struct debug_priv *pdbgpriv = &psdpriv->drv_dbg; > > if (check_fwstate(pmlmepriv, WIFI_STATION_STATE | WIFI_AP_STATE)) { > struct sta_info *psta; > @@ -874,7 +863,6 @@ void rtw_free_assoc_resources(struct adapter *adapter, int lock_scanned_queue) > if (lock_scanned_queue) > adapter->securitypriv.key_mask = 0; > This blank line should be deleted as well. regards, dan carpenter > - rtw_reset_rx_info(pdbgpriv); > } > > /* rtw_indicate_connect: the caller has to lock pmlmepriv->lock */ > -- > 2.52.0 >