From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4A1C22F60BC for ; Wed, 28 Jan 2026 13:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769606280; cv=none; b=IP1So/20BqEU3VU+gZ9veGzKRuIGNIeijoVEz1/yAoByF+jOZ1OdeoAnBeyx8eLOdmbfDneEHYyjcA17xizUGP2PuLgnRNh4INwIIxqdCavRYATTophpagKfeB0G5BqANIBzFG3Y3abFhA4OGDOF+k07Gk4Hpyv643bTF6she3o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769606280; c=relaxed/simple; bh=sEkOSzcJRBD5qUHPfV+zxyl/snf4dfT8ROQ70Feotj8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=a5Py6qe7VamhVUEWU9fluDpUX5SPgI+gBVjqmpcqxlRLaOQ1rsGXo9/niQ+hFgJ0GxlrnUiAkR/U12xeKHupKS9xwkt5f0xk2831ZSDxEKAhQf0B2t23XwX284Ui7cFYVvQ3/w8Cm2crou6Ij04xpc4reh63vN0w7Bsaf1/iG3o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=s7zKI9xt; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="s7zKI9xt" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-42fbc544b09so5124846f8f.1 for ; Wed, 28 Jan 2026 05:17:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769606278; x=1770211078; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dTzxzPwFK2IaKWTPk4B1x59zfTCDOhd3M9CX4TjpNYA=; b=s7zKI9xtL6PHrB3SKeNImcF2EILfOGUbxU6n9bWZ8xcKQWq+7nlpVgmlFkgg4P3qdF GAoooAcFzicxtfXEICt86IYBInonf9PHfjEPX7FZeF1junIUlDdC/gPoRXeDSfz/8uUY hL6v9GNfrAalDf7fNyKPTMWOZWrdqKW9HmoRKCrq06lD/8zNu7q+ucnmC31PT0+G4Hkh mSkARKJmuqRVtF5W9+cfn8WJgkHNZkcKdfnY7B8MWbaefzLHF716FPUGdB2TBq1lJfNd y5V4K+qD1lp/c4tMhRc78XhbhjhI82SqrfFnH6YmS8mH9mH+Tlz53xCw8bsjlhpMHq+p PT2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769606278; x=1770211078; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dTzxzPwFK2IaKWTPk4B1x59zfTCDOhd3M9CX4TjpNYA=; b=gXpbP1ZQUUVH/J/Pim7KbNRU//msMVE210Ot++/5PxW6LqX6W86/EJts28wLBbAk7o 2BJpTHNUaoSXELAbPf9XFFbcb/BZ87ZdNe2uUxRbE2teldnF+NcyFWEEqUm/A5kfd/0D s1B5Zt4zxIWLrRAi9qd0ANK94GwwsPHnnAbKiz7jxwDQ8dnbKFFtX5Ik92l5fEAGvYmx EwXQlSS1P457r2Xt2E/gWZJ6Ks9PptNo7pvpCFUaMrKN7TSUMLJgkENicV2qhXMhvbMw 9LuTTXtFjafwZ/2YoWHwcpWQV4GvR4w8Aolc1wpJux7/66AbevWup+BLJjJRJh3MoRmU lyQg== X-Forwarded-Encrypted: i=1; AJvYcCXyShtR7a3De/HH7cNaAL6keCM1JGQYaTSdnSaBVPI7h7dRk0LC/qdB/ZNPhK0MACM4aOBHHvx8bF8DrPg=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2te5fljFxpbIjN/ypeZba2o6wASZMU+xfjnGsQeJQZRQxJ0R9 vcrztHbphJ3Uq+kPjd1n5U0OXBhWu9uP6LmoM3OOZKCiTL5wcCb91m43MYr3cBPapGA= X-Gm-Gg: AZuq6aKUpzB+M49u+fvPnVRvX9nHBv6CWb9fLxTEBg13uPKI5AlRdKSV1jF2ueTfIc6 EBqHjKQ8nTQMnRqbvO/2DwIBa4W2hP9zc6IpnD+7Kud2tT6ZO0yZ5HNXppG+NA4V3V2L/hmFIVx zC4dEveXE9cTSsSibumW3fB6OMeqS5Qs49pt4Y++Ft3wm1ZaVhj2lsbR+UdpS3w0uuIR5xBqhyW 4tt3SrV9GasCOp1/NBQgoy/67KiEm0woiiXTADq3Tnf+rDDShFM7CmKNR4KR7ln68xuQiEFGy// AhDX+vBxjCfmG9Zasx0wD9QaKlg56bxD5suWTDkKQkxZjIFPVlfEsNgG9yMf95TZVEyJbftaPb+ UKsRiYjlkWkFvZt2vgXFo0zev3NGVcA1Kk20iITvQHYgqiD0XRYaqfnYMkIvaMGCIdbkd7hJMIQ vD29gehqEKkQNnKrpD X-Received: by 2002:a5d:5c84:0:b0:42f:b581:c69a with SMTP id ffacd0b85a97d-435dd05ba25mr8085646f8f.5.1769606277437; Wed, 28 Jan 2026 05:17:57 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10edfe7sm6750747f8f.14.2026.01.28.05.17.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 05:17:56 -0800 (PST) Date: Wed, 28 Jan 2026 16:17:53 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: Greg Kroah-Hartman , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 3/3] staging: rtl8723bs: remove unused struct debug_priv and all counters Message-ID: References: <20260127224747.40305-1-ethantidmore06@gmail.com> <20260127224747.40305-4-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260127224747.40305-4-ethantidmore06@gmail.com> On Tue, Jan 27, 2026 at 04:47:38PM -0600, Ethan Tidmore wrote: > The struct debug_priv is a collection of diagnostic counters that are > updated throughout the driver's hot paths (RX/TX, MLME, Power Control, > and SDIO) but are never read, exposed via debugfs, or used for logic. > > This cleanup removes: > - The entire struct debug_priv definition and its instance in dvobj_priv. > - All write-only counter increments across the core, hal, and os_dep. > - Unused local pointers (psdpriv, pdbgpriv) that were only serving > the dead diagnostic logic. > - Redundant logic blocks that only existed to update these counters. > > Signed-off-by: Ethan Tidmore So in the end we did remove the struct members, but I expected that to happen in patch 1 and 2, and I spent some time figuring out if there was a reason we didn't remove the struct members. It's hard to know how to break up a patch like this. I guess you divided it up into patches which deleted whole functions and then everything else. Which is fine... But you need to delete the struct members as you go along. regards, dan carpenter