From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBD6632779D; Wed, 28 Jan 2026 15:45:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.78.240 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615137; cv=none; b=Te19Kz8zMdpmagfe5D67nZT3teGKxSz69hyXONs1mq4Xx93EbC89ucGxR9Ln+oeYWp1QxsPjTyIOU/aU2UU1WIcmKhjePRty0OhDsZH/st0MjQVB8tn+3YdMAjJGWtel/Jx9AQfmLj9n0pT5qQFZfMnMOcqXAuWZs1EJfihchVQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769615137; c=relaxed/simple; bh=vaLeiY/w3EowkKOAXKVRcAEtHcJbAWa0f9J/atN+Ex4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=mlFIJmG/YaYk5k/aM6x79hlfHCV5go1nFPgSn39NQCTmRk5t4hNqZn3B0CIqX8WUmb/I2P8NYYGu8TjVL2mRU+eHBFpxXUM3Rzqejdy/VYCuKxfju8jsXKzjc0SKPhd4V1Ea1rx8ZNXcpXB9lnFXOTFNbvH9HJOmDszXXeVgFoo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.78.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1) server-digest SHA384 client-signature ECDSA (secp384r1) client-digest SHA384) (Client CN "*.hostsharing.net", Issuer "GlobalSign GCC R6 AlphaSSL CA 2025" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id B820B20091A5; Wed, 28 Jan 2026 16:45:25 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id A8116351C5; Wed, 28 Jan 2026 16:45:25 +0100 (CET) Date: Wed, 28 Jan 2026 16:45:25 +0100 From: Lukas Wunner To: Atharva Tiwari Cc: Ard Biesheuvel , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , David Airlie , Simona Vetter , Javier Martinez Canillas , Thomas Zimmermann , "Borislav Petkov (AMD)" , Francesco Pompo , Lenny Szubowicz , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 1/2] efi/libstub: enable apple-set-os for all apple devices Message-ID: References: <20260128145855.1071-1-atharvatiwarilinuxdev@gmail.com> <20260128145855.1071-2-atharvatiwarilinuxdev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128145855.1071-2-atharvatiwarilinuxdev@gmail.com> On Wed, Jan 28, 2026 at 02:58:37PM +0000, Atharva Tiwari wrote: > Make apple-set-os run on all macs, as > apple-set-os is needed to use eGPUs and iGPU. As discussed previously, your patch will regress older MacBook Airs which use SPI to access keyboard + trackpad if the set_os protocol is invoked: https://lore.kernel.org/all/ZoJPgSlZJ3ZlU2zL@wunner.de/ The last time this topic came up, I suggested counting the number of GPUs instead of using the DMI quirk. I even provided a patch but nobody with an eGPU bothered to test it, so the thread fizzled out: https://lore.kernel.org/all/Z6paeFrjdv7L3mtv@wunner.de/ Maybe you could give it a spin and verify if it fixes the issue for you? Thanks, Lukas