From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D8B82E764D for ; Thu, 29 Jan 2026 07:18:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769671101; cv=none; b=Ck6A7p8GZYol6E77dLINrDCAgRqnzvU6MiBn8Gga36xLARKxRS/VTeVLTT/wui9hYVt1jVvAghE5UZtDyyNCGUdqaknX1MmalNkOvHRTAjS4HShnZjUIQOAjuXW93eXaRsRdWk+CeWmbnnqlnLuywWmhM7hV89gNb1EwNDW4Bqw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769671101; c=relaxed/simple; bh=gfJOFbS/x4QwpaSLUg7POBdIrx191SkLHhDIcDPqUF0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sAn907JlLwB29QFeqWerg71hySBFcqKRX84OnSHnEO7L/hZW4fQhsuGleVKbhqIlUFnYfUm4mgpDBuKZkCfG0g9qDl11AlRtYIXJSXOI8Sqo26crsvs+tk7vmI4+TW3ZgRCBe93IUHdlxdToXOVXZKNgpFVUAioQQraA597SPTw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ilZGD3Ld; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ilZGD3Ld" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4806fbc6bf3so6399425e9.2 for ; Wed, 28 Jan 2026 23:18:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769671098; x=1770275898; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=j67315wP/PAtOPAFcjYrzFz8uH0iEJBP84MIB/almH4=; b=ilZGD3LdWJK5aPXgARXQSBeKa9/fLwvjnWY/rKuLwVcLrvCSVP+SPH9pgjSDiUNezy oiQc2gB1fvpnrnfWMdU84ICAX02BtTwINw97laf6RUrz093rrdrN9dZWuwZO9gxtgw66 Srcp9O6tnaWoACZNHc3QoCHuh3fZBB2uAJv5jABPF7Q6sNrJBx8UCG1Y67QObKbGfsQY QH1THp49gFYuaEpbeDo+QtkfoEEm3RTvBUIWdEzwK/iTvoe5nlsmNRusrDZQMEie2BAx 82ybYeoKyPzeyifhuJdeg7gVjtoPVMYgoeeJfN7wyyRtPejTRptlQsdbSZY0aRp9aTX1 x+lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769671098; x=1770275898; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j67315wP/PAtOPAFcjYrzFz8uH0iEJBP84MIB/almH4=; b=Nng0OEBviI4u+08iYd/Kmm8hRSOiP5aTKDVSG2dgvDmb0l30w0JGqjC+ga+hJHF9Yq kXSi6BJcdEiSWKxXhlYQbaB8Oae4PKeBUhJWeIQscKpKI5hPH5WpxFpDhWsHELCauOyq 4cNrrKUFch28qTLFsCy0T74UT+2ycVjMwie+nUihZBmXSNvOuedf/fPK2+kGzmpqGoHG KjZ12VHhsE623CcSszAyEsrkarbEzu4sMSnyrnUgb7UCBL5jiKh0098LEgoWrsWwdM80 zu/k0fyasRV6il3eXa8Z3K0WnL5UGubtAK8Y/SRQ+T0MfJNjva2Xvrriyw6UdNDzHcx/ XE/g== X-Forwarded-Encrypted: i=1; AJvYcCWwck0E7IDRsEU48Xsdk4xMFPXCM36QGW2knHIMpELOOVlf8vyr2WFn9xE1UWBgqv4fDr3nzJZbIqU3rHU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywif5d6TQcxppLjv937/Clgc95P1VwTnbAT41ILeZssbemQtmAy p2/yA1H8s47039M1X2Ijo1w5Y591g9RXjqasriKQVrog8tPorv/WrKOvnhBxDQCaE6L6ANixCFV pV2lZ X-Gm-Gg: AZuq6aK6AxYuui0+tsxRG3IendcgWGBZsX4FUqMrfW2TAq7dPlHw8JRQxYygYvOjBFu SPiTz+cgEs6gvSupAJWa6L4ONHi18/z8kEOSEke23zu9jCFrdEpJDCCB+05IwCzlb6LtM51lC/2 LfpD1/in1CTf2mETPSO2YimYkP57mrZxl19GSE94eQRPo0endoPnjibz9tzU+mN+i7Xi3xZQSby L/d6BKu2+uA23vz/7Ag1d1k9D1X6+Z1A+5fWDzRN4/gc0JkVZCTgcjggg6o20FzqeL0lz+PX+RA P0+1PW+lvKJvuKmmiEyJQSEtFnwMGyf6ggHaj2eJV2BnjYIjOLXtbdsugROKKUllcGsfrv4Jqo/ UWCeKB5AejyyVFweMmxs2INdCMnDsZdWt4O6+bJx4ws0AM4xjUnTkho4BPRV/Sz69KCZ2wkVcAQ KiAKqZZhJ64Hzya2C6 X-Received: by 2002:a05:600c:4081:b0:480:4a4f:c363 with SMTP id 5b1f17b1804b1-48069c1b310mr68839175e9.9.1769671098475; Wed, 28 Jan 2026 23:18:18 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10e476dsm12593628f8f.4.2026.01.28.23.18.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 23:18:18 -0800 (PST) Date: Thu, 29 Jan 2026 10:18:14 +0300 From: Dan Carpenter To: Luka Gejak Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] staging: rtl8723bs: modernize hex output and WMM check Message-ID: References: <20260128171635.39879-1-lukagejak5@gmail.com> <20260128171635.39879-2-lukagejak5@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128171635.39879-2-lukagejak5@gmail.com> On Wed, Jan 28, 2026 at 06:16:34PM +0100, Luka Gejak wrote: > Use %*ph for hex dumps to simplify code. > Refactor WMM IE check to use memcmp() and validate length first for safety. > It's great that you are doing this, but these are two unrelated changes. The "Refactor" change is a bugfix and needs a Fixes tag. regards, dan carpenter