From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7FF8F37A485 for ; Thu, 29 Jan 2026 07:27:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.65 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769671655; cv=none; b=ij0GM9iP5+uwG3ZxxfBbFOIStB7wXbYvLem+Uxq0Gh2NHuOiCoD4XWSMJvqjBlHlud7Bz0rwSoWWVdrzeIRRLoPCQlQmZGM30zLS1cg67gEJFEqHD4KYFCVptc483Ty8StWHBPi3+Tlz2/T8iqEwoDaaCNnqaeF1rmLUUz1XAjk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769671655; c=relaxed/simple; bh=DLpm10GOpJRQ3/W2U3PfT5iv/A7ESJkJYY7x6q97wtY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JPg42R37sQJXRwA0qI5LYi00q8bdwX9QzwJTjo6Ewe6A5UxG81iiGpgIQZSsEKlR6NlqqWA30eA0wKbABHAPI932TYqoF3dPjqot6qR8A9l1YWB+VT/ngE1kmyuaklh3ybF6ytYPmIDlgohcSpJSnsWEl4sady6krNNBv/KXct0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Op50PxTf; arc=none smtp.client-ip=209.85.128.65 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Op50PxTf" Received: by mail-wm1-f65.google.com with SMTP id 5b1f17b1804b1-4801c2fae63so4372975e9.2 for ; Wed, 28 Jan 2026 23:27:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769671653; x=1770276453; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xWBMXOY2ETHSDCHnkuYhr/YxNJoa+J8j2avoH6yi24o=; b=Op50PxTfKh78czcZcU2vB6YldYpcXWPpydIoLzkglQWPGXL48YZrrGy+fO9ujRHzpk HNbZM9ymj/yZOuWInQUWfRTY1k185KMoo50t/B/RCI/JcUuaduJM8RCurgJWr/gdomEv i3cSn2hRWydmzrAgZlbiVKirPCLae6fXgIcwd2XFOSPL2z884t0+/TZfdT3HbsVmJxdM cnOUexG5DC8wGjQB3YyjTNyn1lRBAhfOcsulBEnR/nA4KD8Bx1IJj3k8fqa1igxlrlVo iIGPT8JO+GjSWy8uaMx0nfrCHIAUgHYoqNpDb6NLRoAg1kaiOzs5xS4oKnyZuUxat6qV 7qbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769671653; x=1770276453; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xWBMXOY2ETHSDCHnkuYhr/YxNJoa+J8j2avoH6yi24o=; b=etT7NDJoLP+IqqZmqeAB6AOMyOEU+ndhuY+S8r+ikrmkYdGHtgq7UGsjAC4L/jpMam //gQA70V1r4DdQKgEeuC4wLg1YrCKz2dlUpGQpo8KaOCob7lKPOIZUWP7xjWNpXwaP9Q BbEZNrzog39YXAHsSi211P8BnU44mh1HQ29lodb7t5eoVziYkO0MYftygC57W5y0gvfP RBs7Hynyw5GJ/2ZnSE6ooSVEmt4stvbqDxqWAqyi69rC6nYyJqNLSVmi8ZKb2yBjrwGu IGCIvN4hi0W1mawleXAzVPWIsz2ntjsJ3SjTQXr9hlJN6CfHInNS6im/puNRwN4ZRkh3 81vw== X-Forwarded-Encrypted: i=1; AJvYcCWJTDW+0IlEsI7BbtnkJJmCt1P7IxxlCXLby0+Uh/bSplvRCulDJf2Dspwjk/9E0RTUKoZWNarCDfv5Rp8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5cadBCimzwXtmdvPR/yFGKbosPZY6NtkgrcpjUDHTzfYBYdsn mT66E2Kgzu4rRQOrvQUo5xVCypjM1QLcTQMBg8SCpqh4V5Edu+gzx6sCx46As9Ul0WY= X-Gm-Gg: AZuq6aLOtIcltNLt+ZTH/3FrbMXH2BQdt1wUZd56m/qZ38zP5LyH5TdHmDKGsdh8v8K Nzbn0SiPXL95k8s1tSTxh+IY6yHRoq6Uo8iZ5BhvvyO1VAdEDxWNFYE8jTx2zPNx7jaani2NyIN +jA37oDhN99b17yIO66L5kdLwFTsv2zsLpyxpNDZPasf7+sVZrcfm7eA7u3dTMWuh/+jM7gALSM ObFOA6Nbl9UkbE4Kxxu7ZNW1GCV2F2AFTHjkVGzeS62CAP0q2811kL25oZa4WwtgbBsrVjO4Zwm T9Z7OdQ04DumBhq/DWeCWhjivM1E2LsHF0Zjc5PBLO82Dxp0RO6mlLTCpdptUjGN2wYeT4HWuo5 sSu5MM/dWXYsMchGpDKrkqAHsP9ArKZtZLTgiFJnx/dCYt1EbZO3jfoU3R+xWekyijDs6vFYdNq SM+Fn5wIYZYKhrI6ma X-Received: by 2002:a05:600c:3b1a:b0:47e:e2ec:9947 with SMTP id 5b1f17b1804b1-48069c601bcmr89326905e9.33.1769671652681; Wed, 28 Jan 2026 23:27:32 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4806ce4c3d1sm113788745e9.9.2026.01.28.23.27.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jan 2026 23:27:32 -0800 (PST) Date: Thu, 29 Jan 2026 10:27:29 +0300 From: Dan Carpenter To: Omer El Idrissi Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rtl8723bs: replace magic -2 error codes with proper errno Message-ID: References: <20260125221219.26151-1-omer.e.idrissi@gmail.com> <20260128172143.23472-1-omer.e.idrissi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128172143.23472-1-omer.e.idrissi@gmail.com> On Wed, Jan 28, 2026 at 06:21:43PM +0100, Omer El Idrissi wrote: > Changes since v1: > - Removed leftover comment accidentally left in previous version > - No functional changes > > Signed-off-by: Omer El Idrissi No commit message. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ Why is do you change -2 to both -EBUSY and -ENOBUFS? In the original code, the -1 and -2 return meant something custom and they weren't kernel error codes: * Return: *0 Success *-1 Hardware resource(TX FIFO) not ready *-2 Software resource(xmitbuf) not ready Now the documentation makes no sense. regards, dan carpenter