From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 844853246E8 for ; Thu, 29 Jan 2026 20:12:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.193 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769717579; cv=none; b=dX0hjV8AXRQNj1QQkgUSWsxysfWO6bBK5LDSkrtIxAG3cFsNq6z7NNv9UohukC6qVRA9p///p7bmlVrk4/NvbMp6hnP/Y8FKZ5xPliiZ2juUag79earrWqMWY8CxLnP4vPL/6wIig9KgqSVeyUt6a/XEJ/ZdmnXUrMlRQr4v17c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769717579; c=relaxed/simple; bh=iWJxqh9v+b7ONeSHcsSKUAXb/55OwGTO4VzDIK6UzCM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iFfqdwrOViOwVD1cegcZund9BG2xQJhv7zMRSdVKZWrgMIcu017W7Nxh39mSFqSOOkzi9YUjnXACHAPnwknq9zlBNi5W7+lQi5Qk1rXXeYypJgq4lifwiu5ylE5s3ynwJkG9S8btBUROtMrtvROPZ+GfqAaGLau2rfjOrvQqpLQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to; spf=none smtp.mailfrom=dama.to; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b=JHpizm0C; arc=none smtp.client-ip=209.85.210.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dama.to Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=dama.to Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dama-to.20230601.gappssmtp.com header.i=@dama-to.20230601.gappssmtp.com header.b="JHpizm0C" Received: by mail-pf1-f193.google.com with SMTP id d2e1a72fcca58-81dbc0a99d2so706805b3a.1 for ; Thu, 29 Jan 2026 12:12:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dama-to.20230601.gappssmtp.com; s=20230601; t=1769717578; x=1770322378; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=KpFVsPfnfQQNTQ0jdwFqwKURwQ4mgZxUyhFY2LzG0D4=; b=JHpizm0CmdpGiLFtoxT1597fZ4Erw2oViB20mK+MtVpedHnMobrxslA26x3OOuReOi QELrIDksppgge9w9Kr+l0+pd2k5tLvilNe4Dbd29u2WxGl/Rj6LOuu+Tz82/DpBD2RQw g9qz97uj2y7VZkFU6D7ZODz6FTa/WNSZ840UcdbPyC83ZOikgxKkKvhsoEjWrTQD2+4H dNk3yTLF63OLTbKU+/ssYxzqleaJVlhBzhfTyP3ulQWiqhTE8r/+i3oJ0fP8puFkKUJ3 ilEz1zHYu6RL5tg8qwWdzlCwcgnlvF5io5A+SwVBSzok7xyuuMNJhQ8S9X6wZHsB7SQx EpbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769717578; x=1770322378; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KpFVsPfnfQQNTQ0jdwFqwKURwQ4mgZxUyhFY2LzG0D4=; b=Tfpl39FUHnLvaLGJrBgj7VsiosDpyOkUkUAdYH+KoPcG6nsJP+mJcSK1GjhfbL6vu9 +vcZdtkIYwMwpwVCVJ2G0cDKGdARDRz5E7rayaNdF44K/FtaGqsj1jmOI/haRfABWno2 7ktmXDAw9Bhw4LnliBJ7wI4Do03+kTftROG/D1Myb0efbj9USr2ecjSkKmLznmwSrTO4 BGrzsQCi/tiB9DY71GqsdFLcTxnKBtH3LR4mLmV5c+Bpmlv/FD+XtBup5TzyZPrAMkcK 9RENhMyOzSrWCQrCpNazN7fPDo9YBagr8qT3WS1UAs688nt2XByefsSGm4htnn9Plkdv j2Bw== X-Forwarded-Encrypted: i=1; AJvYcCWdFuyC+elqxPwsaFksslMoDM2bxETl2Hejm1ETA4al70re989IpGS1g2ym69st5bTpf7nGrIt05tunbpQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwN1/AD13aNTJbOKbBGFDJxlqiQN62/OiHu3AXr1T575yMsgUoh jhGSoMEy/TIeA5DdOcZx03C1LSsqk4E1LpM0STwx0HzYK8AE+FBmNPS/a74HMq+upUM= X-Gm-Gg: AZuq6aKi/j9A1G6NFImGiWd8Vn2NYNI3kmo/xcfeUatT0YqvAmSbDAFewLkWDPaYtvr mrTnNduAz0IoeggNmF8965erRL3u4ffUL956B4REytU5HFj2xVudDuLX09S/LExXxj82Z2+GHu9 YCVVgV7WJMwtbRXFtpVgDSOjRiZ3TWoDk74ZanvW86OrNBF4iZa+FlMIBSB+uBxtFSodE/7kOyR 4XOX1hd+PwisrwJM+i6kI+MiP8TqCESa1X4n2yBOC2hlOs1zopC+MHbIf33KD1e/d6iOGHOFusd ebeClxAbMYeAiD6qI84DXHOLOYHqMYu+qEsVybvgv5m28RFKkPGo/eBVfaSFjfPWPhrqIw8DexR UDpaEuC85Z8P5yeNpJg/XHPV9ZQmak/KvaBva57oXsfmQxnyat3ez9NRn1iEZ9YZRhVU= X-Received: by 2002:a05:6a21:a42:b0:366:14af:9bbd with SMTP id adf61e73a8af0-392e01a8f7cmr203112637.71.1769717577697; Thu, 29 Jan 2026 12:12:57 -0800 (PST) Received: from localhost ([2a03:2880:2ff:5::]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c642aaecd19sm5852908a12.29.2026.01.29.12.12.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 12:12:57 -0800 (PST) Date: Thu, 29 Jan 2026 12:12:56 -0800 From: Joe Damato To: Fan Gong Cc: Zhu Yikai , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Luo Yang Subject: Re: [PATCH net-next v03 1/4] hinic3: Fix code Style(remove empty lines between error handling) Message-ID: Mail-Followup-To: Joe Damato , Fan Gong , Zhu Yikai , netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Andrew Lunn , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, luosifu , Xin Guo , Zhou Shuai , Wu Like , Shi Jing , Luo Yang References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Jan 29, 2026 at 12:01:08PM +0800, Fan Gong wrote: > According to previous review comment, fix code style of removing empty Hm, I'm wondering if maybe the subject or commit message could be reworded a little bit? Maybe something simpler like: Subject: [PATCH net-next v3 1/4] hinic3: Remove empty lines Make error handling paths more idiomatic by removing empty lines. Link: https://lore.kernel.org/netdev/20250902180937.4c8d9eb3@kernel.org/ Co-developed-by: ... Signed-off-by: ... Maybe Simon has a better suggestion.