From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E92D1D27E for ; Fri, 30 Jan 2026 00:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769732714; cv=none; b=bWx4QnNlmPFZJDjKIJaHhxQtKMWWhVPveg4rP8m2ibsVML8tTGMG3+4De7OEQPuRgt9uncoLTz2ZEqHnRaoJIoMTZBpDJODoPL952sYK2X+OpfIOHkwoU3yOaY0esLDUrSFe7nb/w+5Xzceo8X8Wt5d121vCFBfhVnAALPeDENg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769732714; c=relaxed/simple; bh=xBWSQE6sS6/JgPpLm+D+fhzj2dQKmuxIS8s6r/p0dqA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=obH4Cg07+3lvdhUgwqfAZ6et1z+BUJ24coauWsv8xLXJhFelUw/845D7wcQ7Ah/tH99a8R+/n02zSPeZQgerG02dtnjhB+irGVHkIeXL7OHTQ1tkF6eFJrk3QMyDDqzJ3x3aFwF1ECthL6M1sqc7FhCSJHZZsJoTsEjGjtchheE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eL8JL5G3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cpc5vihm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eL8JL5G3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cpc5vihm" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60THiMXA3900747 for ; Fri, 30 Jan 2026 00:25:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=k+/DODfwQ3KtQ+bDGIO6pAc6 mEXPzErqPHRnqZcsRF8=; b=eL8JL5G3c7YUP5QcxBjslM0Woz5/zMP/OM3M70x1 Yr4BjlucrIgAh0/blPkZverhDpZpB5gr9L/d8hvJOW2Fi/oDCKZuDyQzXw65rfNk k+zZqf0wNpG0/hy/tncu+NIUy9CxrRJFTpqGpSRroqdqT/AUibPEjgmJ0WSWlYL3 ZTUZW9qiH2pu6DHpBoLdTlRopzl2IXdagdyFDrftMx9gIsVHw+NiANpOEzbBcdoi /wR1x9eyQNRu6TRS3do6cyCyiZI5N+KHG02L2sR2mCzZvH+LsXtke7YIq1Nyydvi Es8n3tPy3gY/sucVauUhHEuyUQYki1bWiS99DGiY57RDUQ== Received: from mail-dy1-f199.google.com (mail-dy1-f199.google.com [74.125.82.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c05seahqn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 30 Jan 2026 00:25:12 +0000 (GMT) Received: by mail-dy1-f199.google.com with SMTP id 5a478bee46e88-2b722bc1be1so8275840eec.0 for ; Thu, 29 Jan 2026 16:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769732711; x=1770337511; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=k+/DODfwQ3KtQ+bDGIO6pAc6mEXPzErqPHRnqZcsRF8=; b=cpc5vihmns8OTB21Z+x6BY4sGMbGfD3ju3Nm8OMSOeN3PkvVr13Yi2Nr1kOEj05vx2 WNWHMpn2VnPM+Ac1MAVceNppGyJxrEXK8/IrvpZd2wVnEWlAgXxo1EttfnqnS1+rQzBn m6FbMz6YshNqew1TrSyhKI7xJvNIZ3u3ndecDBB7x9FmwLTzzuuJ9sMldShejWrxovqC cZowigU+r0Ub0mNcuoRyZPnaMqTXWDykKAhzhX0zV4bOQJWmfTx7/nCjMGccS3cQDYTj 7RIab5WNqGUVJ8k028b+fgUVZxmcks7er2zfN9cxpQuYDnVobT040Aj5Lfy0xCsudBIZ m8eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769732711; x=1770337511; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k+/DODfwQ3KtQ+bDGIO6pAc6mEXPzErqPHRnqZcsRF8=; b=mdygq0hif/dOYEA6f4Nn6srnwVIHZXCSmhsYEmHnfcjVmEeZnxUpTct/Zvkb5dhbtr DuvU3f7E3UtlTA3+XWOy2l7wyo2LAGIubQNCq+kwhrCTmaOkTZbAghkCIEvsHjFcPp5x 5kQb8VYruw4hGWhI8DsZMPF67JrcA8UO4QWrv1/TLb/MTVa+vc4DfWVNl2YqQFvbb+Ec 6pVUrdnQRpxjESv47opdwi7zJIkCPrtLCi1tJ0ggqoFWpbB/vWJ0zZbFOa7CD36e3RBP 55hZwHShhusIRXFIJZ9vJyRKeVl0/dm52dWcFzKIJaPqjt8+/EmiQLT7HnFJEcfADgk8 ihPw== X-Forwarded-Encrypted: i=1; AJvYcCUGWmWPOnbLe5Vpxce2HV1+rzhguTJbrWkLDJXUIegYAQCXHH7xZyN5CjU5Gi4DUxCZL88Tu+LqC3usHQY=@vger.kernel.org X-Gm-Message-State: AOJu0YzOFbWsrAbs0WRuk6ntI5WgYE3Xi1QvldNQBeflYp+HkHO7Uk8V EWkd5UX4f/u8QAk5DEWSY3y4x23rdha8tWkNSXz97T454GT51uNPG8X8HCp+hBt9ONgYf9kSaeT iFASSfyLMQYFSWxnXmdclpGNEY2lX7hc1IpdVs4U/v2Ngwsx/WaqwhhlEquA+LCPrf7U= X-Gm-Gg: AZuq6aJdsLC6rwQ9x0ozHGtX2P0+i1r6N6aPGO6Xg+8P8V79DCbEYnNqYjVx76saViX xj6MfweVf/w1asmX5TKUzqrXI4y2DnNFRhgN1ihECNv34IvO9RLIt65FAhZeqoHbuOxE8N96EYx 0a8R9KuFvWRQQOHK9JmN4ox2VEhg/gV8DTNg3OX/gpJ6b5R6kK+NPdf94yuSdUTpW+b1oDdS5pJ l7nhV9eyfoYraxvdi0uW2tV0idwFGzdg8dRWRB0AW9dn28XupwWsFkGOLtuegX8+k/Cm1dDMCQD dak1Eo161e9sXY6V5Ch5rDZqsvb50XRshkNRZcIe9k2FQ4Pl9B3Whh/FlB64uXS/MR4X1eYKhf6 Bt4KwyQEaL7D6NUPUJiAAGYZ3gJPvlR6A1a+qSOrIIjeCy67BhFdszJX1VAJCbZ0= X-Received: by 2002:a05:693c:2b10:b0:2a4:61d1:f451 with SMTP id 5a478bee46e88-2b7c86644d6mr554730eec.16.1769732711480; Thu, 29 Jan 2026 16:25:11 -0800 (PST) X-Received: by 2002:a05:693c:2b10:b0:2a4:61d1:f451 with SMTP id 5a478bee46e88-2b7c86644d6mr554718eec.16.1769732710951; Thu, 29 Jan 2026 16:25:10 -0800 (PST) Received: from hu-clew-lv.qualcomm.com (Global_NAT1.qualcomm.com. [129.46.96.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b7a1abe714sm8997951eec.20.2026.01.29.16.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 16:25:10 -0800 (PST) Date: Thu, 29 Jan 2026 16:25:08 -0800 From: Chris Lew To: Vishnu Santhosh Cc: Bjorn Andersson , Mathieu Poirier , deepak.singh@oss.qualcomm.com, chris.lew@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Sudeepgoud Patil Subject: Re: [PATCH] rpmsg: glink: Replace strcpy() with strscpy() Message-ID: References: <20251211-rpmsg-glink-strcpy-replace-v1-1-be06308e5724@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251211-rpmsg-glink-strcpy-replace-v1-1-be06308e5724@oss.qualcomm.com> X-Proofpoint-ORIG-GUID: KI2MgunddzFjedgC92e_4oZc7oMMcD3o X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTMwMDAwMSBTYWx0ZWRfX/yWZqsW9dtr3 aeJhijr9c46kmIJRyQBQsgesioRxlIP22ZmQoSvknaQYBjiKVHRiqrD3CbYSKMPbZ8FQXcxekzw SSdLkQDvoVurhxhXI4vsY6eqzEkBsVL2CvqpuTcGyxDFUb2BdE2WdEc2Jqp5IPtKnYiVKezM7WL DvWsCwHEBvwbfCjivK+3zeCyOEFLErzZsp5rVOWb6ktxQLe7pIdvcCvmgynY5lXhodkKqPXDuDB UsKp+XblaL+RKk1MA+8HoNAEe57gpxWT3+QtWq4TbIqGnTr3rTOQZ5fNO75dexT9YGE6HvFQGAs cEJaNgT6Y0eWiz/r8A1RBoeGzVsho2G9Q9wImCVzmiLE/9rVaJq8XoC6EezltlaLleULyzxy1i1 TDt39RvzuQkR6Rqj1tu7AUV5cNo4GJHY8SzbK4IO9vTDmbV6PKyqsgM+qtBLNrqVeA3VxfnHNqU nEaJxybSCjG7V8OnwhA== X-Authority-Analysis: v=2.4 cv=RIu+3oi+ c=1 sm=1 tr=0 ts=697bfa68 cx=c_pps a=cFYjgdjTJScbgFmBucgdfQ==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17 a=kj9zAlcOel0A:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=PWxM77GI9PN3WSnVtP4A:9 a=CjuIK1q_8ugA:10 a=1F1461vogZIA:10 a=5kKzt1m56AEA:10 a=scEy_gLbYbu1JhEsrz4S:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-GUID: KI2MgunddzFjedgC92e_4oZc7oMMcD3o X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_03,2026-01-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 clxscore=1015 adultscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601300001 On Thu, Dec 11, 2025 at 02:18:34PM +0530, Vishnu Santhosh wrote: > From: Sudeepgoud Patil > > Replace strcpy() with the safer strscpy() to address unsafe API > usage warnings[1] from static analysis tools, as strcpy() performs > no bounds checking on the destination buffer. > > [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strcpy > > Signed-off-by: Sudeepgoud Patil > Signed-off-by: Vishnu Santhosh > --- > drivers/rpmsg/qcom_glink_native.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Chris Lew > diff --git a/drivers/rpmsg/qcom_glink_native.c b/drivers/rpmsg/qcom_glink_native.c > index 5ea096acc8581b1aff106f4c0e2f9aee9d56e25b..37b2255495d53270521466a05a5eb97eca98ec0e 100644 > --- a/drivers/rpmsg/qcom_glink_native.c > +++ b/drivers/rpmsg/qcom_glink_native.c > @@ -501,7 +501,7 @@ static int qcom_glink_send_open_req(struct qcom_glink *glink, > req->cmd = cpu_to_le16(GLINK_CMD_OPEN); > req->param1 = cpu_to_le16(channel->lcid); > req->param2 = cpu_to_le32(name_len); > - strcpy(req->data, channel->name); > + strscpy(req->data, channel->name, GLINK_NAME_SIZE); > > trace_qcom_glink_cmd_open_tx(glink->label, channel->name, > channel->lcid, channel->rcid); > > --- > base-commit: d358e5254674b70f34c847715ca509e46eb81e6f > change-id: 20251203-rpmsg-glink-strcpy-replace-738ab624071f > > Best regards, > -- > Vishnu Santhosh >