From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F5EA2E2299 for ; Fri, 30 Jan 2026 06:24:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769754270; cv=none; b=VQcUF1OJhihGErKfHIX4wYHFgvlMogG0COd3kHPgw6Y4IwxvSJJKep6ZzmqeyO6D/92HwWDdcQg6IpDOdN18iWkln4PyWvCNLBXl0xdFxyOLl2KQmi1VvPDolE069j+x/jyDfRjEHmje/ZKXuK6zY2U/GrVHrBLWN/SbdGFvkv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769754270; c=relaxed/simple; bh=JZq+RWSitCfzgZ2CiHKnrG856Oec619NyOwWzCipbs4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=gM99QCtuW4qcWbRUzmRJdN1+T2Iy+IFgY25EnSBjvLzEmkz3KJxgZlamVKM0VAaak4ITbyc/fmZT5gHxIHdtw78atggaETJGvfA0j0YiqYSoTrHxvxVhbMO5+oEmSwKrUPCEMy0Hh9DOxSRHfTlpD67b62qrA5XjEbfEQrL+RU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hjCNgcoi; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hjCNgcoi" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2a77c1d5c3bso7991385ad.0 for ; Thu, 29 Jan 2026 22:24:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769754267; x=1770359067; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZzOSDsADlZZalIjYI/NFZliyZ4zh625PTCb6VAu9b7I=; b=hjCNgcoiJ4j3Rtq/51yJ+mq8nZPgklCdyX7zQWfvhpdJLdVMhhD2QwprjpcHI6xX1D HoakEmjr0o7nLQhzJPo1kE6UGGyig/C/lKPYhexgzQokEa/CO+4aiTpE0Jh5tjgtz+nR Ol6QGJn/9ttmx45iLUpd12Lsr0h7Vh9RC54ZFpQf739Dwtj+iHVKC82xsbgOhefkdSAw WLicoDrSD8MB/8sn9XiujK3J77RrB0mwXkhrg6kRpiunevgDrhZyg3JkBj3KEw3pTJvX HE384U5YCmD21zywTYBUdqvpImLQGcBKTZs7JbL72dVMCpQIza7rWuVchHC0mu+LW+6M twFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769754267; x=1770359067; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZzOSDsADlZZalIjYI/NFZliyZ4zh625PTCb6VAu9b7I=; b=aiKiI7bdH5cltrhs0Npg3RdKd4k1D91VmWJWDB9r2nWpBKtnEbqpctQRKUFNr8ZIV8 +cTzEEGzrRnUIMOAvBdPV/rQKKpcGWAXGlBIxdSLF3+VLRFnRKPCfkVNOlN5rB+6amYn 8z4Jt8qnOej7esr+HFJTM4yOXlkPsOLX1Ngu5sWBXLLkmqLHdnwAqtec41fo+IZ3eYeJ rntPj2TaLd1ZHEOx1DZG6cXTzW8FTwmFIth+ZTAuBKJv2cH44ZDTEdW6EB4+X61Ipknl nwyHaSoYXb4KG4qQny5D5h7U6g405I6f4nNw+GjmcBMMS2uBkqiUls4/xMW8bO+FlRTQ Y1NA== X-Forwarded-Encrypted: i=1; AJvYcCWJBaxZgLCkvRafubjdxyrgIDtmUbAz1VIQW3cEOPoYUY+FPUD6xh5VL/prkVFrVhHApPtImpro87S4OHc=@vger.kernel.org X-Gm-Message-State: AOJu0Yzzlypx9M0yvYIxtJFXuyZjxKKnclGXWgBFlq002fP1BDwpCNZs 0uXesF2Rkp4xrEtCEyRxwK57cbH0EQs+EvpX2/A35thdmy+cC/Ut7eqd X-Gm-Gg: AZuq6aIX9Mc0chxK86jcB5lTuj5JS8RC/GMnQKx/RQ89Q9/YvzkCGulyeHmfCtIKHLg DBAd9wY2/ra+sLbmq9YfQLC1XeZXdBlGg99jHcm68W5+ouHtrZTOEmFlMpRNyszWTsm3V7QVNVz he5gj5Ex3185X+oELdBuKQIk3wVRjX+NZXmb8h2WITwov27Duz9vW7KHAdggRPzylxqIJ8LGggn YB373X+cEekcpJkQvDy9wNc9Avpc3mhks2DZ7ipNrYEeKqrukSoq+57+8hoX6pLYHFekGoB4v2O wce881JSmmvuibH/KigCCewd/uAcTwbk/eo8MpXx56fXCtx9z+VruVDezQiHnN2VDLXImbZInn3 pICWLqbKtf2yEZJMa++Umda+9DKtvp7p0+s761OKSfBUg1fLyNBOw4d+XRuCBI+eedLz6oTzptD w3wHY0MiAM3yVsB50qmkpMQGu+qYU= X-Received: by 2002:a17:903:15c7:b0:2a0:b461:c883 with SMTP id d9443c01a7336-2a8d993031bmr18059985ad.45.1769754267392; Thu, 29 Jan 2026 22:24:27 -0800 (PST) Received: from chandna.localdomain ([106.222.232.101]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b7f32bfsm69740915ad.96.2026.01.29.22.24.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Jan 2026 22:24:26 -0800 (PST) Date: Fri, 30 Jan 2026 11:54:05 +0530 From: Sahil Chandna To: syzbot Cc: bentiss@kernel.org, jikos@kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] [input?] [usb?] WARNING in asus_remove Message-ID: References: <697baa8f.a70a0220.9914.001f.GAE@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <697baa8f.a70a0220.9914.001f.GAE@google.com> #syz test --- a/drivers/hid/hid-asus.c +++ b/drivers/hid/hid-asus.c @@ -960,8 +960,8 @@ static int asus_input_configured(struct hid_device *hdev, struct hid_input *hi) } if (drvdata->quirks & QUIRK_HID_FN_LOCK) { - drvdata->fn_lock = true; INIT_WORK(&drvdata->fn_lock_sync_work, asus_sync_fn_lock); + drvdata->fn_lock = true; asus_kbd_set_fn_lock(hdev, true); } @@ -1343,7 +1343,7 @@ static void asus_remove(struct hid_device *hdev) cancel_work_sync(&drvdata->kbd_backlight->work); } - if (drvdata->quirks & QUIRK_HID_FN_LOCK) + if ((drvdata->quirks & QUIRK_HID_FN_LOCK) && drvdata->fn_lock) cancel_work_sync(&drvdata->fn_lock_sync_work); hid_hw_stop(hdev); --