From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A09E22D9EC2; Fri, 30 Jan 2026 09:52:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769766742; cv=none; b=b8k43fH4mfhyFXIxAmItaeAEhhBS1suvoHBbnhn1FKoalrECxW3MWhdmf55AQyC/GtBgUEXo/3P8tJ5EL2kUfH+I4KLgMb0/OP5RVgn6jhEgnweCoZdDbd1Ax13bdePSHV5vO74QptlGTsXDbwN5TQT50wnzU+ZsPctcgtc4NM0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769766742; c=relaxed/simple; bh=wvHeKQFimn/BDIsBmfAIthkdHvqv4dzGB9E2A0rGal4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=CnWDqNxY+zN0PYyHIiGi4I5IMfTFFwUtUtAOrfm3EGr2JDquvzNDNDipIOZBTQiY2Y0QS8GWrMjqqsBgtEd48WNVWVi2KPdZTAMQJvVZSfg9PCUYTSBmrzHUsp4uTExe08uo1XC6xmpOAQ0z7EIpraQSa10kD3+T4n6qxcckM5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gp/AG6+e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gp/AG6+e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 710ECC4CEF7; Fri, 30 Jan 2026 09:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769766742; bh=wvHeKQFimn/BDIsBmfAIthkdHvqv4dzGB9E2A0rGal4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gp/AG6+ernD9j2Jussl1JiURaJm/wAgEhdwha562qZx6wdvR1gOeGlmY29T9RA+Zz CO5wkDnQKRN0gCMyRZmyJzJl2ThxCfGx20eOcNM95G2RKGEYnsiXBISDZGe8Y5dWf9 VEMSGKa7j+qjTi6mcJ6isfVbfGKrDjW/gTwBBqDLot3r++ReeyuxiFa74RvdYrMG0O Ba+DGIal71qdTWRwTqL0bydGCnGZMwpCrcMLqkHGEQfqKbT7QFs6qYregmdQ97HVz1 NyPHi7nCOQdFrcNxobkuv8F+oYIlmeeF5x2UlYxdj2jt8FDZ3hKOKJdKOHxl6w/CGc JkXDtOTsVRH6A== Date: Fri, 30 Jan 2026 15:22:16 +0530 From: Sumit Garg To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, abelvesa@kernel.org, mani@kernel.org, linux-kernel@vger.kernel.org, Sumit Garg Subject: Re: [PATCH] soc: qcom: ice: Avoid probe deferring for un-supported ICE feature Message-ID: References: <20260130091118.147379-1-sumit.garg@kernel.org> <4ad700f3-da8f-4175-9172-3fc4d87d8152@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ad700f3-da8f-4175-9172-3fc4d87d8152@oss.qualcomm.com> On Fri, Jan 30, 2026 at 10:34:26AM +0100, Konrad Dybcio wrote: > On 1/30/26 10:11 AM, Sumit Garg wrote: > > From: Sumit Garg > > > > ICE related SCM calls may not be supported in every TZ environment like > > OP-TEE or a no-TZ environment too. So let's try to avoid probe deferring > > when it's known that ICE feature isn't supported. > > > > This problem only came to notice after the inline encryption drivers were > > enabled in the arm64 defconfig by: commit 5f37788adedd ("arm64: defconfig: > > Enable SCSI UFS Crypto and Block Inline encryption drivers"). > > > > Fixes: 2afbf43a4aec ("soc: qcom: Make the Qualcomm UFS/SDCC ICE a dedicated driver") > > Signed-off-by: Sumit Garg > > --- > > drivers/soc/qcom/ice.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c > > index b203bc685cad..ab9586b8caf5 100644 > > --- a/drivers/soc/qcom/ice.c > > +++ b/drivers/soc/qcom/ice.c > > @@ -652,7 +652,7 @@ static struct qcom_ice *of_qcom_ice_get(struct device *dev) > > dev_err(dev, "Cannot get ice instance from %s\n", > > dev_name(&pdev->dev)); > > platform_device_put(pdev); > > - return ERR_PTR(-EPROBE_DEFER); > > + return NULL; > > Wouldn't this wreck the "actually need to defer" case, i.e. > > > qcom,ufs probes first > calls devm_of_qcom_ice_get() > "ice" reg is missing, non-legacy case > qcom,ice is absent (not yet probed) > return NULL > > ... > > qcom,ice probes > > ? Since qcom,ufs depends on qcom,ice via a phandle, so isn't the probe orderering automatically taken care off? Or that isn't the case here? -Sumit