From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F6DF301704 for ; Fri, 30 Jan 2026 08:58:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769763492; cv=none; b=DcuGWovXpdkeCKWTard3ih6B/82x3z4DXCQ7uNsf8wTQ++FDUGXtSIVe2z7lip8b2EyDf2KMxKIt09GGArGVUAa6TIAYDM6Wu6g9ZbbQarGWTnRGN8S/mVnGQdwH6A4DkmACzzZ17C0gZGztfV7Wn8rgDwixn0LJyUdKNb7Fs2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769763492; c=relaxed/simple; bh=WhW/zL/v333Pm7WSuFaDJwlZ6ddMQjL55UX0uJnq3PY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KHAZjwJrWQ7PKBhPor85Lsf4ibg9WSpBiC7bnd5HNz9M5bvAIjMiN5GbHkDl5xpyrorozztML7kSfU1TroxPZGCjPsnCWgT+aypZehmJfYieQhxrB1DffkT1ymMY7of5o+cHXKzRgZPhMjnT0thEz+VLxWL3DRpP0s4Js9JdIhM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=eidTYl1s; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eidTYl1s" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-432755545fcso1306391f8f.1 for ; Fri, 30 Jan 2026 00:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1769763490; x=1770368290; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Cfk+So9j7LmEglWj0SSY3ONnLjxUj5/C63f6qCN1qV4=; b=eidTYl1sj7F/BoONIWeKN0a0FNg3RFptznMb8W5hueXRAjaiI9XF8Lzn3Ayf/mBOQ3 jhezXTm9QIXjxcD5H8J98zSXdT4B0SykSVf8TjD3750rMHNe18tmTJvrCJdojhPmcGud Ytq4HPPIbxUbolPniqc0QEqSTqQ9Cpa1oCU4bItsQbH1ebRX1qfxxJfjN2Wzcd62wUho OyiJOnlVWmTXACV2KtRhw2pLjTJg4q0d8ZhPeT5X88z60Q26impmoNQAtKKtmX1nAd+H zicURij6bTjYbGv6Og48FCkV3U3V8R8yc94vTpuKBGYQHLKarE6rAhg++GHjiRVIZ9JW XDig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769763490; x=1770368290; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Cfk+So9j7LmEglWj0SSY3ONnLjxUj5/C63f6qCN1qV4=; b=MmjFnS+ErEmbOugyzXe59ZF4wKkY7u0NlKs8s1dWd+IypjLMn2++2SNfiIpp3L/7/a zojFZiCOe7Uss0vT+fwy2qMJ81U/5mHs/z3PtMfux33rZi3poAU42kRa95+AKwErYYHJ GyZcZ6I3It9A7nsZSxkF6aGtvj1ZCfQFyw5oJtMspV88QVHIzhFqVydypjFKoLrXNKnk /l5VWx+P2iGr8vwNPa1UkX6GSVaaBAXnvqhIx7a3YX1m7dfPAT624dmOuOobbBT/quZy mPfxX/B5iqnm7W6B3t6YEX1PBCeeFQL+PjFkFIbvpJqXQpolw8XCYtaSVSos53gVUxIn qYcw== X-Forwarded-Encrypted: i=1; AJvYcCW3Ot7HU8WIS+HZM/FhifU/ModoGgRHP/KnNUlWK7zDvI8HhJK4GBMN1LMIvHMvULX8Bkw4/4QHKxnVouU=@vger.kernel.org X-Gm-Message-State: AOJu0YxRrvzcXZiIY9lSHHxnGqTdUR62oj1isZj8kD1joXBJp3X/PqCT kEdJDlALZpCkHgnwVJwkANiWGpPon39TUAkVZNZuRcJYeaXUYO/Btg94bd74PgfcXyc= X-Gm-Gg: AZuq6aJ+XRql/e+2ArHbe8j5QGJLimZ+3OReIECPYVkhXDtr9RI3njjiBFCDjC/ULGV xt5FYoxZ/3uvOvzcF+IGF9Czvwi5IRZYEPgM0ZGCP/cekk4NA20b7i5y5xaXXIvaiP+5prRVIU+ LN+5/T/lAx1UDousG3wI6giQ3u6yIFNBS6M0kX22D9xZmeChVcUrL67IuG4InjbWCiR2qlNviTj OfranAVYFVhpi9/PI73vW8l6JQqYm/54/8zRCUYHQ9Agi2RYc11djMuFtwHwPm4eVjy9WAztCt8 6Fv3Fd3AHRqOCmOpX+7YpqilYENc5r7May8RvjbmtoPLIozixN4Bq0Xub9BM2iTxl8IC/gCZc1h OwfeW70lDmotDz0qE/I1Xd5+dHK5INUIzlHHxILBuWQy0nvdUTP64vrzQPr7+QtrRXwuh/Hu3m0 WMQcfvGJrLm26KH34I X-Received: by 2002:a05:6000:2689:b0:435:e436:7fb with SMTP id ffacd0b85a97d-435f3ab00edmr3363688f8f.50.1769763489486; Fri, 30 Jan 2026 00:58:09 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10e48a6sm20330162f8f.8.2026.01.30.00.58.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Jan 2026 00:58:08 -0800 (PST) Date: Fri, 30 Jan 2026 11:58:05 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] staging: rtl8723bs: remove unused private debug counters Message-ID: References: <20260129163438.35749-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260129163438.35749-1-ethantidmore06@gmail.com> On Thu, Jan 29, 2026 at 10:34:38AM -0600, Ethan Tidmore wrote: > The driver maintains a private `struct debug_priv` embedded within > `struct dvobj_priv` to track various error counters (e.g., suspend > errors, alloc failures, RX drops). > > These counters are incremented in various files but the data is > never read or exposed to userspace. > > Remove the unused `debug_priv` structure definition, the instance > in `dvobj_priv`, and all associated increment operations across > the driver to clean up the code. > > This also removes the following helper functions which were used > solely to update these counters: > - rtw_reset_rx_info() > - recv_indicatepkts_pkt_loss_cnt() > - rtw_hal_check_rxfifo_full() > > --- > v3: > - Squashed previous series into a single atomic patch to remove > definitions and usages simultaneously (Feedback from Dan Carpenter). > - Removed stray blank line in rtw_mlme.c (Feedback from Dan Carpenter). > - Removed unused variable 'fw_current_in_ps_mode' in rtl8723b_dm.c > to fix -Wunused-but-set-variable warning (Fixes kbuild bot failure). > > Signed-off-by: Ethan Tidmore > --- The changelog notes go after. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter