From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 948A0329E40; Fri, 30 Jan 2026 14:38:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.175.24.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769783905; cv=none; b=Sp+fnFLzGlAACs4horA3lwN6bjd+0BbnhcHuGGZbwjUpseMJCEL7uL5Bb649mW76hZmW9EBVAMQ8/SgHelTGm1K5Ksz2BG4WRRbjeFYW0MYsVDi8PRa6AnBYCR+DdOWWIP8/MhOgmXp89ovQ1V0tqOXMiWyFtOWXjQ0lLW0mVq8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769783905; c=relaxed/simple; bh=JwWdTtXP6aYnY46cQ244PNUDxwPqzAMtK4NQiX4+FVM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kIuWLFlnvqvTggP/P41qqTpHYwBBeCEB45H/fsfUg/19yNprMkAHhqbpI3mdwwIs/5bUryWqaDLxrYkhivgeL1cISebyfViCv0sTyCegS+yJb1h9lgJNtICeljuhD1MXs8gF1OQDZnHZB7GJcV+0r30VpL+4BHxrIzPp40Nwzlg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de; spf=pass smtp.mailfrom=alpha.franken.de; arc=none smtp.client-ip=193.175.24.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=alpha.franken.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=alpha.franken.de Received: from uucp by elvis.franken.de with local-rmail (Exim 3.36 #1) id 1vlpdb-0007Ev-00; Fri, 30 Jan 2026 15:38:19 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id C4CE7C0748; Fri, 30 Jan 2026 15:37:58 +0100 (CET) Date: Fri, 30 Jan 2026 15:37:58 +0100 From: Thomas Bogendoerfer To: Brian Masney Cc: Claudiu Beznea , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Turquette , Stephen Boyd , linux-clk@vger.kernel.org, Thomas Gleixner , Adrian Hunter , Ulf Hansson , linux-mmc@vger.kernel.org, Linus Walleij , linux-gpio@vger.kernel.org, Alexandre Belloni , linux-rtc@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Guenter Roeck , Wim Van Sebroeck , linux-watchdog@vger.kernel.org Subject: Re: [PATCH v2 00/16] MIPS: move pic32.h header file from asm to platform_data Message-ID: References: <20260112-mips-pic32-header-move-v2-0-927d516b1ff9@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260112-mips-pic32-header-move-v2-0-927d516b1ff9@redhat.com> On Mon, Jan 12, 2026 at 05:47:54PM -0500, Brian Masney wrote: > There are currently some pic32 MIPS drivers that are in tree, and are > only configured to be compiled on the MIPS pic32 platform. There's a > risk of breaking some of these drivers when migrating drivers away from > legacy APIs. It happened to me with a pic32 clk driver. > > Let's go ahead and move the pic32.h from the asm to the platform_data > include directory in the tree. This will make it easier, and cleaner to > enable COMPILE_TEST for some of these pic32 drivers. To do this requires > updating some includes, which I do at the beginning of this series. > > This series was compile tested on a centos-stream-10 arm64 host in two > different configurations: > > - native arm64 build with COMPILE_TEST (via make allmodconfig) > - MIPS cross compile on arm64 with: > ARCH=mips CROSS_COMPILE=mips64-linux-gnu- make pic32mzda_defconfig > > Note that there is a separate MIPS compile error in linux-next, and I > reported it at https://lore.kernel.org/all/aWVs2gVB418WiMVa@redhat.com/ > > I included a patch at the end that shows enabling COMPILE_TEST for a > pic32 clk driver. > > Merge Strategy > ============== > - Patches 1-15 can go through the MIPS tree. > - Patch 16 I can repost to Claudiu after patches 1-15 are in Linus's > tree after the next merge window. There is a separate patch set that > fixes a compiler error I unintentionally introduced via the clk tree. > https://lore.kernel.org/linux-clk/CABx5tq+eOocJ41X-GSgkGy6S+s+Am1yCS099wqP695NtwALTmg@mail.gmail.com/T/ > > Signed-off-by: Brian Masney > --- > Changes in v2: > - Fix native MIPS build by updating include files > - Link to v1: https://lore.kernel.org/r/20260109-mips-pic32-header-move-v1-0-99859c55783d@redhat.com > > --- > Brian Masney (16): > MIPS: pic32: include linux/io.h header on several files > MIPS: pic32: include linux/types.h on pic32.h > MIPS: pic32: drop unused include linux/io.h from pic32.h > MIPS: copy pic32.h header file from asm/mach-pic32/ to include/platform-data/ > MAINTAINERS: add include/linux/platform_data/pic32.h to MIPS entry > MIPS: update include to use pic32.h from platform_data > clk: microchip: core: update include to use pic32.h from platform_data > irqchip/irq-pic32-evic: update include to use pic32.h from platform_data > mmc: sdhci-pic32: update include to use pic32.h from platform_data > pinctrl: pic32: update include to use pic32.h from platform_data > rtc: pic32: update include to use pic32.h from platform_data > serial: pic32_uart: update include to use pic32.h from platform_data > watchdog: pic32-dmt: update include to use pic32.h from platform_data > watchdog: pic32-wdt: update include to use pic32.h from platform_data > MIPS: drop unused pic32.h header > clk: microchip: core: allow driver to be compiled with COMPILE_TEST > > MAINTAINERS | 1 + > arch/mips/pic32/common/reset.c | 3 ++- > arch/mips/pic32/pic32mzda/config.c | 3 +-- > arch/mips/pic32/pic32mzda/early_clk.c | 3 ++- > arch/mips/pic32/pic32mzda/early_console.c | 3 ++- > drivers/clk/microchip/Kconfig | 2 +- > drivers/clk/microchip/clk-core.c | 6 +++++- > drivers/irqchip/irq-pic32-evic.c | 2 +- > drivers/mmc/host/sdhci-pic32.c | 2 +- > drivers/pinctrl/pinctrl-pic32.c | 3 +-- > drivers/rtc/rtc-pic32.c | 3 +-- > drivers/tty/serial/pic32_uart.c | 3 +-- > drivers/watchdog/pic32-dmt.c | 3 +-- > drivers/watchdog/pic32-wdt.c | 3 +-- > .../mach-pic32 => include/linux/platform_data}/pic32.h | 17 ++++++++++------- > 15 files changed, 31 insertions(+), 26 deletions(-) > --- > base-commit: f417b7ffcbef7d76b0d8860518f50dae0e7e5eda > change-id: 20260109-mips-pic32-header-move-6ac9965aa70a series applied to mips-next Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]