From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 10028285C8E for ; Fri, 13 Feb 2026 20:48:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771015722; cv=none; b=bNW4GYRMx7SisjZkZ/JajtiRW+fkUaNfqoUsYAOkPXKUzBOta5NbxlON2HIEwDII0FNqKQ2X/lbCxLpzm1kg/3+Va1FBOHLbsKhH4CTS1p4Is8rYd3djoahb6Hix3TXFQ75HHxpVz1kZ40toQbcYwtTHVkP9V0ZKE3Fe6qTs9b0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771015722; c=relaxed/simple; bh=W/pVJt/wvydYWWC0lqeyhGED8yc2b22X0xX48t6bb+k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JzxKbgLqbrKQVQZPvBtJezm8nqK3OdrbRg5VQnPE9wi6j5k8itxE+4AmOvhuxfkzrIRasYiiWpK+2babuVXCq16ZsSKqy2mFRmKz6gq12R3SMBcndKTklk85ANPBJDg18fOMz/bDaCbLYac1blD+FJoNcTUCmK9JysAMkgUhENc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bs6TGQ7w; arc=none smtp.client-ip=209.85.218.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bs6TGQ7w" Received: by mail-ej1-f50.google.com with SMTP id a640c23a62f3a-b884a84e622so175622066b.1 for ; Fri, 13 Feb 2026 12:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771015717; x=1771620517; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/XdoMoffXlEUCxzIMNRrk5M4zeOLPJRBb48+Cvgmzlg=; b=bs6TGQ7wFugheoZ1dqFDoje9ij5UghWUG3iJPbIoWdGR8ijQO+Lss/6zVNbCXMA8+S QGPKf/U9kT3QSIeWwyT3ICYMxUn0U6+LPinkv/LS6OqDBlzD+KsTBbCXndXHBEBZqFMN k7gaJ2Ts7yIq+nKAQZRmaEn4Xo0w4BotOeDUNxoYh/EOFoGPHb6UG5M/qN/9zwe9aj8P T+Gon9f2rY1OWirMAaaSgvKRlH5XWjYaoMiQqnaht0VE/sLC/xKPWg7nOF4q5hEXvAvn LxUae8mNen8WsihdzLkqrCVmhj/xtRYsux3HpuZ/Xo2oFe+GG6TQTRF1SR0Xxp+F0CPF HuRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771015717; x=1771620517; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/XdoMoffXlEUCxzIMNRrk5M4zeOLPJRBb48+Cvgmzlg=; b=IZrNmPZB2Wci/iYP8WTW0sErA2u1QBHMfm9ppIhQL6ZKJgFLLsW6y5R2o3ahilTckZ AUwjH95y0AQS9T44QmQOiAd5tIxOy4i+MBavA11We4kfz4RaRXiZ277ig6fvkG8TZkW1 xcELUvLZzdsFq3q/Ep3DFYnOa1fR04KASNgb4O5B4SMfB/d2wrlMjEs+JUhX6d7/sIfP 9qYTdV8tY7cWIAjt5AsJTMYlbNMB+crugOiS3Ez6ByaGrcrAwzcgvG/B49WTs7eeLBRc vykJeqMR1V2rqwaSw9IAALh7Sz2IMDMRXJ9/khnLgIaP1eeN/zl18I1RJvNqBVEGTxC+ HS0g== X-Forwarded-Encrypted: i=1; AJvYcCXEIE5HyIvGgdWLB153w12SDn8z43g9DTJGK878ULkJZrCLkgUKLzjv/QREDIeygTb/3edDWrm/Je6qW3Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwZs9hakoNnPA5cnH/RIVxiO6z1O9k+XsGwZMoQb+p5HisV88uV Rcf2pTvLoCJLARrLPFNfQ0kbRbYpqy6QgX96SHoZIhARjy6RIAxEUbY0 X-Gm-Gg: AZuq6aLby5/a5U6tlJ4bEd19QuJNi3kzBu5EhiNXS8Tox5aNW6N7kDJZCY8eTn8lACA n+iC6kb+lkHiR1qj0z4+j0lHPEuShIefYp9qX4VWSWzsurfzxsq0p8Wo5Il5LbGMGmIQo4fAfjm jhMJ9/Bq8aRkFu3aG5gSo6oDTFZnzCk8ACxtBMYmq9Bi06I2Vavx6uBnLFGUtTLXlxLUNCrNMey v1ZQpK4Mi2oYv+EmkKrCS15LWrFJilueOmRL3DebJFUz9IjqTB6FLoTJi0P+cpcdAybQ+JlV/J7 Ob5EB0y3J1RgwqAuOhbZgEICqQQd300Mu/xfnNYwybtSBcVLpXuJa1cx3spypFvkHSLpvhXAJu1 MV+8ZVKQExj6z5E4Fw77egtqurOoGhmmzFVcOLu00ixewwKPQb/pl4xfHs/OM+Gxn7XzY0iZsX9 +uJ+L08VOPB0eTLA== X-Received: by 2002:a17:907:7fa5:b0:b87:1d71:f44d with SMTP id a640c23a62f3a-b8facca14bemr223447866b.11.1771015717211; Fri, 13 Feb 2026 12:48:37 -0800 (PST) Received: from jekhomev ([46.251.53.180]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8fc7385f5dsm878966b.20.2026.02.13.12.48.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 12:48:36 -0800 (PST) Date: Fri, 13 Feb 2026 22:48:36 +0200 From: Yauhen Kharuzhy To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Hans de Goede Subject: Re: [PATCH 2/5] input: drv260x: Add support for ACPI-enumerated devices Message-ID: References: <20260211235902.4156624-1-jekhor@gmail.com> <20260211235902.4156624-3-jekhor@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 12, 2026 at 09:26:24AM -0800, Dmitry Torokhov wrote: > Hi Yauhen, > > On Thu, Feb 12, 2026 at 01:46:52AM +0200, Yauhen Kharuzhy wrote: > > Add ACPI ids and GPIO lookup mapping for drv2604 haptics device. > > Found in Lenovo Yoga Book YB1-X91L tablet. > > > > Signed-off-by: Yauhen Kharuzhy > > --- > > drivers/input/misc/drv260x.c | 30 ++++++++++++++++++++++++++++-- > > 1 file changed, 28 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/input/misc/drv260x.c b/drivers/input/misc/drv260x.c > > index 18360bdfe877..f613c81fa2ba 100644 > > --- a/drivers/input/misc/drv260x.c > > +++ b/drivers/input/misc/drv260x.c > > @@ -15,6 +15,7 @@ > > #include > > #include > > #include > > +#include > > Sort alphabetically please. Sure. > > > > > #include > > > > @@ -419,6 +420,12 @@ static const struct regmap_config drv260x_regmap_config = { > > .cache_type = REGCACHE_NONE, > > }; > > > > +static const struct acpi_gpio_params enable_gpio = { 0, 0, false }; > > +static const struct acpi_gpio_mapping acpi_drv260x_default_gpios[] = { > > + { "enable-gpio", &enable_gpio, 1 }, > > + { } > > +}; > > I'd rather move this ACPI/device-specifin handling into drivers/platform/x86/x86-android-tablets/lenovo.c I am not sure if this is device-specific, but since there are no other devices with a DRV260x ACPI entry, I may agree. Will move it. > > > + > > static int drv260x_probe(struct i2c_client *client) > > { > > struct device *dev = &client->dev; > > @@ -426,6 +433,14 @@ static int drv260x_probe(struct i2c_client *client) > > u32 voltage; > > int error; > > > > + if (has_acpi_companion(dev)) { > > + error = devm_acpi_dev_add_driver_gpios(dev, acpi_drv260x_default_gpios); > > + if (error) { > > + dev_err(dev, "can't add GPIO ACPI mapping\n"); > > + return error; > > + } > > + } > > + > > haptics = devm_kzalloc(dev, sizeof(*haptics), GFP_KERNEL); > > if (!haptics) > > return -ENOMEM; > > @@ -484,8 +499,10 @@ static int drv260x_probe(struct i2c_client *client) > > return error; > > } > > > > - haptics->enable_gpio = devm_gpiod_get_optional(dev, "enable", > > - GPIOD_OUT_HIGH); > > + haptics->enable_gpio = devm_gpiod_get_optional(dev, > > + "enable", GPIOD_OUT_HIGH); > > Why this change? A good question. Looks like artifact from previous development iterations, will remove it. > > > + > > + dev_dbg(dev, "Enable gpio = 0x%p\n", haptics->enable_gpio); > > ? Hmm, looks like a forgotten debug stuff, removing it. -- Yauhen Kharuzhy