From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7B6235CBA8 for ; Thu, 12 Feb 2026 16:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770914032; cv=none; b=DY7VvhdQxHMxjQV+MgqTSu2P2tRyk0YEmx2L74m0EHkb6j2ljWaSvjGSTPRuGBzueJDV/IlP8+2bEu+/JM7Uq/tHBON0E53HbqtJxk/i4TfQJfiGB50e97YPET1Q2lCd1qv1BWmByBNnY+3RUqnCGUVk7MtINuZh3dBml9rakwk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770914032; c=relaxed/simple; bh=25opVHIv7SCRMY++47xY4pgZkKy1953wVdAJuD1SWmc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V7rO3SX5ANe8Thqz2qXJ0VbJnI28ZDidKCZG/QpdLxO2vp5aZFg0Jt34uBCo3kEHWvc7+8IriWDEIWKrxRoSsv/hO8ZqcKecmWbfN6dm8XaZmCo0SlP1OSbyqTZACgjuMRmNFVfjENQ3xPNSjjofhT5i1npq6tS3eWUowvbQM+A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net; spf=pass smtp.mailfrom=gourry.net; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b=eCMzHIrF; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gourry.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gourry.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gourry.net header.i=@gourry.net header.b="eCMzHIrF" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-8c6a50c17fdso6450285a.2 for ; Thu, 12 Feb 2026 08:33:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1770914027; x=1771518827; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rXxVe4fRiyRXCoNbo+oc/BgJFQHLEBXNd+WUueWHuWk=; b=eCMzHIrFmXW65iJZw47f27gn1Y7Q4kfH6lzN19tlpFPxdhusvhFWHCVGeONXW4H3sG 3cIpGkPQc0vdKJZTLV5ZEeVn/G6V+QVkMArj7OOM3bYDPYtBc82Ap9UAB2/WwArqtFsv IpHb+FW08TZO3tbFSUid6nbCt1YhceHpy1KF1O6N51yT9oKbK5WOgzZyWMOCd+vu03HW 27/W7tMMGWiypNks8PeCP/pgWDnsmzWJT6hsFwehqRiGaatXA0po//DK8QLwYJ3hUJE9 97265knnlrPVBjS7PepissFlf+0f7TCTw9IYjhJLYrB4Pc072cq/rENMcjBkERiETLzc czIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770914027; x=1771518827; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rXxVe4fRiyRXCoNbo+oc/BgJFQHLEBXNd+WUueWHuWk=; b=VRVtgFuPvkxmFL58QB0o0pDHTVQ52YZGusI6FBxjGqi/jnqYHNUn1SxCeJ/aPxZ2n9 4y9yaWo5QzuDOQ/zh5J5WQLHZHpkh5bVJ21I7DBdvTygWbRfhdlzKUqGuz5zGvELPHk2 KBW2UNU823pLr64I7OGQisE+T75eOdS5Y8NIrKawsuzwbKriwr2qVlPlH8IJcm6ZYU6v dzpU896PtROXb8Qwy0Oy+wBk+/QZ9KGsl0d7YABCUgSHBDXtliK3oVYwHdz8fE9a2Lx5 xcI3vDAWaCFmbIXlGKYR8axcH4pX6qSzOHc1ZlHEBYjbxUNVudlKF6RRX0tuya18oKBR G/TQ== X-Forwarded-Encrypted: i=1; AJvYcCUydqd4gwo5XhNYvgpKkhUqP1+aLODFBuiS6v4xS9qJBkMQ0gQoPkdiYM6jzM846KGoXggN07wzGZ245LM=@vger.kernel.org X-Gm-Message-State: AOJu0Ywd0qrUOHKGs97/rQ0s1IDtduJeSfJpCE8lHPX8fNciFtTIuNqT 0EcUzjYy7BLnbYTcwTXA3xXdF9K4hcN7ugR5kNjByld/QkNFNzBqvz4/9oXQvtzQodw= X-Gm-Gg: AZuq6aJq6RY0bzVhe6P7Zcw15SfeLg3oyoN/8Ukw8iLknRETA8HnlFp70uWdON6n/m2 7UYTbqWCxfgM5DP3FDhqIEdKXOQWzaMLfERdcJ6tImY/7U5+9FyvrlWAzRr1kUO9uvBd6xFxqQF xU82t99lUvogFCISfu+Q/yo1cmQ/MY7WCt5YwTa6JFKYxVIAhgCZ6u2qNAvMONdpDjYH4j/aETW 7HsyFE4nG9TzYjI3BWpdtnN8fVMWPiR2QrWMSdt6mZf+AsMhnAHaq8QueU8qcB3HqTa+uI4C+m4 4FkR73ZuvG9uIjTqquUmq5beIKKEG39o6q5oKXWOvQqGz3IzPcRMJ5TQ8uS1K37FuFpTid8uwZ0 Jxq9d7yRCLJFkYhhvUWnd8QzmXczBw9j+jd2PCDMOyQWEEzvMDvbA5nBJdNdc2wnsavcNzbU/lx HeSMZlc0vKSs+NlYCfJqpBofeOJxpiG5eQ1ooeDEir3fTDQ5W0lnsjoAxooqt9zdHbhJOC3Uk/s /ysIN9zKQ== X-Received: by 2002:a05:620a:bc9:b0:8b2:ed29:f15f with SMTP id af79cd13be357-8cb33090e29mr430636985a.21.1770914027457; Thu, 12 Feb 2026 08:33:47 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-96-255-20-138.washdc.ftas.verizon.net. [96.255.20.138]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8cb2b20f5desm372226785a.41.2026.02.12.08.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 08:33:46 -0800 (PST) Date: Thu, 12 Feb 2026 11:33:44 -0500 From: Gregory Price To: "Cheatham, Benjamin" Cc: linux-mm@kvack.org, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@meta.com, david@kernel.org, osalvador@suse.de, gregkh@linuxfoundation.org, rafael@kernel.org, dakr@kernel.org, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, Jonathan Cameron Subject: Re: [PATCH] mm: name the anonymous MMOP enum as enum mmop Message-ID: References: <20260211215447.2194189-1-gourry@gourry.net> <35db57ae-64cd-40ed-8353-7d3b64069471@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <35db57ae-64cd-40ed-8353-7d3b64069471@amd.com> On Wed, Feb 11, 2026 at 04:18:45PM -0600, Cheatham, Benjamin wrote: > On 2/11/2026 3:54 PM, Gregory Price wrote: > > > > @@ -77,7 +78,7 @@ enum memory_block_state { > > struct memory_block { > > unsigned long start_section_nr; > > enum memory_block_state state; /* serialized by the dev->lock */ > > - int online_type; /* for passing data to online routine */ > > + enum mmop online_type; /* for passing data to online routine */ > > Comment looks unaligned. > Ah yeah was already unaligned. Bleh. Probably not worth a full v2 unless Andrew prefers that. ~Gregory