From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D345B2F872 for ; Fri, 13 Feb 2026 01:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770945763; cv=none; b=PsIcDAhyBKLkCCBAObA3bdleyjx48bf9o3K49KOKIMoUvl2y0FgNX2aKUv/f8ShzTN5Rv4UuBeKpgjqbzYrdTpn86rtPxntHEYQqQrqP2fO2J/2ZCbjWarutJcpl4IIPTS9uM7ADg0Ir5dWFjyjF5nLS3Iuv+QSbq7yPJQ2kPf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770945763; c=relaxed/simple; bh=2EeIMhJK8PFDk+lw2mlbKJHzWDiXMy1oQw7hKItHAM8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=M5btGQ6mQ1gAiQJZT/ELXetdW0htgljGRDNlaL06pubrVbkBuFamVHoExhUg7X+Vih3KC3UHbw6QfWDz01K86MZK8cpA2EWZvJxxvNTa9Dutymd2J2G/wXZFaprJyHXvNgGkIcSKvfnl9GkTabDSmlCOqS43b++SCk5SBvLLJho= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GiN7jc4s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=f4GJFPZK; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GiN7jc4s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="f4GJFPZK" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61CKunbN1068012 for ; Fri, 13 Feb 2026 01:22:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=19MkWG0OHq3iuy1pxsE17MAI lcD70cm6euhfGg/Aln0=; b=GiN7jc4sPOQ+hKBNNRyF+Y/x7ejsevvat8Gmkk6n kTDgz1VXjV97lrxr2z4wXnxE4MDxGrjh+LnVflguuO4+Gg/WmnCBIA2jgOar2IuK i23tnTOtQ1c+HpSPZrVf12lA93+UU0lPY7dW9LCc3FASgKyAGbP9JhdbAly6eu+O 5+mv68Gt7Gr2xLoko4hM/mJDKvVEvyDXlvQt3GDTzJOE92qf5iKN5ojlQDIs3lt9 Uud2NR3CrCwOKuJpRtE/90Wc91aV9YMyM6KELm0/ctwnKy05JaJYb14s/v5lJMrG 2so2l8oKeMqngADv4L5oI/cZk+aBfY2K1U36M5b8HIDjuw== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9d09k0qn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Feb 2026 01:22:40 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2b7ef896edcso617422eec.0 for ; Thu, 12 Feb 2026 17:22:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770945760; x=1771550560; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=19MkWG0OHq3iuy1pxsE17MAIlcD70cm6euhfGg/Aln0=; b=f4GJFPZKIegNX9pqbv4oBmqewMiKHlh2OLe82D5p7xQj6hkLi1RlPZPgYWNpjD8Q6s 2cyohCNiPIzjgnu41ZW44K7izOVDB4Yk/PxLvuQ8mFJbx3V8BMWVwrpH7hBggLZ99Ca9 vc95b8jO5vitVeEQAf4oRP1IWqtZhuEStpTykFxYzPIbEen0ac9cDgLyosINiGpFE/HN ckVwzLcaXhGBAELeY5sFjulKu1uWP4e2cLUMXqHumPHCLqGgHtyNAto+tSdcNtCN87eS LnVfBQbB9xR08k79cGpzB1COPA01wa0xvZMtSLlp2sgKNjK4qjuMj3hU22lpqL8nRvsr sQGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770945760; x=1771550560; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=19MkWG0OHq3iuy1pxsE17MAIlcD70cm6euhfGg/Aln0=; b=m5Zsxkjtjkf+Ik6JhRcqahTccC4Mi9DNHVlt4j36R+GpkSJ0wkuI1ZxqJK0UETpc92 JdOp/ZF/Y20zS6f8S13hrh4c3GvTvCS6KXp6bIJ8M2okIwe+4wBhu0hM5BOj6SLYJsCe UePpSPQi/s/SyUZ7WuLDKjYEk5wx+Jo+VW+9zqSAmT8d6yE00dPerXLwVwBsxNdQ5Fra +lauxFD9HCZobk8+VN5HwvGrXByD/nJy0C777mcA0TQmsuea3sqa/qO5oMO697HQnovm Rdy8s9QF9B7Z/Ti0/cC4dkttunqRvXKJgJQsUpbm3a0gfkwY60RLO1kaZ/1GtlZU2nev tUNA== X-Forwarded-Encrypted: i=1; AJvYcCXIedhB19WUk8rKGlsh2w2tUMuDZCU/3MtIgPk5DJ4Fdj3lemG62QZZu6g1Ei0zzWHsN6qoNzr7WL/SIVo=@vger.kernel.org X-Gm-Message-State: AOJu0YxNCKjk1DnlhOKcVQrmhC5AyviKOev0N7+mOjB1/DXt7qaCSimi RmRmyXKI9r80zQdQA0kl8GntO/NQvHfy5fx+b1XWxaY4BND7a6PryFFvxj71rxgBt0mbJVl2Ams gm0ceUv2d2cS0JqdDMc8QxfQKI/jvxs5mjBJ9rFL/SmDtkm3rfEWA8Y41ytAwfA8zuAQ= X-Gm-Gg: AZuq6aL/P20cSCORbiG+sMgSdD/emq1yPHtfV4CxoLFbSTXvPw29ElQTdAEIWcFmnhn 0i3djGqiKBnRMJ8nitFBMfhl7qtE2ODzDPTqPCOld+4x90JIrSBTdJr1w/jQ3Aq2AsBc1MNjIx0 Of0Zk0Dgh5WLxvYwbO2wVDvix8W4v0tUMY8AXWAZ05bhnysyjYb7yXCl3x+kGmnzjY1u8d/mbct SEB3hkAs759xlUPGnyT9Q1kAkxXowgUy8rJa1EL60fswUll4mN2RPa2Oz11cFQ5w/tg8wKUmKz6 Ct9FQmycWT/cp77fmNnCNB/86i0LKudk4jcTJ/LjnAP32zJLQHg43M2ChStGOC69jI4P5FRGIEQ XA1iCZ+Vsce4/qX2/UayTp85rnfUBbb8qMmS2GE6FxayA/AM9QGBUVmhVJzUHRW5Z X-Received: by 2002:a05:7301:168e:b0:2b8:6573:2d35 with SMTP id 5a478bee46e88-2babc42e1f4mr92353eec.2.1770945760100; Thu, 12 Feb 2026 17:22:40 -0800 (PST) X-Received: by 2002:a05:7301:168e:b0:2b8:6573:2d35 with SMTP id 5a478bee46e88-2babc42e1f4mr92328eec.2.1770945759451; Thu, 12 Feb 2026 17:22:39 -0800 (PST) Received: from QCOM-aGQu4IUr3Y (i-global052.qualcomm.com. [199.106.103.52]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ba9dcead67sm4637540eec.26.2026.02.12.17.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 17:22:39 -0800 (PST) Date: Fri, 13 Feb 2026 09:22:32 +0800 From: Shawn Guo To: Krzysztof Kozlowski Cc: Jingyi Wang , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sibi Sankar Subject: Re: [PATCH v3 3/5] dt-bindings: remoteproc: qcom,pas: Document pas for SoCCP on Kaanapali and Glymur platforms Message-ID: References: <20251223-knp-remoteproc-v3-0-5b09885c55a5@oss.qualcomm.com> <20251223-knp-remoteproc-v3-3-5b09885c55a5@oss.qualcomm.com> <20251223-furry-mighty-agouti-a222f7@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEzMDAwOCBTYWx0ZWRfX0F1JujrxbuvV brR/eXn2nnHz1dHxv6s2/ss/2szHrfO+k6aK+LSDNtmt0DNoCw1q24QhUZW2MbeZkVrGVUrNxQQ gzM0CR7bF9bXoLu2F5RYEIG6pkvQvxkaqIhstTq/dcg002BIWlr2jrX/z0cPu8fCEGpcKwP6+2E o7Z+dk+lsA0CBjw/yEd/mBYAAgooZXhaH7bs02fUDqtMxTaAtNs+7IVAZd4wLQIhY+hkPse4EHc gZ6g4EM6Guv4e6k065wNANYUS0tPC/M/m5xBWyRzie7AURQLQIOIzpsx8+qWwXtUPwKQV5Dgr/1 1HkUliMih2z8bKPdcuc1vEMct30UovQtDAhxuYJYJnQFXaKnRtEoM1tHThcLldTP1M3msgxaECE 5TncF/Xy+rbDid1w9jwefYPkuRubxnD02LfD4q6zWPJwzUuyEnNiVJ8Ejc9cFh88YX0pENMbryb z+oMeLgI2ZkL9rHDr+Q== X-Proofpoint-GUID: 3Lt2zz3PyfvomH9EW-nUO8S6dSh3E4-A X-Authority-Analysis: v=2.4 cv=Y6j1cxeN c=1 sm=1 tr=0 ts=698e7ce0 cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=b9+bayejhc3NMeqCNyeLQQ==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=VwQbUJbxAAAA:8 a=SvtFGoktTUcKB-mbNKIA:9 a=CjuIK1q_8ugA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-ORIG-GUID: 3Lt2zz3PyfvomH9EW-nUO8S6dSh3E4-A X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-12_05,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 adultscore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 impostorscore=0 clxscore=1011 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602130008 On Wed, Dec 24, 2025 at 09:34:30AM +0100, Krzysztof Kozlowski wrote: > On 24/12/2025 04:16, Jingyi Wang wrote: > > > > > > On 12/23/2025 9:29 PM, Krzysztof Kozlowski wrote: > >> On Tue, Dec 23, 2025 at 01:13:49AM -0800, Jingyi Wang wrote: > >>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml > >>> index 63a82e7a8bf8..149e993282bb 100644 > >>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml > >>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,pas-common.yaml > >>> @@ -33,16 +33,22 @@ properties: > >>> - description: Handover interrupt > >>> - description: Stop acknowledge interrupt > >>> - description: Shutdown acknowledge interrupt > >>> + - description: Pong interrupt > >>> + - description: Wake acknowledge interrupt > >>> > >>> interrupt-names: > >>> minItems: 5 > >>> + maxItems: 7 > >>> items: > >>> - - const: wdog > >>> - - const: fatal > >>> - - const: ready > >>> - - const: handover > >>> - - const: stop-ack > >>> - - const: shutdown-ack > >>> + enum: > >> > >> No, no. Stop doing random changes. NAK > >> > >> Now you remove strict order (see writing bindings) and claim every > >> device like SM8550 ADSP PAS has any order. > >> > >> And it is now de-synced with interrupts. Read writing bindings - this is > >> clearly described there at line 90! > >> > >> You can only grow existing list. > >> > >> > >> > > > > the interrupt for soccp is defined as > > "wdog","fatal","ready","handover","stop-ack","pong","wake-ack" > > while other pas could be: > > "wdog","fatal","ready","handover","stop-ack","shutdown-ack" > > > > so grow existing list is not work for this, > > > > In the v1, got your comments to adjust pas-common.yaml for the interrupt: > > https://lore.kernel.org/all/861b6ede-f168-44e6-85bd-10cf04dbcec7@kernel.org/ > > > > and in v2, interrupt are moved as part to the "allOf" with if-else and > > also got NAK: > > https://lore.kernel.org/all/20251030-venomous-apricot-falcon-b3fd64@kuoka/ > > > > Could you please share a example for us to understand how to maintain it in > > pas-common.yaml, not define if-else and has strict order at the same time? > > That will be very helpful. I guess something like this would work? interrupt-names: minItems: 5 maxItems: 7 oneOf: - items: - const: wdog - const: fatal - const: ready - const: handover - const: stop-ack - const: shutdown-ack - items: - const: wdog - const: fatal - const: ready - const: handover - const: stop-ack - const: pong - const: wake-ack > > > > Can you read the docs first? This is not a ping pong, where you keep > sending till it passes the review. If I provide you idea, then you will > send something whatever based on that because you still did not read the > rules governing bindings. Krzysztof, Feel free to shout at me if my suggestion is not what you have in your mind :) Shawn