From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 786DF27B33B for ; Mon, 2 Feb 2026 06:32:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770013960; cv=none; b=sLP8zEyylDWtXvEH9u+oeK8m+aZO+pJuqpo//Aa1B8sZQ+kAfobcwvVggR5irYlS8sFjoHPo+MHAn3OECIrw28FA0pZ2fxhWfttac5+wqJEHAptbKzVGhgWzS6mI5vW/ft7afo29pJl24SsMXflP+E3lP5Ba8Qz8zu5HOs+EYuI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770013960; c=relaxed/simple; bh=GNhVTBlnouzaVaIZbBjia4fDeb1Ma0W34R3FR6sNPMg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=V/vFemDzlpcdVsfRAuaHCkAlkVdfKPG8HOjEU/5sVyx15cR5kx8d4MFZ32ayGjy3qFAjiUmaA0eyvWo26tIuo/CuqtHrzLAHMems5jqjJXFvaVgyAUGewgKg+2dT62YT3xhu24dUZjkOhzu6w7QQruKWQpgVVcA0BHFXTSCPgNY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=nYkIi2fO; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QCfCmP/R; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="nYkIi2fO"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QCfCmP/R" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 611MB8uJ1403898 for ; Mon, 2 Feb 2026 06:32:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=4X/ebpbZHKXJ3uGpBJiYRdCR +Q1zwA07WypTogytST8=; b=nYkIi2fOHCkyijd2EuOfdE2/ikXn4xRIVbjjDgS5 3lAO0avhLk8xQJkYyKByyaaKgJRKvUzETm9QpwCUMJ1xQcZVRT0XFJ/l5YRlmMyL GQJONHM9tQwBmI1CXzHy2+XLyoFTuWaDCaCeZRt/ZRMuh4nBdSZWKX8rtVH/d3I9 Xw3LhxEU2m04gvfds3Y4zL6Pfsrgbi/Z0+AVbJKF/af6tl9fXQA0JPfpf1El9b6d iUkhRFUot7w+HGR3T6hMbM+vEqlVMVlYFjsj0oQuQOppZeoymvu0ZQJgr6U7LBkf Ou5pOTY3fNaN2N3SIG6h5cQXppARMtm4feI4d+hBZ5gruw== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1au2m7qj-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 06:32:38 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2a7701b6353so42462015ad.3 for ; Sun, 01 Feb 2026 22:32:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770013958; x=1770618758; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4X/ebpbZHKXJ3uGpBJiYRdCR+Q1zwA07WypTogytST8=; b=QCfCmP/RS8J201LOb2/0XAgY+mlzljgHmsPBCScF1RvuSqtQl5jI4JM88GgFB099Ug hgFZO1TxeIiS8ZYXXUvcfgH5FYoEfM8uTZYpwLSVThQaur6ROVnjif6JA3lYrethnIIg UtDfLdrP4QKeRa+hN0zRLRzoJqXZ/Q9Yozw0bmqb0rXTaPHEdCt+F9tX0aOobjkJ68wI NNlpmJxSNqCvxBoWWrl2m7mZQIzl3jSz7hvvTWC+O/huvZyGNCLLFWgSFxqG88TCIJdj LStzg0xiU1jgBNcS7CywZHZnGQrPMpUtEZC0d+FfSORhMUeHpXR1oSkkRKgPK7jNb7Og XMrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770013958; x=1770618758; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4X/ebpbZHKXJ3uGpBJiYRdCR+Q1zwA07WypTogytST8=; b=GNMr9rvUtFfHvowiavdx+ypGsLUHzxGfwQBxZWzEfpkV8WTg68w6Tu7R24somquS89 G7NpQU+nQ9Jwcw+/qoOP1n6VS4DRNKJNns40HJYDpkYZnU21hmVJZfc1QxeBgoqvJ3K8 FiCcUFjo9DKQSkSeFtTK7+iZIxtbJPTRUFtbX5kOTquIrUcUjZaf1lwDyfMbk9C/hrhF kDcCrMqHFagrIf9trQGrY/CTBcwJjlguidGTGZwTzNDBsB0Qft8b37KQ4mD+gAM8/L8R xltGAdWUWFGflhlDZ9DhAHzY86P56xcNgKuJ3X/8FyDIPQbO/YJLK2ew5H6bDphV/SfA Uhhw== X-Forwarded-Encrypted: i=1; AJvYcCUy0CPfQ+S5spORjXAtebAfn0wbOpd+aHPwoyB7XIE0r2RhGSZ2amVSW/cmgaOI7KIq6uh9Vaj1hiV2R7M=@vger.kernel.org X-Gm-Message-State: AOJu0Yy2t071SFcqvVkrFyLC2RS8JYgVKaYxnNZnB/3wxbnwr8T9Z5k4 sT9oZuhTDKS/cTruaO3ZuiCEW2FysZkfMsQT393NnezqMLV4shQ6Sp5E1JycRNMUhEKoVmYUyfE XeEL4kyfvHiRenx9CWzjXSnaOT5NyyoQ4riHo6R/sEmjPAWFCsPbYbIUPIFIi/ipbdIA= X-Gm-Gg: AZuq6aKhfIJnPMj6Fu3SicJRH+OG3uU+fFXAR4TQI186V6BKZ21tD9deaIzyvQCgM8+ CQ7lB9fvwBghT+DZ7SUmaKBLDc0pMszg2liPMHXbWfqPvwhMlQMhKCd2QCsSgu41zpRuZNja/4G NY8CZnUV/q20IkorDA6KWmLOOjWgjUcruEAgxK44mLauZTf2/CC3HNwqHbfOzH0gpgV1JVqTyrg LoPMTcrEFYK6oK+sQyrAVkM+ZX2nOW+l+Ccga7y97Amb7e6CHqou6lKQjLuniSjL8g8NxQeu+y1 h+Tl/s8uByIPfrKDxqyoZNSSPneQsCu9CEAINbBmLCIqTWzqM9mVSQGmpV2IlngXqNH+HgMkwSq +obxHKURzh7DQJuRMAIiXW7JCS1s3xnkR+6/La8IoDgUWN2Q= X-Received: by 2002:a17:903:38d0:b0:295:4936:d1e9 with SMTP id d9443c01a7336-2a8d8037b2amr118684275ad.36.1770013958135; Sun, 01 Feb 2026 22:32:38 -0800 (PST) X-Received: by 2002:a17:903:38d0:b0:295:4936:d1e9 with SMTP id d9443c01a7336-2a8d8037b2amr118683915ad.36.1770013957630; Sun, 01 Feb 2026 22:32:37 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b426a64sm131346685ad.45.2026.02.01.22.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 22:32:37 -0800 (PST) Date: Mon, 2 Feb 2026 12:02:29 +0530 From: Abhinaba Rakshit To: Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/4] soc: qcom: ice: Add OPP-based clock scaling support for ICE Message-ID: References: <20260128-enable-ufs-ice-clock-scaling-v4-0-260141e8fce6@oss.qualcomm.com> <20260128-enable-ufs-ice-clock-scaling-v4-2-260141e8fce6@oss.qualcomm.com> <20260128-daft-seriema-of-promotion-c50eb5@quoll> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260128-daft-seriema-of-promotion-c50eb5@quoll> X-Proofpoint-ORIG-GUID: x1T0wy_7-NU8TYKRztXsRMh7z10LhroZ X-Authority-Analysis: v=2.4 cv=TtfrRTXh c=1 sm=1 tr=0 ts=69804506 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=skofDwuNRHh9mWMyy48A:9 a=CjuIK1q_8ugA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-GUID: x1T0wy_7-NU8TYKRztXsRMh7z10LhroZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA1NSBTYWx0ZWRfX5uOZv+1VoPXk GghGcl0W3iisR4wAgpCG4t/S1uIp0yxKrrnhG8fM1GVdMdUt5qFhhDyhgtd1MAS3Y0PttCKWBCT wp5+obxxnMjavq3S5qrSBEyNR7x6fbo7LxpJZV7G3B4CKdtyu8QrUqgCoNCVZrsZVt0mXqLhfNZ M13GV+v9VMHxkcyJbCdqajFooTm8KZyZ5AjACvAdO9MFrzx6NvEy4uxj0VQU6mBi6N20+HsmHlj anAcL44DfQK2xqZEiCNOepTBIR855bgy2ZgxFZiaIdSo9NUL2ATSZNxQq5bzyClNqpoIHVMTrzw X3z2dgdjl8p/LqTgW9FIVgI1EQj38FfeI0AZvs55iCfIYmf6TEPXbPTUUmFMRtw+GLLSjWKTT8e QJgbt3amHlzBkf6WKyVelWtlwZktO+2K51CGXgY8Wrreg3xPkrMUoEEuXBWpdVfF48V22DgF2Cr sc/kcB916sFE15Gr5WA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_02,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 lowpriorityscore=0 malwarescore=0 priorityscore=1501 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020055 On Wed, Jan 28, 2026 at 12:04:26PM +0100, Krzysztof Kozlowski wrote: > On Wed, Jan 28, 2026 at 02:16:41PM +0530, Abhinaba Rakshit wrote: > > struct qcom_ice *engine; > > + struct dev_pm_opp *opp; > > + int err; > > + unsigned long rate; > > > > if (!qcom_scm_is_available()) > > return ERR_PTR(-EPROBE_DEFER); > > @@ -584,6 +651,46 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > > if (IS_ERR(engine->core_clk)) > > return ERR_CAST(engine->core_clk); > > > > + /* Register the OPP table only when ICE is described as a standalone > > This is not netdev... Okay, if I understand it correct, its not conventional to use of_device_is_compatible outside netdev subsystem. Will update as mentioned below. > > > + * device node. Older platforms place ICE inside the storage controller > > + * node, so they don't need an OPP table here, as they are handled in > > + * storage controller. > > + */ > > + if (of_device_is_compatible(dev->of_node, "qcom,inline-crypto-engine")) { > > Just add additional argument to qcom_ice_create(). Sure, that makes more sense. Will update in the next patchset.