From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C06834CDD for ; Mon, 2 Feb 2026 06:36:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770014182; cv=none; b=pRCBFlK81LeKzVei+e9cVrpHM7e9ERNyGVUFRIaU7vQcph5R23khmWgsJgZ9GCIBIgLRS0RcgiEXnFgEpwooTXZQD2rwBiY1K4YIOazVpdfcUMG0JsvYL5JVT+LMtt9XxxQUHGC5zOj9XhOplnDTG9DVDDx39czPu2W2tU+DtOI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770014182; c=relaxed/simple; bh=xg9NDRatmvfZM5E54UM8msbcE7qfGPKuOC+UcnpJ4/w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ijVif5vXo04vR/J01IRToEINjsQcK7o2yD6/PhS51F7APaBcZoSCE5dfERR5/EBxiye4ISN5ntBNCsG222nFNDY+PrPSgAeQEu5bnjGN24q+m52lPYCv+wjivrfgyL9gPlSkyrRQzIqf/3JlVQsVu9/cThj2rSMDWFvjExiY55M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GihNtjmD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Bx8QmEpf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GihNtjmD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Bx8QmEpf" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 611NKQUG1192166 for ; Mon, 2 Feb 2026 06:36:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SeWrAZswpltJqdpISuUe09bjU6CqIAWEII1qQkgXJJY=; b=GihNtjmDDTRzpMPf 6aQjhdbcDWzLLok01G/P6xrmiMCy5YL26eKMr5UhAhLNq+xPCNuY931OH5A8yJFq w0VLjs6ExTUiLrWVyJ2GDVsTRb9QVWeDcRaaYGIOih88S2QGyQekv1rx7OkhCaJT a1GKuGUgvtMVecwWXw+szM9yIt99hguynrrXi8EGQIfcZLp9ckSYTjwQQL6x7kxx Do6zy2/17Y5uJ4dXyN/tGAJICMWl3+rWYguIyfp+mC61+M3ke1/OkciUvPW8hiqk NhR2u/TcZf+pQNxPvBI9INuBpdPI/qImp/NH56nSRuGhC+mSBBmnWrq6lQaGtQxY ze4A4Q== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1as4v8k1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 06:36:20 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c613929d317so2538439a12.2 for ; Sun, 01 Feb 2026 22:36:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770014180; x=1770618980; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=SeWrAZswpltJqdpISuUe09bjU6CqIAWEII1qQkgXJJY=; b=Bx8QmEpf8z6FXjEdu0dfgpjH7Kh2Ncu+reja2w3ATFZa+vjvW7RLJv80mEHyK5db/j 859ZC+E7EXv+QMANtCwviV90pTgFErVXw2Hczht3Mqt2fVzSf4QswWpsyi+PD2DHkKJ+ t9xWQxVP/s3WN5ZIlrHQk7r5iF3qfSc0FeChCGnNhxikAGdSI+qfkHjGCkFbja+wQ8Jz zlFEWTK0GcDQYmqxDzwRO4Y48dvsvFZs55SHzbjiq1ctfEdaa8HG3a9MoQmg2BAaAav7 tcvQ7JSlY2Cs1LDZ2k7nj2I1kbEGuvOK7wRkcF7zsekSqj6ggmiOdbbq8pm92XGQpeFg DCoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770014180; x=1770618980; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SeWrAZswpltJqdpISuUe09bjU6CqIAWEII1qQkgXJJY=; b=a51Jo/g0AjonMG39nRPG8DxqwYAWosLBfnUYwP+EmhR2wDv3uUKZDxpouR8RS4T3UR dOSa89YOlwFLKRGKe4sDfSVtzCyS08fupGiXRNW3JYI0NiEM0jXKB4RFGqPR5OpMHXOX aysA3V3VqITmNwm2EsgdKS5zt2RklduJu7QtLNC3Aa6wDO+h1WJJvgArVyDydDjUbheE 1osFHMjfR3lJtlLcZsIqFRCmT/M4t0DiB9ZM44G6DTfJKzOwNFuZQXclVWg5I2OY/7BH GOQ4wEl7/H3IL5rPE5LvwIG/MNN2G0Z68K0IBCVbzQAyWU4/TWhxeiVnR5pM28/V9YFe ONzA== X-Forwarded-Encrypted: i=1; AJvYcCWxtKFVDC3x9hSI/C3o7Ha8NmQDtO7S18YmZs6x8XXzYxCCikQMQHLBYs9+pQ/4Lc4oh+y55gu7NHwb7vw=@vger.kernel.org X-Gm-Message-State: AOJu0YzIpqdYT1Oa2ga6Kv95rNaKUIyuev7MjiPf/FbKCFNlgeHRzHLY +yQvW1Gbmk3TkKTb/GQmNVnfDz2AFJNo1RS7YTWIOgJ4rZgx3VkXxzsUNWjn3jJmf+MR7oX6rp6 TpsWIqe6+C+dAePmLqxJe8RapwrenSsDz8IXphhtdRBxBI1ShpCF2vMwKzdvRJOJvqUI= X-Gm-Gg: AZuq6aLhROsSgkr3KOpnm6YnqYb5NIHdUW06hAgtcG82eVpZ3sduAWQqdbBAbuv4Tyr 0TYOry7flGGNKQHXylcXZmbA6f9Nl6hqsgEQtau+tZTvt0IWMz0LGoJVL73TUxu2q+HLMPVkL3d MgKu99rqy4PQi0FdGgArIHcFXuzr/Dqu0phH+drRocJr/dG8i6fiKvUyWE5qGT9FR9qaBcIlYDj VIveKeWP7axl7RaEJqcE9qw9BwCSoJfTvq5PJqTWvSUIVZDatjtvz89r1xFuqWR/qt42NAS3l7K D2KDqK5iaRWgYWK8FzrHxwKdluC9byJa/kknRu4zkJYh9mjTN+on5qxixynAXinz9fCsOe5XVuB gFo+UdLS5RRm8EJlKcH2tBccp/hsowLZdRTpP2+kQmEuImcw= X-Received: by 2002:a05:6a20:cfaf:b0:366:14af:9bd8 with SMTP id adf61e73a8af0-392e01b362amr9962845637.78.1770014179624; Sun, 01 Feb 2026 22:36:19 -0800 (PST) X-Received: by 2002:a05:6a20:cfaf:b0:366:14af:9bd8 with SMTP id adf61e73a8af0-392e01b362amr9962821637.78.1770014179151; Sun, 01 Feb 2026 22:36:19 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c642846888fsm13626274a12.16.2026.02.01.22.36.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Feb 2026 22:36:18 -0800 (PST) Date: Mon, 2 Feb 2026 12:06:12 +0530 From: Abhinaba Rakshit To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 0/4] Enable ICE clock scaling Message-ID: References: <20260128-enable-ufs-ice-clock-scaling-v4-0-260141e8fce6@oss.qualcomm.com> <7b219a50-6971-4a0c-a465-418f8abd5556@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7b219a50-6971-4a0c-a465-418f8abd5556@oss.qualcomm.com> X-Proofpoint-ORIG-GUID: DI-ko0M8wBbURnI990n_E54VOMVGMenD X-Proofpoint-GUID: DI-ko0M8wBbURnI990n_E54VOMVGMenD X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA1NSBTYWx0ZWRfX1iRtVYoTuQSf YuCHGO2oUEeAeDmOgVc33XS7P/T5LUpRzoz1RRELJvaOdmglQhpc8RAW7UeQmqp8XFWi3CQo7n5 keNRuLsBmKT+mY8M8ncjByfIZ3Y2BiU7sBSNujiv98eT3i+FZB9OHqLSGum7ybV+M6tldA1J9WR /FgYNdaAuVfjCtT5SCACI54n0XXikI0x3hDQQDTmjsPMjl9KJ0M3fI0jWbAUuxSxuWVVoMFWloA 5OLg2qFVXvT6ThBnxtbQfYfM+6sFHkL6fCd5KlD3tZg7h9xCe9WMKu+3NmL+EO5YFwnYPdz5q/q txEiO0AkufxKIfdpeZUsJzonw7A8fWO7gR7NI+f31OIgSbgJslV8T2R+iCgilIcvRC/ndVLeUl4 q4NOzLiGp8XqK2YiBYHoYcENGgUIDFAaUXulJ2IHeF2VgcM24PAEeydwdVor60SXBj76gvcOdDF 3+F+6EPFGyFTlbdcN+g== X-Authority-Analysis: v=2.4 cv=bIEb4f+Z c=1 sm=1 tr=0 ts=698045e4 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=OguJ8merRGVtADoZ0hMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_02,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 clxscore=1015 suspectscore=0 bulkscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020055 On Thu, Jan 29, 2026 at 01:17:51PM +0100, Konrad Dybcio wrote: > On 1/28/26 9:46 AM, Abhinaba Rakshit wrote: > > Introduce support for dynamic clock scaling of the ICE (Inline Crypto Engine) > > using the OPP framework. During ICE device probe, the driver now attempts to > > parse an optional OPP table from the ICE-specific device tree node to > > determine minimum and maximum supported frequencies for DVFS-aware operations. > > API qcom_ice_scale_clk is exposed by ICE driver and is invoked by UFS host > > controller driver in response to clock scaling requests, ensuring coordination > > between ICE and host controller. > > > > For MMC controllers that do not support clock scaling, the ICE clock frequency > > is kept aligned with the MMC controller’s clock rate (TURBO) to ensure > > consistent operation. > > You skipped that bit, so I had to do a little digging.. > > This paragraph sounds scary on the surface, as leaving a TURBO vote hanging > would absolutely wreck the power/thermal profile of a running device, > however sdhci-msm's autosuspend functions quiesce the ICE by calling > qcom_ice_suspend() > > I think you're missing a dev_pm_opp_set(dev, NULL) or so in that function > and a mirrored restore in _resume Thanks for pointing this out, its an important piece which is missed. We can use dev_pm_opp_set_rate(dev, 0/min_freq) in _suspend and restore the suspended frequency in the _resume. Something similar which is used by sdhci-msm.