From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 629D7261593 for ; Mon, 2 Feb 2026 08:36:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770021361; cv=none; b=ZVnifruuOjTJUnC+Hddj5RcfjAFcZtTIa+FTNcLWv9jzbxwgPJ4d7i6SfrQsifiuBn7B21VjT0vbbWLhlVbe4qzVbjuGxHjBu02Ig6ktick5Ci/eSvipOkuNmt6J6EB3vudgzJ50wTkh+oSRcJMMXq6FDdmLtP7hTH64a8EeEF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770021361; c=relaxed/simple; bh=bFK8hFfh52GXzblS1wDcEuJOY1t7IatvC8umODmXQlA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FNgDW2lRWB0nSZqsVc8MSjsMdfA4S6++tRApyhboyso2WMc/iPRqpczhyZ5I/eYjAlirSd3AtA8JyUEb2lUxZsczDGGkWWZtUh/+vt9e0h4esT9kdSOyE+yLrHK7B+efO4vndA3yhDc/0rOYkM9bFxBZhuY7EKtbHo6JEnmJnzo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=c0mVstJ2; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c0mVstJ2" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-4359a316d89so3129297f8f.0 for ; Mon, 02 Feb 2026 00:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770021359; x=1770626159; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VRWMpqnWk+tTgP9S44SDSmGmyzdMBAQmlJJaZ+BHavU=; b=c0mVstJ2WdRu/a2BQjI3NQ1H6+P70lpxTNwJ0GTNIFI4tyvfyvKbNotYMCNGnC2lHb GFo3Qz54SWYe7ncUSRD+JcLJIFLFP3Dgb3gv/ZROPEcmcgR49kWoznH2RjREKhRRB+ho nr7x+7UntoUnWZEnoHB/NY65jsu/HTuM45+D8N8Z6NFeq5isvqeGO4QLBv/qBNW9f+ZB zlY0gba0mT4k40O1Z6mXG71DM5u3W8ZXWoNAarmlEZG/SeGu5QNBRQbiyVVpSyiW6sG7 2cOJiCcjUK/XD1uiCsl0ZcP16+c6S5MJhu9mYmgbMpi/Q66tqSE8MFJ9LsBvGm/goe5F i6vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770021359; x=1770626159; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VRWMpqnWk+tTgP9S44SDSmGmyzdMBAQmlJJaZ+BHavU=; b=ciIInTVjWY9Hb/gQC0kZFCR4SRLfLZu/q5BoRWl8aPg4d3m3+elYpcjyWQp/oZ7XJs b2CKJofN9p1GlJW91zoJmTi2wVMLa6OpbmAf5M4cTAyDeunzC8Qb4mlBsLRJuH/CDTtM uAVrGIA6NzH6z7A3GjsKFnPLqS+JIn8OPykRkWCtarrAcNv7APQiunmuHp60aPeQeZjI 3UUOYbaVFcTi7b8nc+UVWAzr6aOHrQaE438GzZNThd9ZYvBOsoJqPBncuSXBGWXAaLgY Irm4FHmb/8EYYhd3MXRIc5+HuMtTsa60ApEoyqPGtuY0yN6phA8qwv9zkGrtCuQXMLvD +AHQ== X-Forwarded-Encrypted: i=1; AJvYcCUCmT5SJWwLU3ZX7XBHbI2Aqtaq4iB3uqG3uqzx8kANkYvVGb03Sf2RGjbHz0dxB3DeJXzhAavHse8isLc=@vger.kernel.org X-Gm-Message-State: AOJu0YzRmCDlzSlBNwsdyXKggRycLC9KR6+YTzZ90uERQXOsmEsTRK/z JO2QlkAK8RenhfWlr22AQnY8dsU1GDEckzIBEchpVcOSnG836aowcieZmkaWUVDrv1Q= X-Gm-Gg: AZuq6aK35711Y+vg1HUsCZXeHPZQFdRS5IVi4i/cy5XAoJH2AdA171chRZyyVQmO21R iSxohrUf3nHiJp9B/pDrwmJQB2NtyfX4wgutoYNMKdDa9NiqxvRJkDjkTgg73mqfMyTBeQ1Ggnn LX+1ci+iwEkpZ2Q6L5tvhwchvgTD0DB7W4XsanjwpNtt7VdZD1Nwq87eP4zB35+nDP/zPpVGGc4 D4mCGnhAEUqAqfcO381/tXkWjFiKG5IYKjRA7x/DaFQtxritzzObhOelZOEV37gi1tz8Nz399pb 2FJsr2uCTs2iHG236+ywfP++aWEaKVwXG5KecCFK853FOpBL1UmS+cPAvUQNrgbngUdQZhbNxed 0zmgEz6pjwKKP5GgbQQgEFtGbCDakEMqnaUCKj5Xzazw9F568lCdhqbdYr4KxZ33mYasNwg7oKP fIGTiEghKePCsbgLNt06dB7dzJL0o= X-Received: by 2002:a05:6000:604:b0:42f:ba58:6599 with SMTP id ffacd0b85a97d-435f3aa7b4amr15547903f8f.35.1770021358614; Mon, 02 Feb 2026 00:35:58 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e10ee078sm42434054f8f.16.2026.02.02.00.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 00:35:58 -0800 (PST) Date: Mon, 2 Feb 2026 11:35:55 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: Greg Kroah-Hartman , Michael Straube , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5] staging: rtl8723bs: remove unused private debug counters Message-ID: References: <20260131212128.25548-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260131212128.25548-1-ethantidmore06@gmail.com> On Sat, Jan 31, 2026 at 03:21:28PM -0600, Ethan Tidmore wrote: > The driver maintains a private `struct debug_priv` embedded within > `struct dvobj_priv` to track various error counters (e.g., suspend > errors, alloc failures, RX drops). > > These counters are incremented in various files but the data is > never read or exposed to userspace. > > Remove the unused `debug_priv` structure definition, the instance > in `dvobj_priv`, and all associated increment operations across > the driver to clean up the code. > > This also removes the following helper functions which were used > solely to update these counters: > - rtw_reset_rx_info() > - recv_indicatepkts_pkt_loss_cnt() > > Signed-off-by: Ethan Tidmore > --- LGTM. Reviewed-by: Dan Carpenter regards, dan carpenter