From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8240027145F for ; Mon, 2 Feb 2026 08:38:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770021494; cv=none; b=FtVmAoBcaRUjGNrRMKJRWlCRLQhVfI4ZJ1JSljZyOSH0t9UspH6x6W87Hpxj2TxkYo+NH6E20AIV2v8BxZOQVcpZgL57iwzZwyk+xfWNlok5aVtumxNK9FgQ1M8uQwsNhmq3NPsQGPqYHPWoU6SRkEh95UJsCTk+indOraa+3Ok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770021494; c=relaxed/simple; bh=+fmzMPeUWacPPRF3LvbYKkeMsNR3Q87Kspg2bI3U8yI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=n1I2Q2lUZW46TXgwfH3fwOjikbyi9woSBw+v98lz9snzl4exNL5SRH3EGc9F5EWNEqLWU6mxiJ6qc4LsHNiSijkQVVi/Ak8knW2N5SvVYYQDaNatp5S5jaVBkPz7KCpMIPyOJ08iK25KMsR9NAgbf4fzKaSqPy/6Y/sFjEycr0g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Rq4IwYdU; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Rq4IwYdU" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-4801c2fae63so30585835e9.2 for ; Mon, 02 Feb 2026 00:38:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770021491; x=1770626291; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l1RUynbe4rR3Ig0UQ0DktCKbiavjUNRPlOk68dYYI2Y=; b=Rq4IwYdUaZZRQt5sQXnVH1CbPjR13OCr3rvyXdLBYIpyLuFtkWMmTmqxdSUfDlRgWZ T03Rd40MjdYs7h/9LM0eXY85HPsS8fypUE+rWagZXT1719D2G+Sww7cXoqhyAuPhog8K nrSbG74e5JAn05jZR25lqL/JekalQSasKsQ1RX6s5wVcxv4cVstHTm6KferiexaLmpYz 4382pdPCjPGbZx6/Ls83//4dq83nvshcBgPuFd7Dk4hcfQUY5Zq42k/PCDaqt3AhAt/p HqFkH+JG8QFH5IhBIsHtL7QoYnlKaIrlpvd7LXlMJ6kZ5gFI+7R8gIenxNvplhVgDgWA Jihg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770021491; x=1770626291; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l1RUynbe4rR3Ig0UQ0DktCKbiavjUNRPlOk68dYYI2Y=; b=MxmJsShJDsZnB+aNlFmGISqq0phTF0s07KrYcUKVd+0EKmYFLYN+ZuBK9iW6ImHXHY orRlDS35nAqA1j+KZip/vjYZgh8nvFLgFwa7nBu6OSGn3imNWqbMSLDyPZfITkwj2bzC h+Nlqg6qbrFmW9gLNuFWN9oBcSPJTrZE0xYVuLKU6q/B9jqXl/jh8uKLav9/zIo0seDR lTFlAre5zdqTM8IwMlrFWcTYrMalsIEjH9L8xeOl+bU0SH96PsnOBPF7AI2BevPTcHow qdzErchTCQEzLpW9k+9ehxGpgrs3siyFXGhJU3bKRS8x/RSx5qdrUQCsJH+3PDaozBkt xl+A== X-Forwarded-Encrypted: i=1; AJvYcCUSjTb5ElJOjxBPGuw525CwSzhFByZ0T1rBHTCLgIlal3ED6I7dAKsiXDXP0oooqfZPtMkxy0pY1dHv6lw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywh+9UT+ege2VUKV4WEm5zZenpW52++5fIyKKPZhsaTWvTNtpjx yfeqkNMqXdVAmN1glq/nMfkV22AMS/79syf5Rx1xw3x0zaGkwVNRMWSrbbKLAWSqQlc= X-Gm-Gg: AZuq6aLF+gSSlOH1qcC4F86VTHIMV69xFi5PQsoOo3q9QM65gRrY/kyBVx/Kwer3dvK 4UyZYuVtvy093UnisyJvtFCNisyIpAjb9/h7eiL6hj7PzPNmvaXGMsXbQwNnn+EuQ3s7FKvQRoo jk0cqZmY9p34pHtZfrLNfXJg3WnxBnV8nlNYxi/YftGV/F3Ux3divaUPtzTEEDP9FBT544jdV1L PYvR2bkaq+tSXLgTDvkWWDCLTLdDlCDUBNjaqc0L/ftvmtMVvvphb9jtb0hKUIhF0W3Z1vtctM4 rnW1a4mxXk/BMfbCXbV4IBqonMQ1n5mjPzT+5BSF0Uei2D24E07Sr/AyeRpXz5OpcYKhAUZWcMz gZ9YSWE6nGwJwmpiDIHekp9Q92SYOrMkmS1GceoMH/U59+w+zU9eIEby4Rr20dQ/Yf87hbNzJUI hZZZbBZKrUhKyk2tI1 X-Received: by 2002:a05:600c:34c4:b0:480:52fd:d2e4 with SMTP id 5b1f17b1804b1-482db012dd7mr143262185e9.0.1770021490711; Mon, 02 Feb 2026 00:38:10 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-482e267b699sm85202545e9.16.2026.02.02.00.38.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 00:38:10 -0800 (PST) Date: Mon, 2 Feb 2026 11:38:07 +0300 From: Dan Carpenter To: Ethan Tidmore Cc: gregkh@linuxfoundation.org, straube.linux@gmail.com, hansg@kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v1] staging: rtl8723bs: fix null dereference in find_network Message-ID: References: <20260202063808.664468-1-ethantidmore06@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260202063808.664468-1-ethantidmore06@gmail.com> On Mon, Feb 02, 2026 at 12:38:08AM -0600, Ethan Tidmore wrote: > The pwlan variable has the possibility of returning NULL and is not > checked for NULL and then later dereferenced. > > Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver") > Cc: stable@vger.kernel.org > Signed-off-by: Ethan Tidmore > --- > drivers/staging/rtl8723bs/core/rtw_mlme.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c > index f81a29cd6a78..29dd0b56223a 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c > @@ -835,8 +835,11 @@ static void find_network(struct adapter *adapter) > struct wlan_network *tgt_network = &pmlmepriv->cur_network; > > pwlan = rtw_find_network(&pmlmepriv->scanned_queue, tgt_network->network.mac_address); > - if (pwlan) > - pwlan->fixed = false; > + Delete this blank line. regards, dan carpenter > + if (!pwlan) > + return; > + > + pwlan->fixed = false; > > if (check_fwstate(pmlmepriv, WIFI_ADHOC_MASTER_STATE) && > (adapter->stapriv.asoc_sta_count == 1)) > -- > 2.52.0 >