From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4394F33A9DE for ; Mon, 2 Feb 2026 09:04:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770023042; cv=none; b=rbqF5E734zhl7IF5e1a2GPyCuQDZTlK42pC18Ch5Cu3u6YraA/e2NI0Xi68+D/nja0fIR6AjVSkay0g/0Okf6+36jtDnMFe4C8UqojxaacXjIJNdPGf6QRajWx/iZjqD8faPqrAsrwwjHQTt3cwR7h4xU2zI5G1252JdPKQ3XF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770023042; c=relaxed/simple; bh=jDKSJSF9/oechGiOGtaqDX1j6Tao8GqPkC6BaMo3iS4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YIRBY38OMM5vg3fW6VD6Hf1JuvG+c7yCFJQaZB9Ee/iuEEw5tBPI4q6OTZnqvune0UIY1NWUr/y3mLIHlqU8cSRwSCTdPRp9vvkOm7r/AsUHubCB/GZ7bLtSFRjzyM4qlVuF04SMfyTwY7AyKuRUy4pNrJkFrnZs23MaDm+BP+I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=idUnOdAl; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="idUnOdAl" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-432755545fcso2557612f8f.1 for ; Mon, 02 Feb 2026 01:04:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770023039; x=1770627839; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=RrIc2TAtNpNyr4ETSBvv89e2CI1YN9c4ahAZ1ROo12c=; b=idUnOdAlsbUXJ4Qb4jaNax/7WL0YXlyw17mEROMMFjftSClXP3QSVDCOw1E8N235En 5qPX+PW2KzluO4aOqWDFBHkcBcepID7rSRrvb5yfuHWMGDj9F+t7c3ubV5YM0CKYb85O 4ch5mgctGDyKSYevrgF/I0uARYuy07bNxInNCkC54yTHtv8rvwPfz70siTGBe431MKGe TcGOJrZdzd84EWkbalshW4ieb4lqB1E5uzTYLuKc1TV2thomuushXXWNmOm6M3C1PXTe s4CNlsVo4Sa8EBsvKOHMGbngTPkZrVuFADbaGjg5juhDerQkEjI9RSwIQ/2gNPRmEN44 cTqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770023039; x=1770627839; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RrIc2TAtNpNyr4ETSBvv89e2CI1YN9c4ahAZ1ROo12c=; b=RgdXcqMWtLDNE2IK3pdj8SjKOj8GRPZMTkXEUQiAF17lVGy+VzAAMJXfclCmtEd5mb t7BWpTLxScvKp6NTYNWaVBiZp2mdLRbWn1Ut6oztgwnXhUpilfcB/EFty7qN40HjUnCo xLGNvmH8BapLkA9xTkjqaxUOC74yvAxUaZK5yIijUX0oIytd6Jy7fj0f6vHjgxubWFrw x5HGPnIBOpMZDAivbgGChbnzhq2bg2k9FoVG6o5HPpwtdFJh4AhsY4l5XHizdqywiZ0E p+vueIYHJf9oAZR5Kta7PH1g4pYe+yBSlYd70+7bhgGAvGom4fc1dMZ02Yzu1u1k46Vq iOrQ== X-Forwarded-Encrypted: i=1; AJvYcCV7qvK68qmNByR5mARTB4Lz26U4ktRX5iIY/9GyTl0rLajC9MXH9dRQzwO9PWZMtJWZ5fpqN8zxzGnFi04=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3Zl3/ZJvXwn/G+kvRFDKiVdik6ePWFs+jR+Uc2HtTJpZM3MJ0 twlId3pan+Ep7N5834Jrmp+QqqJXVOQQzZanTpeRHY5r64DmuFanTu/yWbfFbqnzDVM= X-Gm-Gg: AZuq6aIlpNBDDBHJlvDUpKFc3f+Xw4nmEHbrSlsprTOxjC0Tdjd4Sb6/a0XaPumBx2q MWiPrE0CZNqYINBanbHOWFsoclxIUiWKwZ6mjddkhtD00DXscLJws3mJkmm6Am4r0VRl12ZHV+8 SNPs6eoP59E7WGXJ0kAhkk1PmiQbKv86+UyMu23s94Z9D9/CaX39v92WHR78R8ooJTnk034k8sB 5SJthUBqp1OtknDBDwIIGEFTzIvlwTSMbzkDzeVUlWCi5vJXolppmJZMD/TlJ/ZsX8uzUP5woMf 5ZwqIsdZt08zCrnCP/cgzmMEOk2rI6WtlKZKy/F7oPcrAyklhGjM+44DjUvQfPJmuZRhnzkxGQg 7o9EwGzRSN2br8wnsy9bFD+N3dvunOSJkxmJL5Wj3jN0NjKXujmTwB1gVg9szk5eD4n0rlHo+BP mf3zYl89FCDLKO2gbG X-Received: by 2002:a05:6000:230e:b0:435:91b8:e01b with SMTP id ffacd0b85a97d-435f3aafcebmr14978171f8f.45.1770023039510; Mon, 02 Feb 2026 01:03:59 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e1322dc7sm43062271f8f.37.2026.02.02.01.03.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 01:03:59 -0800 (PST) Date: Mon, 2 Feb 2026 12:03:55 +0300 From: Dan Carpenter To: Bera =?iso-8859-1?B?Wfx6bPw=?= Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8723bs: refactor ODM_SetIQCbyRFpath to reduce duplication Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sun, Feb 01, 2026 at 04:27:33PM +0300, Bera Yüzlü wrote: > diff --git a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c > index 34692cca33f5..bd535f774852 100644 > --- a/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c > +++ b/drivers/staging/rtl8723bs/hal/HalPhyRf_8723B.c > @@ -1074,10 +1074,17 @@ static void _PHY_PathBFillIQKMatrix8723B( > /* */ > /* MP Already declare in odm.c */ > > +/* Helper */ ^^^^^^^^^^^^ Is this an AI patch? I really am starting to despise AI. > +static inline void set_iqc(struct dm_odm_t *Odm, u32 *table) > +{ > + PHY_SetBBReg(Odm->Adapter, table[KEY], bMaskDWord, table[VAL]); > +} > + > void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32 RFpath) > { > > struct odm_rf_cal_t *pRFCalibrateInfo = &pDM_Odm->RFCalibrateInfo; > + u8 path; > > if ( > (pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][VAL] != 0x0) && > @@ -1085,23 +1092,15 @@ void ODM_SetIQCbyRFpath(struct dm_odm_t *pDM_Odm, u32 RFpath) > (pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC80][VAL] != 0x0) && > (pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][VAL] != 0x0) > ) { > - if (RFpath) { /* S1: RFpath = 0, S0:RFpath = 1 */ > - /* S0 TX IQC */ > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC94][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC94][VAL]); > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC80][VAL]); > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC4C][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S0][IDX_0xC4C][VAL]); > - /* S0 RX IQC */ > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xC14][VAL]); > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S0][IDX_0xCA0][VAL]); > - } else { > - /* S1 TX IQC */ > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC94][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC94][VAL]); > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC80][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC80][VAL]); > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC4C][KEY], bMaskDWord, pRFCalibrateInfo->TxIQC_8723B[PATH_S1][IDX_0xC4C][VAL]); > - /* S1 RX IQC */ > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xC14][VAL]); > - PHY_SetBBReg(pDM_Odm->Adapter, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xCA0][KEY], bMaskDWord, pRFCalibrateInfo->RxIQC_8723B[PATH_S1][IDX_0xCA0][VAL]); > - } > + path = RFpath ? PATH_S0 : PATH_S1; /* S1: RFpath = 0, S0:RFpath = 1 */ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This comment came from the original code but it's junk. I guess the comment is trying to explain that S0 is one and s1 is zero? Ugh... Why? Anyway, just delete the comment because it's useless. regards, dan carpenter > + > + /* TX IQC */ > + set_iqc(pDM_Odm, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC94]); > + set_iqc(pDM_Odm, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC80]); > + set_iqc(pDM_Odm, pRFCalibrateInfo->TxIQC_8723B[path][IDX_0xC4C]); > + /* RX IQC */ > + set_iqc(pDM_Odm, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xC14]); > + set_iqc(pDM_Odm, pRFCalibrateInfo->RxIQC_8723B[path][IDX_0xCA0]); > } > } > > -- > 2.43.0 >