From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 082AC4A21 for ; Mon, 2 Feb 2026 09:33:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770024828; cv=none; b=CNElkVUFT+8nJtS0k5GafRPEFXN/211bhDq3uAcoBB0vlrxxXQqqyrZ3G77ZgmYeJsAzrpTsTsMHH+H6xzRt3o5ChfuNs38m5U/2aY6DOf/8hRUB1E9ouByR4QhN16c8ykk/TbARkNxaZIc2QQxjJ65MyTL6h2rulWO5yAjQOLI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770024828; c=relaxed/simple; bh=unPEm+1NIuStqMpaoStpa+gtyzS7uVlA6g5lUzFR8+c=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oOntkrTxCjuyKCyswnxYSLUYxKCq5VkCVkhJObR+mztR30oBuva19wTtKOvPXFvHgRh+zmyYiIGMFHv0gz5fk6FU27jgBoW/x3x3HENpL+oSDEiCBFDvMulGxOdYxAnSB7RhioR/AOLqtF5fZEqPmglCOvaE+byZyvZ9VeswLaY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Hl3Huccn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GGtvUyzY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Hl3Huccn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GGtvUyzY" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6127RZjr1106577 for ; Mon, 2 Feb 2026 09:33:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=gJHUyMi6ir8MaZUDuIcqes/3 jjyrEWI6G8BBp7lKnpE=; b=Hl3HuccnZ9mJUs/r4VlQZnnsosIAWNfR2vQHiS+/ 8n/D/M2wTxSe4A9Og319ZFJrlavT3UzMSVA9T4KgIhbepGaOTDYYNo4bHHm/HoHA YefCr6YKsDGtjRSjEcieIzCRAZvS9F7xi4I+8KhCqRqLKNmnWubEKBTEdCm0fe1f OL8Z3D33FxT/TQyWXLgSWMnX7zUoPvnnUjBX0S/YZbZ/r6YIYP2Ar7F6zNAIf0QX khNC+mpvtkNHs5PdqNa6mQGtBFRds2W/4u+E/yzRO1OK3QEnB0oMN5/BCknFLCns hbdEA8QSY4TxRMT8nPsdokwRZ2b5xYqy7LdUDBqSMAwuVA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c1as0vw8p-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Feb 2026 09:33:45 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a07fa318fdso44315965ad.0 for ; Mon, 02 Feb 2026 01:33:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770024824; x=1770629624; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gJHUyMi6ir8MaZUDuIcqes/3jjyrEWI6G8BBp7lKnpE=; b=GGtvUyzYI7Vd+rMT360OrD+AnnJl3Caywsio+S267wzXKcnqjEPY+r0oczONwRqZ7V nTSdhbfzLZDwl9w5I94x1b2q5ToLABxVmhPGggbgYoE6J4A7I9Enmie9Gt/p9U0FqEpX iuPMD2FHRPmoovL+SqIpk8jOGhasf3lI1zobUId1RQ++OQrYf9ulYO3Wsp//+y3uHXll JfqcazVgNzoSpTBDDb5DsfTZS7WobqtL3lu6cA9fFnsLUrM+1wA3GeB1yzShclW7x5N1 IqHGSOrqSqbSCyOOr/s7P05gdsX+76pevJFjM6LbRkhz/8MmmrAuQA3iGtsEVVpdadUt cymg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770024824; x=1770629624; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gJHUyMi6ir8MaZUDuIcqes/3jjyrEWI6G8BBp7lKnpE=; b=nTeW4Fh2dj3i1Xv7gRmJTERmLgfUg9v+wmReUg0kHYYR920M2A15+hx0wrG+EVQEpU fuJV/WJhWxo+/A7Tqz8GRCY+JqsClTMBVKswKFdgMh3bP/6NSThoK+zx9gGZveIvfmcZ Bzgizb6HQiBbain5yv0DgitYUNh6k633w5YfsNoamKQvxZiPtIwu7p8h2KHK+b+lktKf KhQmislT+I1M0Mc9tZ+zX7ZvzaPyCStFEViS7vuQI06qQ/4sgqDtelfimOyq0K48Sv73 rTuOIfwh+EXyZHkYnfobcu+o1+VmvTbXmWIehWrbKztLqAA6fi3wjVOAaYjFQft9p3Vx YdoA== X-Forwarded-Encrypted: i=1; AJvYcCXDKq/OVuxxB9KK5ieT7pI2/UlfS5Yt98PGoTFPzetr/WGEMHWLkBrvlhto/6PxFs5LxmVi/XajIug79lc=@vger.kernel.org X-Gm-Message-State: AOJu0Yybuk1KWWwYlPEg3Q2ew0rCVIgt/YeYWtZx5U4kOzAuhn9TOslJ GwOD4wYg6JUPhoQufSMoad+Kl7ZMuf3QOyyrkIw3QvPU94yRsDygioY2STpHrmromCke3FFcAYD 09f+5SrUoq2TXNBzecHuDeAdRyiY3lbete/xmYCiysm+Ovl841FOrtVL3mU4+B530hzo= X-Gm-Gg: AZuq6aKPMCmucwCYGGfgYZQp3T0HgptgcA6BaPmFsDJ0V6cHci57rI3IXuqaglpwTF1 /H7uivu1QyIiByFpdlu+dnoqLzDIkonU63qGzd42mKDFOtS6vAjqIS2DW9aIGjPzLl53v7+Uxnp yTGh094VVobifTod5Hr4Xe1+Wv6cpfD9kat0fv28aghcIdOnjXS84HyO9z4sGQOwWU726SQmzAp qCVntGFVjfw6MrbAG6CPP/xTEIikqZfu3OuS225KJbvXCmjnTrbiHaTQwHQzZGI+Y4h9u0Y4cIA FU7rRq6agIwIH0S/cPK4op5fvWgngzXyQ8Mf9tD7Ku0TAlIXe0AbtrhxjTFwNplCVqrU6Tok7Oe WSfn4YqAZLqN469CqWunzWQw9oAdNiSt2zef+FWcYyANP5Jk= X-Received: by 2002:a17:903:1a83:b0:2a7:87c0:2357 with SMTP id d9443c01a7336-2a8d96b18f9mr124758695ad.20.1770024824519; Mon, 02 Feb 2026 01:33:44 -0800 (PST) X-Received: by 2002:a17:903:1a83:b0:2a7:87c0:2357 with SMTP id d9443c01a7336-2a8d96b18f9mr124758425ad.20.1770024824050; Mon, 02 Feb 2026 01:33:44 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b414f1esm139990075ad.24.2026.02.02.01.33.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 01:33:43 -0800 (PST) Date: Mon, 2 Feb 2026 15:03:36 +0530 From: Abhinaba Rakshit To: Konrad Dybcio Cc: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 2/4] soc: qcom: ice: Add OPP-based clock scaling support for ICE Message-ID: References: <20260128-enable-ufs-ice-clock-scaling-v4-0-260141e8fce6@oss.qualcomm.com> <20260128-enable-ufs-ice-clock-scaling-v4-2-260141e8fce6@oss.qualcomm.com> <20260128-daft-seriema-of-promotion-c50eb5@quoll> <13e311fb-1298-422c-8859-1b08201743ab@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <13e311fb-1298-422c-8859-1b08201743ab@oss.qualcomm.com> X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAyMDA4MiBTYWx0ZWRfX1MDg4GoEmTRJ Aw+mE7zv2uq0ua8e0Q5u5sqHZ031qGoFvaIpis5OC4ZQ2fx9owYhoDy2COrWXNekaKNtDmrW0BR NwuTM6ryRApUOJH2rb2RIeg+eQFTI4BkbtzzTXOvUNJod3VpVTsMPWLQwU2i73vSHdwpR9bPAkq YQvbqceFvc1MkfZVM4Yt4NhRxV5l6RPao//ajWudPHYsVQe9GlWkrSb8/oLtnEhl5cOnV2yJmX2 HL0+J6hPPLneeaBGc0wbM1I/m3lnZhNR8AKW/fubMS15gzjSbPt2yrAj04w3LrEljrrNR6R0odb nGq8/0T8bWonTV7DCEBa0OGYpT3mc+bVYgFBGgvvxK3TjvUCXzonUwUkCLAvG6ej2IVjDFdNWK+ 2wjer283kNiN7YI5YJckVGRgznNBJRTqKusBXEyFQxzOml7IB6u9Jpyvrn48OYJs3i14ZFh3ya3 Rom2W8qSRxGfZFO/Q+A== X-Proofpoint-ORIG-GUID: ZCUu-fHMp8ZARFZCN0l__xbyrZZhyafM X-Proofpoint-GUID: ZCUu-fHMp8ZARFZCN0l__xbyrZZhyafM X-Authority-Analysis: v=2.4 cv=MYthep/f c=1 sm=1 tr=0 ts=69806f79 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=L9uGvZmjxWfCn8EH7uIA:9 a=CjuIK1q_8ugA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-02_03,2026-01-30_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 adultscore=0 impostorscore=0 suspectscore=0 clxscore=1015 bulkscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602020082 On Mon, Feb 02, 2026 at 10:23:43AM +0100, Konrad Dybcio wrote: > On 2/2/26 7:32 AM, Abhinaba Rakshit wrote: > > On Wed, Jan 28, 2026 at 12:04:26PM +0100, Krzysztof Kozlowski wrote: > >> On Wed, Jan 28, 2026 at 02:16:41PM +0530, Abhinaba Rakshit wrote: > >>> struct qcom_ice *engine; > >>> + struct dev_pm_opp *opp; > >>> + int err; > >>> + unsigned long rate; > >>> > >>> if (!qcom_scm_is_available()) > >>> return ERR_PTR(-EPROBE_DEFER); > >>> @@ -584,6 +651,46 @@ static struct qcom_ice *qcom_ice_create(struct device *dev, > >>> if (IS_ERR(engine->core_clk)) > >>> return ERR_CAST(engine->core_clk); > >>> > >>> + /* Register the OPP table only when ICE is described as a standalone > >> > >> This is not netdev... > > > > Okay, if I understand it correct, its not conventional to use of_device_is_compatible > > outside netdev subsystem. Will update as mentioned below. > > In Linux > > /* > * This style of comments is generally preferred > > unless > > /* You're contributing to netdev for weird legacy reasons > * that nobody seems to understand I see. Thanks for correcting me. Will keep this in mind while submitting subsequent patches.