From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B634D3033FB for ; Mon, 2 Feb 2026 20:01:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770062506; cv=none; b=cjyil2+eBHhZo5YE5tbFrZcqznLMBt8Bke7E99Ng3hHFOcrP1mXyEN4kYHUa6x8W8f2PVEQzSHQy/ZlmZNlRpOh6yOkCdvqcS6jn0ok2HpJ26f7+3S88ZGn/2mCXHyqBIFfXxk8Sr2rLzERna0aKQBeaT3rH/uMVAszWxcPy6Ro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770062506; c=relaxed/simple; bh=jNgUwMtK2RUmQMG3k47FK/HbS0lmCnI74aV7EWKk8EM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KTnhNdsW9GalaSnlEzgROn14WgK2JytsZZDOEHr+QiMV11Wpuqs011JQH+WxgYuP/GVz7ITq1rhHJZGu56vo1Lm4oIloh1/8bhAYvmTK83PuXgB/npN4hOxrhl7T9KBjQf1EAWDZlPXe+Z81HT7svshXnTfDkitIynZgU10kUKg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AwZRDuGQ; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AwZRDuGQ" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4806f80cac9so25608935e9.1 for ; Mon, 02 Feb 2026 12:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770062503; x=1770667303; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4hGFAoXoGcmWys+uUjHRPMoq6GYRS4Iplih/Yjd1Z5o=; b=AwZRDuGQxjgtd0EejypW9eBFg+I172zVLyDdHnrWjwu2P6pr9HJLEv0crWNIwaA3Tw mQPB5zUygKHQXBpK/uWnpqMRi+lB6kGdSR4jdUr6odCjT7lnG/CugHKOGOkprjCCj0kP D/8kTU1geAy/iyRmALdl/BmQd2E/eZmOr05MrcfAvRdTa8gvd4xb/B1p8A6uhv9BSx67 wDhf65U8yXojpH8KyhsYvofkpzi4wxbwCFxyVVK3mE/Ow3cV8W/2kSRZGPSDy5MRSfsb z8fMbor2oQRQvJZ6+RHQEGsuBV5XvSN2n6wKCE+bNQUTAtD3lXJIeDfy04qcAcG4H9ub 09BA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770062503; x=1770667303; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4hGFAoXoGcmWys+uUjHRPMoq6GYRS4Iplih/Yjd1Z5o=; b=CisNQdafASj7/waYSbeKfytWahESMt7dMPtTEUZ8StGfq9g/8r+DDEyH/H3OZxQmm2 Q8XArfnQyMf5L5j+ex1PEWrZAISBNJibt03UK5hbwwk+jegMINu+B+Lco1uWmUPpvzIJ dOwiMWxKgN7XnZJme5sbPjEdNuWgS1s3VaMlayzM/RE7rtpx0Rde2wcJqe1hNdZ3lZYP U5JeIJXlvT+HOdELpJX6dAFH5MnB0Xb3ynFUL7kPnSh7G0hzNOCex5W4r4rnL0DpWAtg CpU/M3ken3Y+tGdKedhw+OVfWhXf0V9Xju6vonv/z5Y0AEku6gV1MXtGjOpqqzYdCZQ6 O5tQ== X-Forwarded-Encrypted: i=1; AJvYcCU0DxwX5h7Y6gWWa9NTuBqeHPPTicJYL16gmUEAYva9Et4TvmB04uJUwrZwU1Ik9FR/HJGC0HBnFeZY/Yw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0y791+iis6OHoRXgMS835txCt0PWYLDKn7uhTMXjE35tt/oox 3qReKBrCWS4oRGMmf5lHJYsijihumaUSs/JSHUnzw3yCBWYS5em8KyXUV3CxNXuxYjw= X-Gm-Gg: AZuq6aKjhFL/oDbGd1uBXJQetUtk7ASHDFZV3+rDeSv5H2/K3BKGYyDcJ6M5+MJGY5s 7h/dpB96n94ia9iBnzCMJj6x6a1hNNZas+WO9Jo8NyVlE+/XYxhLjMj68SPervMTzCEIDrozSn4 xekrrFs5OfXzWA7QRxMbIwihTyuMqOq3TWujom99kjWkFwOfCLEob3FHpiaCNesll2USS4CRYQS 2ukAXPO9QFrEZFNnkylNhiLaI8BIl3g4ZBNrsCkBobP7q/ZDc5RxVr6dlhkOmg2B0jfOyJH+q3r rIPGePRIlCsJVvGJwNqjF/vFMVMlvNIf8GmtaI+Q8A5uQBUUgmTBWjxYchqPIep0sFajes+Rdop BQRH8h1NWIK/mnbdZ3upBsDj6xOAeMYfmJ4zBxeSZNgXFu9byqjLBvYpLwEfXjDIxRa8A1EQOLZ u1i2KM73Rip3wpIdNo X-Received: by 2002:a05:600c:c162:b0:480:1b65:b741 with SMTP id 5b1f17b1804b1-482db4ac5bamr160582205e9.15.1770062502857; Mon, 02 Feb 2026 12:01:42 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483051287cfsm19591905e9.6.2026.02.02.12.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 12:01:42 -0800 (PST) Date: Mon, 2 Feb 2026 23:01:39 +0300 From: Dan Carpenter To: KrishnaAgarwal1308 Cc: Andy Shevchenko , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: fix macro flow control warning and empty macro argument in fbtft-bus.c Message-ID: References: <20260202162826.116739-1-krishnaworkemail1308@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260202162826.116739-1-krishnaworkemail1308@gmail.com> On Mon, Feb 02, 2026 at 09:58:26PM +0530, KrishnaAgarwal1308 wrote: > Fix checkpatch warning by adding identity modifier for define_fbtft_write_reg(). > No functional change. > This commit does two things. It introduces fbtft_identity() and it flips the if (ret < 0) condition around to avoid the goto inside a macro. Only the first change is mentioned in the commit message. I have see the fbtft_identity() approach before and I don't like it. https://lore.kernel.org/all/20250718191935.5918-2-abronzo@mac.com/ The name identity() doesn't mean anything. It's a real word and it has a meaning but it doesn't have a meaning which is at all related to this code. I think I would be okay with this the macro were called nop_endian() or cpu_to_cpu_endian() or something. Or another approach is to just leave the code as-is. Or maybe we could add a comment? Regarding the flipped condition, the new code is badly formatted and uglier than the original. I would prefer to leave it as-is. regards, dan carpenter