From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 548F73090E4 for ; Mon, 2 Feb 2026 20:08:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770062917; cv=none; b=UKXfJx06Diyl6YDoclROJOOis+jFvpwkb1iRNWc9GtHjwxG7xpknKGa32znv9LQ3J25MIuC7WLYxaMreeCFPHl19gJtlEf2sXeFOYmYkPAIAs5hIFS44DzHf0gJ3gghibODIgOhZZzp3dJwPsc717x4ZtnCnqcYBNHglYnKQM0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770062917; c=relaxed/simple; bh=z5ezqF8xkEHg+o9+YAyPSvw5wr+U/Be3CmkY2XvRh5w=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bgUFj+YW2Mehva/FOYYgMu1zzKRud9GKtufIxe0loXz08hT8oeHmupPbELXT5ty1UjTd0LCK5BBaMzwoUuMVVwKQau9rNo0IOAJQXpglfHM+3h2eoLzmaYqqoJGjZLFcAxvrKuZogppBKGllGXmh7+Ig4eKQ8B/cQFMQaIL61a4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=JBfHIbC2; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JBfHIbC2" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-4806f3fc50bso49826685e9.0 for ; Mon, 02 Feb 2026 12:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770062915; x=1770667715; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qVWit5gEYvimCyPQVV7/Ca5DAiIkOlL8U62ipYN06HA=; b=JBfHIbC2RpATrchF9IYLlad83vMxnhG25aAt7mKSq04XxB0WJ9+yiAo7VSuqGmucoJ xp0r61ia7SMIglKB45Tw4xmAohAhlutireagpR0zQOXKJOJDpcKcMwRdzY/wFYxf7cAx +UKzssMrNuW4I/5uXqC24gn1ocb5oy3dOpKMxEJivxQSMhVo8iIhgszgsbGjgEu2Qk1I MSHkfKgj7gkGcDqvSyRX01SVePckkGg8LhGHuSaJWF33+9INCOqZuv8lAvSM402d/0EF JloiGO/ARyHOgYiSVcjW9v0OM5UBo7Us7Y7kdovc8BbrGP3wivbpXUVzyDpjuYkvODuy REsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770062915; x=1770667715; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qVWit5gEYvimCyPQVV7/Ca5DAiIkOlL8U62ipYN06HA=; b=ekX/0qfSAhyy6nELdrrigSb+M8INU0gFhZ5rAUpvb+H+e85RvgIpmwmRsczo8ZRFeJ SgUYjE+pqHl9K+8yKoLFV/6QwdLzqYIsb38mmjojOBQG7soJl124Zs1BEPHmIjL5gE0S iJZngJgwcKi7fdQNzc4bcA+G3ewI0HSvXZ1HjKIZeeGjGjyej1ibAwgzTiVYh1vC7Itl dyhXqLr2TBmyK7uoRUwVuCus4mpen505xqlM8k7e5ix5iTDBLBkvtIg1gyWWlwM8Z6ZX CqbjBQH9eYvjyTubhOUyNC2KqYE39/Z3eF1jopC5fMTbm7YQVjbXNkH9glvAlE6ZdZ7n 61cQ== X-Forwarded-Encrypted: i=1; AJvYcCXKOjGhCfUAJWAaKVEjr95aXSypKfPiWHQzq8BQOVhg2INnwjgY+MS3NbMLQd1pA0yJLFVjbyAYxxRyyTA=@vger.kernel.org X-Gm-Message-State: AOJu0YzyDrnx3qjViPW7CtgwJF72gR8nM1/EHTGqkpzzUmat16j1Vh+N 6FgPuNjwODF1lW6NcpbjJ9kx8Y6pCsaaxf9Ycdq8+AlCPp9h9SwisiPC92V9NyA3rjOSWphoK47 7ycV5Qgk= X-Gm-Gg: AZuq6aJTo1rqzV9tg/RXcxmD2v5QC4WIyAnx7zrt4gUXkXTPf5QHbvkGoAKWV9mD8eM 9tmGpghxJM0QVv9KJgh6RyfLywnjarhqoNp57lxYguhuuDmcJUz7t3o/e8qNQX0v3qgZmIs2hJs niyUKpMctBlEuqVUyJM2gy4x8HqprNr0VBmYxVuMv5zITUMZglxANSoaA/OGIShpDhGC19qDcXN bn8lIL62UEbndD5zoR/ZgPvX/TFbbDxbjVTV5f8cvbUDBuFzDinIG/WCiIYE4UMOzu2oWIjf5Kp TI76tKSAPJnpfwY6+8tyuggNsFW/EXQ1wa/6VH9T+Pa/COAYCkY4X2PdX+pw4QeaFQOg22cASBA 6Q0bTvzvV1N+zgkXH3OQecnyp/szfcYz+dBeuzxFNsBrHKOoIJyrZrv8hp4tOJJrN8excgkMB/r VlrRJlr4codO0bXgyJ X-Received: by 2002:a05:600c:a08c:b0:47a:975b:e3e6 with SMTP id 5b1f17b1804b1-482db493a7cmr155741285e9.18.1770062914672; Mon, 02 Feb 2026 12:08:34 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435e131ce70sm47807259f8f.27.2026.02.02.12.08.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 12:08:34 -0800 (PST) Date: Mon, 2 Feb 2026 23:08:31 +0300 From: Dan Carpenter To: Bogdan Sandu Cc: gregkh@linuxfoundation.org, bingbu.cao@intel.com, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, mchehab@kernel.org, sakari.ailus@linux.intel.com, tian.shu.qiu@intel.com Subject: Re: [PATCH v2 4/4] media: ipu3: use BIT() Message-ID: References: <2026020258-very-numbly-b36b@gregkh> <20260202175033.8640-1-bogdanelsandu2011@gmail.com> <20260202175033.8640-5-bogdanelsandu2011@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260202175033.8640-5-bogdanelsandu2011@gmail.com> On Mon, Feb 02, 2026 at 07:50:33PM +0200, Bogdan Sandu wrote: > Prefer BIT() macro over manual bitshift. > > Signed-off-by: Bogdan Sandu > --- > drivers/staging/media/ipu3/ipu3-mmu.c | 2 +- > drivers/staging/media/ipu3/ipu3-mmu.h | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/media/ipu3/ipu3-mmu.c b/drivers/staging/media/ipu3/ipu3-mmu.c > index cb9bf5fb2..95ce34ad8 100644 > --- a/drivers/staging/media/ipu3/ipu3-mmu.c > +++ b/drivers/staging/media/ipu3/ipu3-mmu.c > @@ -21,7 +21,7 @@ > #include "ipu3-mmu.h" > > #define IPU3_PT_BITS 10 > -#define IPU3_PT_PTES (1UL << IPU3_PT_BITS) > +#define IPU3_PT_PTES (BIT(IPU3_PT_BITS)) IPU3_PT_PTES isn't a bit, it's the number of PTEs. It's just shifting because it's a power of two and that's how you calculate power of two. > #define IPU3_PT_SIZE (IPU3_PT_PTES << 2) > #define IPU3_PT_ORDER (IPU3_PT_SIZE >> PAGE_SHIFT) > > diff --git a/drivers/staging/media/ipu3/ipu3-mmu.h b/drivers/staging/media/ipu3/ipu3-mmu.h > index a5f0bca7e..990482f10 100644 > --- a/drivers/staging/media/ipu3/ipu3-mmu.h > +++ b/drivers/staging/media/ipu3/ipu3-mmu.h > @@ -5,8 +5,10 @@ > #ifndef __IPU3_MMU_H > #define __IPU3_MMU_H > > +#include > + > #define IPU3_PAGE_SHIFT 12 > -#define IPU3_PAGE_SIZE (1UL << IPU3_PAGE_SHIFT) > +#define IPU3_PAGE_SIZE (BIT(IPU3_PAGE_SHIFT)) Same. This is a size, not a bit. regards, dan carpenter