From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 874E4241114 for ; Tue, 3 Feb 2026 06:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770098759; cv=none; b=ZA1njXX/pQUFQKzVZJdXRGIHzfEKUZ1u6sCcn1aFaDFCu6LqFcopjp03/18dNx1KC6qYwpqM1M/F56qrj607tVz2p+XbLUehTagjKe/NjdTLvel9PSDSs016Ju2eU4Zqevta5bULcb92k190UJA1UR1w8QCxCG5Dz7gYFZgl/PA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770098759; c=relaxed/simple; bh=afZGl96//d2rwNcgtg2o2FkwEOoHkFUxl/SSFdH8Ik4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=eNxk4ijhgar+QTkfp9BELi5umyvDQh7Xe4ejfpuRc69d9et8J4tBZkXIKnWkkUm90K8nQXqoASAxsCDbPmytGp+lC/hopx/lKSxBrXprWkMorsxBHjDrl4zUqJXX8rE6pFXrrf8n2GqPU2Fmyspt6L45MfO0VfnKRcCdd81I6qg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C1gI87br; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=PH9KoUA9; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C1gI87br"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="PH9KoUA9" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6132pVVX3386844 for ; Tue, 3 Feb 2026 06:05:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=vJENjir18TwTbYsuT4PFHqHv FcFqpnecxFzZxi0J/Ow=; b=C1gI87brFVcD0PAuvf1vj2t9kOlpzIlLjPGR9Wfc tYhyBqKDr4fKaq51XdCjFn97uqVtPaBJZDkkP5jr/RmXUBUg1zoXnjsNZYWcctcl wtb61UKhCnncLA8QYbHtAupHSOrBjhIE6JNRS6bnXdJ84c1tadc56jNWp88cRHF4 LvMUeaE94mooLsPzlRG0oBxdzAnN6i57Z4dJSdfNsw5lQaoEoJfprwR6OHTPkf3H T+hJB+BJLUUzWWH2lmjn9uv0SYmJsR2yHUr6HVfthZYrCMX4Ve2SYvHq7VncXpEm xaUysJNBU7l+cWPV0M1EceXsf7xQVFdWRFv3OxAZ/NWXfQ== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c2xvbt9cd-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 06:05:57 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2a0f47c0e60so12562115ad.3 for ; Mon, 02 Feb 2026 22:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770098756; x=1770703556; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=vJENjir18TwTbYsuT4PFHqHvFcFqpnecxFzZxi0J/Ow=; b=PH9KoUA9WeGqc6BNwNk63foUFu6ctRt5JEJpRM5J7rb0z9Lk1LVrS0acuZdbOoUWws i3bqG1A4xzqVCAuL1Y+TGlPowBeIRgBOcwbPzzy9b+Q3c/u1vCmUdhz7evrLhnrsZvAu mqrwTFvcTpTIOEwTPzIIZEiunxBFCh/cNwJd8M0QeCWohzJolDV3X+qJe6U7+EyC8l4C ajWOuoatZTGV60UwA3eC1V3y0te40O+5mQBcKpYAY8BOH6R5CwpOrxwA5yMmMB6hsZqI xll5WzXo5skXCGZMKUvPRYBID5cudlQW+jW6/Ds9NPOajjqow/RtJhS6/7izdLFsszLS PCEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770098756; x=1770703556; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vJENjir18TwTbYsuT4PFHqHvFcFqpnecxFzZxi0J/Ow=; b=kEXdSa95aJPDP/qKFcRXnKe6meKde6q2/4+66aeZNdqMgbyKceQSPTC0QzPMGHncDa Czfdm1vjyfP42k609QSd3PpM3Vem76COlUprjcaUC/L+mNjGIwwsUined74c5ZTndBJB XUXlTGe405FJQRSX1/lmCXYELybHPkiJe4rKRv9aroGvWVy0T3YknHSRxDwfFbjqu1pA kbWT+zZEKrMD881drs2nRtcaeaW8gKkMhjQg5+j+862jd/JRR9rBuoihGdTODf0/QKtB Wi/kHfxqdLJAUdvyQA1fHZoynOVRMXMp+DR1COF+eqBmYIMBEIRpINdUFcuwU72b16JO iJhw== X-Forwarded-Encrypted: i=1; AJvYcCX3c2v8BJJOXrziKOKq6vfTC4kBKgEXf0LEk1uEQ5oDm2vTIeA6HvqofRqAo2KbVTmIeesCGlMxlaHc/60=@vger.kernel.org X-Gm-Message-State: AOJu0YyNPRR58swVyxKEJmdHs5CI1OyD3JfpJVwFUNCi1Y18mRCGcY7q eN/ScjlaeNtQhi+F03PxWkOhmU46lwIe1TP7S9+fYSPYorCFATv1vBjPmpUveZpJdPLC0+yWWOF sLaLcjKjCaJdqAuWJTDGJB5ykzmNLhf7h6ytKgXs+ALynrv6U0HTJjr5QgLn4RVCCAxw= X-Gm-Gg: AZuq6aKePwbgGPCVgCgNI+xXlMpLDB/0JxRvBtYqfV7yVDGolzDLHMwwsvl65nkHBv7 ny/QEeRaxGZkYfMPjmP05gU9wlGtShIcjemNGR9YippvAAyBTBaXOoip/QRDhel682irtmpLNbc 9dChfPu9eW3cVVjwFlYyb5wihUnZxfvnKif852DPuurH8lDiCw5CjRYRAL8OnDQrX34z/1bYbGM tra4fT/DCebvmWgBEkpMvPQ0J64P00bIFF9cC1jK8CtBwNIUqXXK8WwuPRNGGRSurpAXRIyUWQA 9Pt9VV7NUEQwRhKc9t5XRQ7223uGbL+kUqQbKAtnky720RWH7Me4vUXfn0D1X0HcRdFD/Rq1ra8 l1H4YO3bjIT4rtRmGlFQ5kHvs7V3MipYMseT2hncqvenOi0SD11MJHkUwY3WyIjTHjpYsgt2c1L LMs9PSYG7YRH4PyRDSVrthjuGm7CVCGGnD1LwB5vw= X-Received: by 2002:a17:903:1967:b0:2a7:c6c8:2cf with SMTP id d9443c01a7336-2a8d96b11e7mr147944625ad.22.1770098756377; Mon, 02 Feb 2026 22:05:56 -0800 (PST) X-Received: by 2002:a17:903:1967:b0:2a7:c6c8:2cf with SMTP id d9443c01a7336-2a8d96b11e7mr147944425ad.22.1770098755932; Mon, 02 Feb 2026 22:05:55 -0800 (PST) Received: from hu-varada-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a88b3eee4asm159813045ad.20.2026.02.02.22.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 22:05:55 -0800 (PST) Date: Tue, 3 Feb 2026 11:35:49 +0530 From: Varadarajan Narayanan To: Bjorn Andersson Cc: konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sumit.garg@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Subject: Re: [PATCH v4 4/4] arm64: dts: qcom: ipq9574: Enable eMMC variant Message-ID: References: <20260202073322.259534-1-varadarajan.narayanan@oss.qualcomm.com> <20260202073322.259534-5-varadarajan.narayanan@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Proofpoint-GUID: lVJUuD-HIpdyBWPcdnZnr3ukKPtr5vUb X-Proofpoint-ORIG-GUID: lVJUuD-HIpdyBWPcdnZnr3ukKPtr5vUb X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA0NyBTYWx0ZWRfX7raG+TKX9Xnq /zz670fjs0jsWu6pFK62TNfGm/iKNUiFisz9P4BsLqxxr+vmL53qIbVBo5zQDfTFDhSvzRhWQCN 7ULBcKaFhZINeAX8Wnjk3Z9j2Z5/4WxfRnwvr0pnXUXNwMNntLOFPOOTSR2uKxKuZlcZcjvPVPX XaDKv0wX7AIdc7/7P9EhFksgOMc4/kG41nX01XhWdrMqraQYf2yJQ0FlVIMRK/P665AfGF3Brbw S3X2vV8l15mS3U6qeCfsIGfafCEN2D0Egk3LWHBZqGfzSRwetgRa0vd41sK+ZgrJt4scD8xC/ys uF0COTEp3Bj3coP9/glV0uOZ/hj0VE0q36MFXDgXVnr03KAvNHz1UjK9LAPeavHzFJZi8/DGg3U EzyfBiHJz9Ft6zTxIhc6VK74HGkwQLkN+SmyMzlQwgg8fNz6zXpSrFKArydunNBo+nVsmk7S0+K 0exPvFLydXTPagcIYyw== X-Authority-Analysis: v=2.4 cv=AurjHe9P c=1 sm=1 tr=0 ts=69819045 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=kj9zAlcOel0A:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=ve4KjJurTZdr_aZ2fzkA:9 a=CjuIK1q_8ugA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_01,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 spamscore=0 suspectscore=0 phishscore=0 adultscore=0 malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030047 On Mon, Feb 02, 2026 at 08:04:41AM -0600, Bjorn Andersson wrote: > On Mon, Feb 02, 2026 at 01:03:22PM +0530, Varadarajan Narayanan wrote: > > RDP433 can have NAND or eMMC based on a board level rework. Since the > > same GPIOS are used for both the interfaces, only one of them can be > > used. Add a new DTS file to disable NAND and enable eMMC. > > > > Signed-off-by: Varadarajan Narayanan > > --- > > v4: Move sdhc properties to SoC dtsi. > > Disable nand (that is enabled in ipq9574-rdp-common.dtsi) here as > > the eMMC variant doesn't have NAND. > > > > v3: As qpic_nand is disabled in ipq9574-rdp-common.dtsi, no need to disable > > it here. Just enable eMMC. > > --- > > arch/arm64/boot/dts/qcom/Makefile | 2 +- > > .../boot/dts/qcom/ipq9574-rdp433-emmc.dts | 24 +++++++++++++++++++ > > 2 files changed, 25 insertions(+), 1 deletion(-) > > create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-rdp433-emmc.dts > > > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > > index 6f34d5ed331c..d5fe12ef4300 100644 > > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -26,7 +26,7 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb > > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c1.dtb > > dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c2.dtb > > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp418.dtb > > -dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp433.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp433.dtb ipq9574-rdp433-emmc.dtb > > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp449.dtb > > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp453.dtb > > dtb-$(CONFIG_ARCH_QCOM) += ipq9574-rdp454.dtb > > diff --git a/arch/arm64/boot/dts/qcom/ipq9574-rdp433-emmc.dts b/arch/arm64/boot/dts/qcom/ipq9574-rdp433-emmc.dts > > new file mode 100644 > > index 000000000000..9053838ef696 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/qcom/ipq9574-rdp433-emmc.dts > > @@ -0,0 +1,24 @@ > > +// SPDX-License-Identifier: BSD-3-Clause-Clear > > +/* > > + * IPQ9574 RDP433 (eMMC variant) board device tree source > > + * > > + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. > > + */ > > + > > +/dts-v1/; > > + > > +#include "ipq9574-rdp-common.dtsi" > > +#include "ipq9574-rdp433-common.dtsi" > > + > > +/ { > > + model = "Qualcomm Technologies, Inc. IPQ9574/AP-AL02-C7 (eMMC)"; > > + compatible = "qcom,ipq9574-ap-al02-c7-emmc", "qcom,ipq9574"; > > +}; > > + > > +&qpic_nand { > > + status = "disabled"; > > +}; > > I'd prefer you keep optional peripherals/buses disabled in the common > dtsi and enable them in respective dts, this generally gives cleaner > layers. > > Was this done on purpose? Yes. Presently it qpic_nand is enabled in ipq9574-rdp-common.dtsi [1]. Since removing that will impact other boards that include ipq9574-rdp-common.dtsi chose to disable it here. If this is not ok, will disable it in ipq9574-rdp-common.dtsi and enable qpic_nand in other board DT files that include ipq9574-rdp-common.dtsi. Please let me know. Thanks Varada 1 - https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/qcom/ipq9574-rdp-common.dtsi#n182