From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA9E731CA50 for ; Tue, 3 Feb 2026 15:15:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770131707; cv=none; b=BTuMkRt2nnlgdv6SAJ+tSRAtLF93FLu25ADcNErnw1KqBcohG/sc9rOcQihBKBrTILwlQ67cWI+MTNRrr/IxvgIfwHIR8U60PunqU6CEHxluAyApfdX7/YVOz0rE0i3uupPzOpmmQe2v8DwdWLRTyVUZhXDHmvHDCMcFaS94dtY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770131707; c=relaxed/simple; bh=zeFaz968/FmfVdqUf02Fjjg4IAOYZ0tXQfQ+XejDjJs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tMECvWY6oVvKDDtpT69KW6okFbetQKfihHa+CDpPuMcEgdtbxZmbmFs1kU9JIHRAAJ2suaCLGvS9wL9KR45gs3aPM8rdznEiMS2BQejHshOVRPmRtQcZzpTITDq2y6TnVXh7A2Uge8UUkRssYNcOWA3Tq5O/gANiM0reNGuVsZU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=ew4VOk4k; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="ew4VOk4k" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770131705; x=1801667705; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=zeFaz968/FmfVdqUf02Fjjg4IAOYZ0tXQfQ+XejDjJs=; b=ew4VOk4kn+kLxI559KNu5ZSyjlMu5HLrjrxC4clbDELUQd6VgQKwE0rc Qvfq5VWD74UFNY3QeNw9N6oChOUEHQC+8lzjqooUC277RhVitHp6S2P9I MC5cE6u6c/NVBikzzV2TNbO3jZWjXveO1ZutEvgN6ufMOldd30+id2RH5 zWZgePtPLKfGwRYCO0fXJ+EGtlnPSxnIdNobiJ8RWno5krrRRyiNDAz7T xMCHKeYULz0YGdfm2ICw7wYVlgoklHwtw29pgqpQH6Jwcy19olGtOEfRS XfSoGkbuXWOZiEzykrKYv5JQZRA0vxELaPAZlWgvjWn5CeplddnrdQw3P w==; X-CSE-ConnectionGUID: fsWvzwUORxOT12FDtIWQRg== X-CSE-MsgGUID: MN/gtcO9SWeOkT9asNfcqw== X-IronPort-AV: E=McAfee;i="6800,10657,11690"; a="73901454" X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="73901454" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 07:15:03 -0800 X-CSE-ConnectionGUID: qq2Zdc+uQ8GTRlysBSp9aw== X-CSE-MsgGUID: Rm7mDMtcTcmXiZ15hUXU/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,270,1763452800"; d="scan'208";a="240550010" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.99]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 07:15:01 -0800 Date: Tue, 3 Feb 2026 17:14:58 +0200 From: Andy Shevchenko To: Minu Jin Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org, trohan2000@gmail.com, andy@kernel.org, linux-staging@lists.linux.dev, straube.linux@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 4/4] staging: rtl8723bs: remove unused allocation wrapper functions Message-ID: References: <20260131193001.303307-1-s9430939@naver.com> <20260131193001.303307-5-s9430939@naver.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260131193001.303307-5-s9430939@naver.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Sun, Feb 01, 2026 at 04:30:01AM +0900, Minu Jin wrote: > All memory allocation call sites have been migrated to kernel > APIs (kmalloc, kzalloc, and skb functions). Therefore, the custom kmalloc() kzalloc() > wrapper layer is no longer necessary. > > This patch removes all redundant wrapper functions and macros from > osdep_service.c and include/osdep_service.h, including unused macros > like rtw_skb_alloc_f. rtw_skb_alloc_f() ... > -void *_rtw_zmalloc(u32 sz) > -{ > - void *pbuf = kmalloc(sz, in_interrupt() ? GFP_ATOMIC : GFP_KERNEL); > - if (pbuf) > - memset(pbuf, 0, sz); > - > - return pbuf; This change should remove the _original_ implementation, so no need to have a churn to first convert this and then remove it. > -} -- With Best Regards, Andy Shevchenko