From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD4CE3B8D72 for ; Tue, 3 Feb 2026 16:27:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770136031; cv=none; b=VWGj/i/JEG8YkBMl05GVI3VmISNC6nHNSaAo47rpvTMmV5I+1MWuREm/OxRgTqElyiKdq6Cwo5hhrE5sSpMIHK497H+pfVss2uU5lVnpvU1rW4x+ujL8b8PQO4GO/7Vlx2ATjcWSjGR2iuOEeTTDF8Yn8g1dXtpC9517+O4i8fY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770136031; c=relaxed/simple; bh=kWLoDmf7UBD640IjC2Ysbt5+uVYaghuEoWl58LkF564=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VLl4VJ3KTl3wljtp7sRqhIzyUqC+UZiazn38iD1pu34h5nE51i5iy0OfSpUZKZ5eiLzsY80/D60Xe4fgoe86uOAUVCKqQT3SBzF26zwNtt+GPtK3uDBEKSe6kFpv4mKNv3svvfrxBbYNvjnCEKbnSpmYTZfYtWeyW8AbwDAeFgs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=TCCIYGAo; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="TCCIYGAo" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ihGhxkBey6kFkwXRM9ITv8oPknMKk924ge/1joU7ljM=; b=TCCIYGAoplBTxL6XkOxRvOvNi2 UlLDnjKkx/25zsC+QoCIOgNcPp5da1kybz4nlM06M5gCgJtrZs/yPGT0MIg5/mMjFxeZU4k6iQgj7 rGlgB6Yq8EYJYaAY9s0Jx0uNvYpqM9xz+jYofGDNotF7yr/Lb1PNv7E37bfm93rX7dhO09n9kYlUZ N9BlXspmYgizFF/m2xp2LMbdOv1JPWigOKkhXbb8bKt9BgulFyGnchxLc2+flp4lxc7h2V7WdQExw DL63UjGshaGMhxPRfERbSnW23i2MG6lstrdmrotBjHGJohLb/VjLATOpysG1lLmstp/nKtO7yNodT eowXEsvw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vnJF1-00000006wqF-0RFm; Tue, 03 Feb 2026 16:27:03 +0000 Date: Tue, 3 Feb 2026 08:27:03 -0800 From: Christoph Hellwig To: Harry Yoo Cc: Vernon Yang , =?utf-8?B?5p2O6b6Z5YW0?= , syzkaller@googlegroups.com, vbabka@suse.cz, akpm@linux-foundation.org, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [Kernel Bug] WARNING in mempool_alloc_noprof Message-ID: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Feb 03, 2026 at 06:52:39PM +0900, Harry Yoo wrote: > Maybe the changelog could be rephrased a bit, > but overall LGTM, thanks! No, that does not make sense. If mempool is used with __GFP_RECLAIM in the flags it won't fail, and if it isn't, GFP_NOFAIL can't work. So if there is any work in mempool_alloc it's that it should warn about GFP_NOFAIL. The fix is in the callers to not pass the flag, assuming current kernels still do this.