From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D9E13D3483 for ; Tue, 3 Feb 2026 16:59:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770137946; cv=none; b=tnyzsQNBMPjq1AOJvOf+ONK32Bi/UPu4aJ5JqIwKdHw0119FPb+dRLdEOPX6GnnuvyCAvS6LwQlW0i3BZSSxMfy5yyj2VlJ4ycAyu3nPeIRT2t4qY3sXkjdMuzBwDcjqToEwVRyCmkhYMO/fCY0KUfh/5fsklOTOi/rhhSf0Bj8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770137946; c=relaxed/simple; bh=0I1c93Apnjg29DhHJdOUtMPEriai441LptCqQW3KXoc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ggmyJb/HGF380RjIIjVmFe6SGHxH7M12dPDs8kIjaQtZaoMfGuC9Hsoq+uASCLuZzM6yXsQJ9/8aW8e3oYWHa+JfTAgIWO0nVMtzOWlx3FKPJFQj++vNuUFrvtu1he62xQ/IZJDXbAVo2izfvb+GlDCUTlmCKlw3ILwd9TOcwNw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=Iubxm0LG; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="Iubxm0LG" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=W0aHSbI6iDavO4xs9+kYxiUbZ+ujh9oTdr7K2zYuvZQ=; b=Iubxm0LGYBl2K95ObztodfZ3QK Ql6Q/Lk4xxacizw+FwPFXFwGcGXoEaPeUfWB/kH5Mz49tv189YHCJji44KldFSQ/pwEBiyWj8uyK9 GPmqPtVRAOjjWIYLaKzuYfmy48jucIa6q6AQl4XiRJL4ZLvQ7qlt/vN5L/SJLaX3axhE2F9fcDA8y xDtR5jlqvfEfOAZ8o3Gua7QP3HLcXU98j+6diiBVsT054Ix6xbOj/42incZA3afUGIxZMgLNYFr95 irwN1V0b/F1JNDeHgnspkB3pDAbPwyHwYlnkjTy+O45yiyGN24FNJ1fRtbN8v9ocW251zh7Hq+Zci BEW0Cj7w==; Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux)) id 1vnJjy-0000000700q-2t8Y; Tue, 03 Feb 2026 16:59:02 +0000 Date: Tue, 3 Feb 2026 08:59:02 -0800 From: Christoph Hellwig To: Vlastimil Babka Cc: Christoph Hellwig , Harry Yoo , Vernon Yang , =?utf-8?B?5p2O6b6Z5YW0?= , syzkaller@googlegroups.com, akpm@linux-foundation.org, cl@gentwo.org, rientjes@google.com, roman.gushchin@linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [Kernel Bug] WARNING in mempool_alloc_noprof Message-ID: References: <6f5881df-0e0b-4278-808b-7c0cffa12a30@suse.cz> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6f5881df-0e0b-4278-808b-7c0cffa12a30@suse.cz> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Tue, Feb 03, 2026 at 05:55:27PM +0100, Vlastimil Babka wrote: > On 2/3/26 17:27, Christoph Hellwig wrote: > > On Tue, Feb 03, 2026 at 06:52:39PM +0900, Harry Yoo wrote: > >> Maybe the changelog could be rephrased a bit, > >> but overall LGTM, thanks! > > > > > > No, that does not make sense. If mempool is used with __GFP_RECLAIM in > > the flags it won't fail, and if it isn't, GFP_NOFAIL can't work. > > So that means as long as there's __GFP_RECLAIM, __GFP_NOFAIL isn't wrong, > just redundant. Given how picky the rest of the mm is about __GFP_NOFAIL, silently accepting it where it has no (or a weird and unexpected) effect seems like a disservice to the users.