From: Andi Shyti <andi.shyti@kernel.org>
To: Artem Shimko <a.shimko.dev@gmail.com>
Cc: p.zabel@pengutronix.de, mika.westerberg@linux.intel.com,
andriy.shevchenko@linux.intel.com, jsd@semihalf.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/2] i2c: designware-platdrv: simplify reset control
Date: Wed, 4 Feb 2026 02:43:30 +0100 [thread overview]
Message-ID: <aYKj31hi1bF4wmsi@zenone.zhora.eu> (raw)
In-Reply-To: <20260130111039.874548-2-a.shimko.dev@gmail.com>
Hi Artem,
On Fri, Jan 30, 2026 at 02:10:36PM +0300, Artem Shimko wrote:
> The current implementation uses separate calls to acquire and deassert
> reset control, requiring manual error handling for the deassertion
> operation. This can be simplified using the dedicated devm function that
> combines both operations.
>
> Replace devm_reset_control_get_optional_exclusive() with
> devm_reset_control_get_optional_exclusive_deasserted(), which handles both
> reset acquisition and deassertion in a single call as well as
> reset_control_put() which is called automatically on driver detach. This
> eliminates the need for explicit deassertion and its associated error
> checking while maintaining the same functional behavior through automatic
> resource management.
>
> Signed-off-by: Artem Shimko <a.shimko.dev@gmail.com>
> ---
> drivers/i2c/busses/i2c-designware-platdrv.c | 30 +++++++--------------
> 1 file changed, 9 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
> index 7be99656a67d..88e70970c72c 100644
> --- a/drivers/i2c/busses/i2c-designware-platdrv.c
> +++ b/drivers/i2c/busses/i2c-designware-platdrv.c
> @@ -227,40 +227,32 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> - dev->rst = devm_reset_control_get_optional_exclusive(device, NULL);
> + dev->rst = devm_reset_control_get_optional_exclusive_deasserted(device, NULL);
> if (IS_ERR(dev->rst))
> return dev_err_probe(device, PTR_ERR(dev->rst), "failed to acquire reset\n");
>
> - reset_control_deassert(dev->rst);
> -
> ret = i2c_dw_fw_parse_and_configure(dev);
> if (ret)
> - goto exit_reset;
> + return ret;
>
> ret = i2c_dw_probe_lock_support(dev);
> - if (ret) {
> - dev_err_probe(device, ret, "failed to probe lock support\n");
> - goto exit_reset;
> - }
> + if (ret)
> + return dev_err_probe(device, ret, "failed to probe lock support\n");
the dev_err_probe() changes are not mentioned in the commit log.
Can you please split this patch in two, one for the
devm_reset_control and one for the dev_err_probe?
Thanks,
Andi
next prev parent reply other threads:[~2026-02-04 1:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 11:10 [PATCH v6 0/2] i2c: designware-platdrv: simplify reset control and fix cleanup on probe failure Artem Shimko
2026-01-30 11:10 ` [PATCH v6 1/2] i2c: designware-platdrv: simplify reset control Artem Shimko
2026-02-02 9:21 ` Mika Westerberg
2026-02-04 1:43 ` Andi Shyti [this message]
2026-02-04 1:50 ` Andy Shevchenko
2026-02-05 7:57 ` Artem Shimko
2026-02-05 7:56 ` Artem Shimko
2026-02-05 10:27 ` Andi Shyti
2026-02-05 10:56 ` Artem Shimko
2026-01-30 11:10 ` [PATCH v6 2/2] i2c: designware-platdrv: fix cleanup on probe failure Artem Shimko
2026-02-02 9:22 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYKj31hi1bF4wmsi@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=a.shimko.dev@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®