From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51C70DF59 for ; Wed, 4 Feb 2026 04:05:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770177903; cv=none; b=UKXBtEs5Ir6xY5lr3SbykDwi9DnP/XfV8wbFeLyg8RY0LKqGT8PxRnu6PFghcImrjlbN4GKRahK9bbt01O2oRulHEiac2RZrWRGUgqrQoWiSR4am0f31bC4JRBPBltx7ofIQZY7J4I12b+KIcxkBDaZQcmp6rj9mOczmAjVpWCE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770177903; c=relaxed/simple; bh=VeokmRxKrzPdkUW4Q5G306mDxXMWUl855v4qe7W+BKw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QmuAKn3nBpuB9EpsFCgJBv+H5t3O3Hvt1QAwAZvanMqVP2TePXGfLhvUjJaGr/nQaTYONOg+Dvofw0wND3MHYDw1o8MDibEyqnMhCH0D8tFIjLPpZjVz7Y/MkghvbEn71pwkrmWkFKZ/iXsYKHAb6aqnb/JP+ObBHvor5264v+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CsViMb56; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CsViMb56" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-8946e0884afso105995346d6.1 for ; Tue, 03 Feb 2026 20:05:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770177901; x=1770782701; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Rs6BBarzwmD2Zm1TSaGTp7E5XeDaUo3g+3j+s/whg7M=; b=CsViMb56q82HU9p02aZW9+xex92pARB54E5+PgiCsPp88LVounByLCd+PbNVi1/MNs YqZvaO2EMLyAh+nEFskFFDWu1F70NcHo3JyQq3gnnntNjpLQXoJxEy6sGfr8QTfbWhiy Mo/T5BAVlCUb8CxvMec7G04O5rMHbg7bUAj+sxfGdslBCZZD4etAXU1ehJHJ2hoj2G+4 sFNrcFn2eNaJdXnPaw7I5EavDt3AxXsGtGNjwAqa8z2PIRfmMp+eG+U/3+Eu7MyYHY7o 572FyLfxnNEKBE7KG26Vd5Uv6xUlP/VcfuXYCQL1wx6AFq9PxCF6LTLQVeKjT90kmh3n whaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770177901; x=1770782701; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Rs6BBarzwmD2Zm1TSaGTp7E5XeDaUo3g+3j+s/whg7M=; b=JTCaNoinOri+on3hD7TElINR7E6c1AyUZEIfJjnQCDWUZGkdQViIe9CDS83MsKIKdf rsuO3cl0pMnF//b6HVbuIqJ2uooVetyjB6iODU5TbExdtng3S4HcPRXN6PD1GJoMWyZJ k+b100sa/20d2XEEpY3TskxYfa7PBOf6rrjFVBC+/fioFoXBrbyZA2tX4D3XBL6LxKv8 ybPkcNxCTHIx0eFQWRFXbCGchGpH55KPLIVfDqpEyIuOPV+HDHUt5WnclY1zW83mnTDN lb2oGvU/UBeeOkvO9BnbtEqb/LpGhkQ+kU5faVT3vNvcnnUgxJ0fDTs1wAQDxR+InARC Hpng== X-Forwarded-Encrypted: i=1; AJvYcCWGGdhhsJStg7oTQThU8SjyWQxx3LmPW6YZUx1DmdPeoSTW/SHxSrKloYvs8wKPpRVHtdKTzKPw3fU2/NQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzKej5hV0Rgip2mGATNiDYlY6dtWcXDJZ60leA1odsYTHz6WSPf dTaWpsIl37cdR5F/6adWAKClzw8DYjQ+8478Hs8kUtxs77/G3sLr/8oTdYhXFPO4 X-Gm-Gg: AZuq6aJa0HrZcEjNzzZIP4ja9ipImiVs+KpQlc1tALAHfyH6yBZRurbCDjiX3Ax/1lo cXQ0yTK7bsRuRSUv9cu7qn/WgDEfi8k1vf/pdh4YbxAI4oQas9VHlYkB237sxvWTYpULP9XlzJI WDf01MlOP9jswHqhlHC3YOxR/n4eyVLQhN5Z52fF8Ev5tUimF0VUY3CfQ0EnsXOqleUEw5tNKyp BUlg5xWvNsWBQVpsM+RRFG7q26qs/jIMqtni+fEWhX0pgyOZXabsOI+/SuyACMfc9o6AKMtwANj 7GRJSs3NTM14aulBT3sVdNtyjo3Xp1ylHBu57l8pnNeXFNs2zDi/4crGPJOKydxaA+TnNLAcN/U Su/oBFwNqnvup7wj8M4VL6/yqRaEr/v3i34FRFeYN7D/PqGoo8cTySQ7hnQxWhydfz2T8Iai6BN jlG7DiARV4mA== X-Received: by 2002:a05:7022:f103:b0:119:e56b:91f2 with SMTP id a92af1059eb24-126f47daa76mr613066c88.35.1770171313127; Tue, 03 Feb 2026 18:15:13 -0800 (PST) Received: from localhost ([2001:19f0:ac00:4eb8:5400:5ff:fe30:7df3]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2b832feacc6sm940814eec.35.2026.02.03.18.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Feb 2026 18:15:12 -0800 (PST) Date: Wed, 4 Feb 2026 10:14:47 +0800 From: Inochi Amaoto To: "Russell King (Oracle)" , Inochi Amaoto Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , Maxime Coquelin , Alexandre Torgue , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yanteng Si , Yao Zi , Lad Prabhakar , Shangjuan Wei , Maxime Chevallier , Chen-Yu Tsai , Zhi Li , Boon Khai Ng , Quentin Schulz , Giuseppe Cavallaro , Jose Abreu , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, Longbin Li Subject: Re: [PATCH net-next v4 3/3] net: stmmac: Add glue layer for Spacemit K3 SoC Message-ID: References: <20260130022705.1059214-1-inochiama@gmail.com> <20260130022705.1059214-4-inochiama@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Feb 03, 2026 at 05:48:00PM +0000, Russell King (Oracle) wrote: > On Fri, Jan 30, 2026 at 10:27:04AM +0800, Inochi Amaoto wrote: > > +/* ctrl register bits */ > > +#define CTRL_PHY_INTF_RGMII BIT(3) > > +#define CTRL_PHY_INTF_MII BIT(4) > > +#define CTRL_WAKE_IRQ_EN BIT(9) > > +#define CTRL_PHY_IRQ_EN BIT(12) > > Thanks for updating these. > > > +static int spacemit_dwmac_update_ifconfig(struct plat_stmmacenet_data *plat_dat, > > + struct stmmac_resources *stmmac_res, > > + struct regmap *apmu, > > + unsigned int ctrl_offset) > > +{ > > + unsigned int mask = CTRL_PHY_INTF_MII | CTRL_PHY_INTF_RGMII | CTRL_WAKE_IRQ_EN; > > + unsigned int val = 0; > > + > > + switch (plat_dat->phy_interface) { > > + case PHY_INTERFACE_MODE_MII: > > + val = CTRL_PHY_INTF_MII; > > + break; > > + > > + case PHY_INTERFACE_MODE_RMII: > > + break; > > + > > + case PHY_INTERFACE_MODE_RGMII: > > + case PHY_INTERFACE_MODE_RGMII_ID: > > + case PHY_INTERFACE_MODE_RGMII_RXID: > > + case PHY_INTERFACE_MODE_RGMII_TXID: > > + val = CTRL_PHY_INTF_RGMII; > > + break; > > + > > + default: > > + return -EOPNOTSUPP; > > + } > > + > > + if (stmmac_res->wol_irq >= 0) > > + val |= CTRL_WAKE_IRQ_EN; > > + > > + return regmap_update_bits(apmu, ctrl_offset, mask, val); > > I would suggest that this is split into two parts - first, this is > renamed and reduced to just controlling CTRL_WAKE_IRQ_EN. > > Next, a function hooked into plat_dat->set_phy_intf_sel which sets > the CTRL_PHY_INTF_RGMII and CTRL_PHY_INTF_MII bits as appropriate. > Note that this function is passed the dwmac's own phy_intf_sel > value from common.h which will be PHY_INTF_SEL_GMII_MII, > PHY_INTF_SEL_RGMII or PHY_INTF_SEL_RMII for you. > > It would also be good to have plat_dat->get_interfaces populated > using phy_interface_set_rgmii(), and __set_bit(PHY_INTERFACE_MODE_MII) > and __set_bit(PHY_INTERFACE_MODE_RMII) to indicate to phylink which > interface modes are permissable. > > Thanks. > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! Thanks for your detailed guide, I will try to switch to these helper apis in the next version. Regards, Inochi