From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D94E62DF68 for ; Wed, 4 Feb 2026 02:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770173231; cv=none; b=NrtLzbrpUVk3aYmiZvPbTHHcDAAOc9uyB+1plQntWabmjSm0ng9QaFOKNrA9ZCbQAH8+fyP1tibCAyPBML+TZcJHMvieXte8NKT2PWOZqvZ5g16UaqdsgnbnFa3ZDSGsezK06jqlcBJ6xMxMqF5odFVvO21HqRNuV1iKPehcT5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770173231; c=relaxed/simple; bh=FSoseFQHt/NyW6YtJkSwXGgIolf0lb0XGTwj4ndCEG8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=YxzZu789KQ2eK2zpnbu8vz93mIsGuM1GNzqerETCEx0FORnG5+aGIimEbDADZUT8rxGl3rPmAXFqBzvkoVlkchNzyxjVnUXvX8fJjq7CVYg5Th/nDwNVlxIkw/aLC5YhZgIU9Samygur+CGkL3+3UqSxMci7Wk3qnty8vherDAc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=T1amLYyf; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="T1amLYyf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770173230; x=1801709230; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=FSoseFQHt/NyW6YtJkSwXGgIolf0lb0XGTwj4ndCEG8=; b=T1amLYyfaWtLzPKb9ZFiL7h0+iG11JE6w9xefinkoytKl2GHg6Z1QonT vIK9mi0m4w23L/rJy1YWznAVbDj2/2dU+ubwsOIeOF5HfuXJMK/KeLSs8 Gt6A8xK2WLysuSubjYx7IFtj+F+OKVY1dePgYuiu5MYcZ7qrGd/Exa8PA Uv6R2OrlvW3Wwm5gRx6NAFCXhwZ8Dir712C2ss/B9rcebZ9lLq/qEEPXk DX3NKTS5do/vyukPohOcz8ys4VqwM/VMQLHN24QKWeqQfLF4vHxyH4MI8 tAk/F5lucW3oQGwK8jdO8xzVqiO3ee4IS3a/cTSPuZ1VQ8mICGjLGQOpg A==; X-CSE-ConnectionGUID: ios1B9yiQa2kMy0fbx9PJA== X-CSE-MsgGUID: ujOWWURDQLm7Z5R/ZldmmA== X-IronPort-AV: E=McAfee;i="6800,10657,11691"; a="71254343" X-IronPort-AV: E=Sophos;i="6.21,271,1763452800"; d="scan'208";a="71254343" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 18:47:09 -0800 X-CSE-ConnectionGUID: uxyySxc/To2hs32C9sbXXg== X-CSE-MsgGUID: qn11XEgYRwCmKXPwTaT6tw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,271,1763452800"; d="scan'208";a="210122543" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.168]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Feb 2026 18:46:43 -0800 Date: Wed, 4 Feb 2026 04:46:40 +0200 From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Sudip Mukherjee Subject: Re: [PATCH v1 1/1] parport: serial: Convert comments to indices in cards assignment Message-ID: References: <20260122090601.2380747-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260122090601.2380747-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Jan 22, 2026 at 10:06:01AM +0100, Andy Shevchenko wrote: > Instead of using comments, use explicit indices. This will help to > address an entry in an array by known index and leads to more robust > code. Any comments on this? -- With Best Regards, Andy Shevchenko