From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A6D7363C74 for ; Wed, 4 Feb 2026 09:46:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770198394; cv=none; b=C2/Zr/kB6BTKc3Csv7Xa7wUTM0r2CQt6WNG7QlP+PgCcrH3zlMjuAr1PaMei9V/qrXomv+BTNS3aI8fVCmbD+ImuYfMzFaeZzyFHQS5rcBcX0qdlt9ys1itrdulvpKsyBLDn4h4/fXcWxJGrgcyRYvYpC8Q8XA3NS7pJSEkpa3g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770198394; c=relaxed/simple; bh=RUc+3G7+FL3pRf/tUQlP2vjiVuLDLcmKvA7SsedJM5k=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=BhVR08fycYTDV62XDekKM3k0fm0pPmabkWj3jDUL4b6OWkqB6J1Q5U99FTtFv3TtULsFFwt1mx5DZTglJGCY4XwjIhVxl/h5vlwHrrxs/gXvg6nuVckoNCDBNg/MYQqV30T72qvURg0eUuzhx0MNVgTUx6aClSyde+bAWFP9Suc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=PWIiBq1W; arc=none smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="PWIiBq1W" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-435a11957f6so5129904f8f.0 for ; Wed, 04 Feb 2026 01:46:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770198393; x=1770803193; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/s7GqwS0RYtq25/D0ZyCexH8s1Q1mK/+ZBZIJKp9rYc=; b=PWIiBq1WqzvX1gAHKjssM9bdaFsC7GrTI1yz+8wtJ96hJc/s3II4WZXqw/0MTKZnJK Lu8o7gWCowzSDi+KfzhuyLeg6VoSVnwTD1DcO1/jcH1EoY45xFNw0GsGYv24aPWJKEs5 73PqUJXv6qsKyafjs6bKyA8oyiFh4yG1EMr9FIOuL+ffOi7AoTdMRCGKQdARh5DjArmE M1+RcWyKdtqT0ESqUHSUHyZINgd1DEBJ+bmBLxX7yactL40wueycV8ZplwREKKt8/ui/ FGJT1ixxTaiOHCv2bfqerCv6Vh5T/44MRr+W9DR2ykziXa/5QC35rRYNhz74wQt2bFi/ TDHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770198393; x=1770803193; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/s7GqwS0RYtq25/D0ZyCexH8s1Q1mK/+ZBZIJKp9rYc=; b=K/ABOwOtdrq7f57jMpZklJPYsuVh8kjCI72MXLFyZxhKE5+tavn9+kbQ7mgIuaLkzY BN+VV0jT/NVFGwQOz00hfYPPeCYlprox9SLcQNoZfsE2mAm0DgeVzsE+oDaeOVGbQmFN RebhW5ZdfPqArj9CHUlGeFI36PbRr3nxAIrI9tE5UPva5cN6OzR8HNFaFAHC0cTP4UlP GAlGC4V1yisIB4NsdIxpojwFJpH+U2WC9jnV2BwjFrme24M+WLZXvgHxH7JkyExRphKk uxowCv6bLBoKcMGcfixn7ZLlkOPY9FkAWaHG1MkVI7VCJVCg5oG4L4v9f2WAsIJOed+i x0vQ== X-Forwarded-Encrypted: i=1; AJvYcCXXtoJNAIIHBYHwxH2Z1YWx6d5nz6SWR3Wj5Xgn9sbLI/D1RRdtsmfC6kLK24SbaUUolENU+vQ+mc9WnFQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyTcZ2Jjt2yvtiFTX61r8v0awwoNyhVEyp4MI1U8KukMhR8hwyX 7MYYZmd+iBjq9HuQ5LUVQHUGmeXmQo4eXPaQBuZVjpI776AcIsnr1bTZhDax6W7cDLg= X-Gm-Gg: AZuq6aLgOdFXt9Pjmp/VLVDK5pAZC9gKVtr6S/ZQjXMn753y9QUt8qEcuNi3cpQluGi b59nhFtik7QT+qD1Rm3z+a7188TU2QBH7b0Gat5B4dU+HWsbrRkOTn9ZWteHyWxjAjOjY0LTr07 mcTBf4XoGWIBzczIN1+fxcsg/PZqEFxctmcw6vZioZf9hWdC4SLnskc2DbtIs4ryygH4HWVP1GO 9+ec3gYlNPEMdAbp3tT0ouEA5RSLaxhCTS0evbkaFEBdPTrZxxvJQ2ZHUDQk5RerxSR0DQMpjUn ObArCpqBHnrUE9STGvA/DF8SwsqIWWulVufQT6zpW7dz8okJU90FXYiG/qLiiBK0WUsXBhtEVXX HgUWo8CBBKi0kjEGQOWodocsbwFiPEDh/gYEpjLayCRaUk+NKlD9I+6W2UJ8K/es677t8K2Ihve f/ill4SJ0BmeIqTURd X-Received: by 2002:a5d:5f88:0:b0:435:a4a9:6f67 with SMTP id ffacd0b85a97d-43618059bbdmr3236589f8f.42.1770198392548; Wed, 04 Feb 2026 01:46:32 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e38ec5sm5689345f8f.14.2026.02.04.01.46.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 01:46:32 -0800 (PST) Date: Wed, 4 Feb 2026 12:46:29 +0300 From: Dan Carpenter To: Neel Bullywon Cc: Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: greybus: gbphy: replaced sprintf() with sysfs_emit() Message-ID: References: <20260203212254.90855-1-neelb2403@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260203212254.90855-1-neelb2403@gmail.com> On Tue, Feb 03, 2026 at 04:22:54PM -0500, Neel Bullywon wrote: > Replaced sprintf() with sysfs_emit in the protocol_id_show() sysfs > attribute func to prevent any potential buffer overflows There are no buffer overflows here. buf is PAGE_SIZE so it's more than large enough. I like this change, but the commit message implies there is a potential buffer overflow and that's wrong. Say something like: "This code is safe, but replace sprintf() with sysfs_emit() because we are trying to get rid of calls to sprintf() as part of kernel hardenning and sysfs_emit() is more appropriate in this context". > > This is to ensure a kernel-wide migration to safer string formatting > functions for sysfs handlers > > This was compile-tested only (no VM/hardware used) Don't put this sort of comment in the commit message. Put it under the --- cut off line. > > Signed-off-by: Neel Bullywon > --- ^^^ Here. regards, dan carpenter