From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2C68B13AD26 for ; Wed, 4 Feb 2026 10:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.66 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770201674; cv=none; b=Iy0rpnMVXlLtLmWzMecR5eyHx05Y/OGi7eo7qeLUvSvKXlTvzPJUZ2cHA1x7bqpNlRdg39TbBX2FkePujlZJXQLry9ASWULdrfbnhP2Iy+EMi2zGt5wQW6dhdY/TKy44UgviC1As8yeHCZOCemwGb0ZQL3oYK/axT4B8ly3sf+Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770201674; c=relaxed/simple; bh=zGRDoeqWjvvsxSiTdNedN/KqGPHK4idX9GpHauJq50M=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dw+Ps4UJVaqQkP22VKKVH4+frZKZtbquGBbvb88M+AzcuckMCTxED3/FYYUMz7nBT6sbB3ya7IOOzBN2q6SwALdfrpXb+XHLprWMaINIIDa0orZ1yV7cqeL4HXklFPZsa8FFeISMyD6OQA+WT+ZgYMSTBGyKVfo3fq86IJ6WA28= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Sipboymn; arc=none smtp.client-ip=209.85.128.66 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Sipboymn" Received: by mail-wm1-f66.google.com with SMTP id 5b1f17b1804b1-4801bc32725so51852795e9.0 for ; Wed, 04 Feb 2026 02:41:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770201672; x=1770806472; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9AxpllCiQp1cWF28sAzya8eycPmht7frGe47a1UxWmY=; b=SipboymnP081nVht6myvJ6S3hHm1NGnGD7ypX6pqN9Kmb/DhGJiVNUNo46dAjSe6LS B8qJkQVzEXPJpWG4oDSbhLztqqcdfi74aKB3/wMAvyRjzhA/DBP+io0NZSW4Yoy4bLNY LnppSPg8uPoqNSIDjlp8/NoxoJ+TT8+B101eWhxFviJE85PYVQ1MN50GIFhpJMrA/E// 0uknnqGFyHsFDto83PSLuRyNSABteiolqWZ9Ki+5eFgQmmKWpjaSXNB+xBmsvS2Wgh/q GhQecEzbTitExD3ShmiwKn/mQCCylzn5mYRYSMqp3TjCDTi6bA3s4oRQ7JxVHb/iJQk7 sKFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770201672; x=1770806472; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9AxpllCiQp1cWF28sAzya8eycPmht7frGe47a1UxWmY=; b=kS1qNyt/GP3FirXIM97lH146Zi6NYOIVvpjSRk53TSLp7MKrkDgZtVEmmBwTIMGwVq HUNi62eqcbd9rPCHLZZ1L48XZkTeezEGb1TBAArq69d62oheiO/SSTfX+adWuU73HP7r M0EM5WmNJtH9YbM0djefU5cGI4Nwln04PKYrc8sgOFy3E6/2AK/Qx9qIjyWpKHChOXSB 0MRI9f7w2glZB7GcNKX90Fz2QgoOID2VvWXKYeThgsErLOBqa//OfdEYAJnhggZbuMTL 8dv5hHPvaIfF3vg7o+BvrIzr+C4jLbuQ0cJDHOpM8HsHyM4MLwYhqbgtGNxert3fAIUq rflA== X-Forwarded-Encrypted: i=1; AJvYcCVmfhgWz04/ttsm2BYSZnRCscdANT9R65XesKcGi+/JuWlqHx67DHOhEJ5fmAmZG4raOeZ8YVnhyTP59ZI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7XSbyN4kb3wZ4L1svU4dXvW7kJbuklrfncpGpN0Wefz6B+ypj OVh+DwbIzIWqVDcvTueqebnz4BfTzPM0s/mD6vuGSvwiTDPFcF0N2FAQMklgdXzBm9M= X-Gm-Gg: AZuq6aKCI/66mxfYPJlN7Jc5WnSnhET32Ll3WHCb9+Z0olA2NvLDG8jNHDilRQhXFMk faTPlAffkbTDXLVbJRoAYJ4tVXBiXWSqUsi3L+SycZlJQhVAbALxiMWRe2Y7vxHfXFzstZGblF2 8LxS0TqlCUb6IV/8yuYCwM/FI67GxtvKGKSVVX20uE8GmEiGap5BGrgThRm6c5buq0PN5fwTX5U 0FFVsiPz0faDYCLZYbFW1BjgIOyhoscUHK1gHYxMhf2QAecCt2Ow2h4ljVzXEoXR/aXTaYTIpTx 1jSKAX+wWvisd9MZ0U1H0HcrNUGDwUZHMm4YDgJqh0EWZjZoyUURpAQHhO8O7jyoExg1uyRWOOY Jro9jY4jZLKTxo7Fn88Q3pvhwg94MbF4wnMbdTdyYHNR3UIPps8ofF7g4xnesMQL/PjnRbtKmBf imk8MU+1sO3/P+V9Jg X-Received: by 2002:a05:600c:8b88:b0:477:b0b9:312a with SMTP id 5b1f17b1804b1-4830e93eb34mr34801235e9.7.1770201672426; Wed, 04 Feb 2026 02:41:12 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48310919211sm50865585e9.11.2026.02.04.02.41.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 02:41:12 -0800 (PST) Date: Wed, 4 Feb 2026 13:41:08 +0300 From: Dan Carpenter To: Neel Bullywon Cc: Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: greybus: gbphy: replace sprintf() with sysfs_emit() Message-ID: References: <20260204101342.71267-1-neelb2403@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260204101342.71267-1-neelb2403@gmail.com> It's best to wait a day between resends. On Wed, Feb 04, 2026 at 05:13:42AM -0500, Neel Bullywon wrote: > Replaced sprintf() with sysfs_emit() in the protocol_id_show() sysfs I really hate to comment on this, because I famously get annoyed by people who act like it's soooo important and we have one "reviewer" who wants every sentence to be in imperative tense. But past tense is kind of ugly. You did it right in the Subject on v2. Use "Replace" instead of "Replaced" here as well. Btw, if someone provides you a commit message, then they're basically obligated to allow it. > attribute function. This code is safe, as replacing sprintf() with s/as/as-is/? > sysfs_emit() gets rid of calls to sprintf() The line break is weird. > as part of kernel hardening and sysfs_emit() is more appropriate in > this context. > > Signed-off-by: Neel Bullywon > --- > This was compile-tested only (no VM/hardware used) > --- You need to put a little note here to say what changed. https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/ regards, dan carpenter