Re: [PATCH V2 6/6] i3c: mipi-i3c-hci-pci: Enable IBI while runtime suspended for Intel controllers

[Frank Li <Frank.li@nxp.com>]

On Wed, Feb 04, 2026 at 01:15:11PM +0200, Adrian Hunter wrote:
> Intel LPSS I3C controllers can wake from runtime suspend to receive
> in-band interrupts (IBIs), and they also implement the MIPI I3C HCI
> Multi-Bus Instance capability.  When multiple I3C bus instances share the
> same PCI wakeup, the PCI parent must coordinate runtime PM so that all
> instances suspend together and their mipi-i3c-hci runtime suspend
> callbacks are invoked in a consistent manner.
>
> Enable IBI-based wakeup by setting HCI_QUIRK_RPM_IBI_ALLOWED for the
> intel-lpss-i3c platform device.  Also set HCI_QUIRK_RPM_PARENT_MANAGED so
> that the mipi-i3c-hci core driver expects runtime PM to be controlled by
> the PCI parent rather than by individual instances.  For all Intel HCI PCI
> configurations, enable the corresponding control_instance_pm flag in the
> PCI driver.
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>
>
>
> Changes in V2:
>
> 	Retain HCI_QUIRK_RPM_ALLOWED
> 	Amend commit message accordingly
>
>
>  drivers/i3c/master/mipi-i3c-hci/core.c             | 4 +++-
>  drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c | 3 +++
>  2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
> index 149b3fad34b5..d19be1d276b5 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/core.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/core.c
> @@ -1005,7 +1005,9 @@ static const struct acpi_device_id i3c_hci_acpi_match[] = {
>  MODULE_DEVICE_TABLE(acpi, i3c_hci_acpi_match);
>
>  static const struct platform_device_id i3c_hci_driver_ids[] = {
> -	{ .name = "intel-lpss-i3c", HCI_QUIRK_RPM_ALLOWED },
> +	{ .name = "intel-lpss-i3c", HCI_QUIRK_RPM_ALLOWED |
> +				    HCI_QUIRK_RPM_IBI_ALLOWED |
> +				    HCI_QUIRK_RPM_PARENT_MANAGED },
>  	{ /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(platform, i3c_hci_driver_ids);
> diff --git a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> index c562e666f29a..58c4a025a29c 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/mipi-i3c-hci-pci.c
> @@ -200,6 +200,7 @@ static const struct mipi_i3c_hci_pci_info intel_mi_1_info = {
>  	.id = {0, 1},
>  	.instance_offset = {0, 0x400},
>  	.instance_count = 2,
> +	.control_instance_pm = true,
>  };
>
>  static const struct mipi_i3c_hci_pci_info intel_mi_2_info = {
> @@ -209,6 +210,7 @@ static const struct mipi_i3c_hci_pci_info intel_mi_2_info = {
>  	.id = {2, 3},
>  	.instance_offset = {0, 0x400},
>  	.instance_count = 2,
> +	.control_instance_pm = true,
>  };
>
>  static const struct mipi_i3c_hci_pci_info intel_si_2_info = {
> @@ -218,6 +220,7 @@ static const struct mipi_i3c_hci_pci_info intel_si_2_info = {
>  	.id = {2},
>  	.instance_offset = {0},
>  	.instance_count = 1,
> +	.control_instance_pm = true,
>  };
>
>  static int mipi_i3c_hci_pci_find_instance(struct mipi_i3c_hci_pci *hci, struct device *dev)
> --
> 2.51.0
>