From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C74851FF5E3 for ; Thu, 5 Feb 2026 05:46:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770270410; cv=none; b=ZmsFqm5XG9dJJJ+dppkh7mBQe6Z2RUvmJvGtXj8eAprfOheMIhGXoYo7vKzzKUVoEf3FmGGgaIr1pHdie94o3atDzmYRj5KOs4V17tSvqZhY0NMwVZH5BcmfJk3fJjy/PrNRDhLGg1R/4mmQJZjKNY65Z+EIIyMS1E7TuQiDlyc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770270410; c=relaxed/simple; bh=xZMzOliLNQOb0vHOHye2LmVSruptmxTvELI4ah94RPE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OEKvIVWwkyg1npW2dadXiDahLBUivtax4uqs//6Yttae1dg5Sbdv4JGmtFFuBcOYD1J5/JDPJGkTQ8GCQswOB9v/gTb36TMGxVOrxGWhGcwnFeCRorpvvwYpmmd0AXSPREYN9Td59I6AH8cO9PIT9j+8mH+uMlEa1J/F3CVxQKI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=DL0Bzx55; arc=none smtp.client-ip=209.85.128.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DL0Bzx55" Received: by mail-wm1-f67.google.com with SMTP id 5b1f17b1804b1-482f2599980so5739595e9.0 for ; Wed, 04 Feb 2026 21:46:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770270408; x=1770875208; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=qJA/2IOSYuQFhDc2xvdpqyFU6ndugIR0rttkiRO0dZU=; b=DL0Bzx55Gv9B11jscAap/bTU06CpAuzeQvoWM9UQipgB5pgH1ScT26cdXWEBavSb1Y nKXR4nMOmoa8GaTiaOKeaHtF8C1nPd/2ElL2DOwE6Vv1Sz7/P9VP6cGbj6s5iF0cytTi sT8HwAv4Th/5VUMEAcW0s72uzhTGgNsq5rZRwWp3SDKcU5c+G5I5Nu+DajbeVC9Dk300 23EOXesIaZDTDUaLYKbSd36QoVfXg5YjXVs/ZM0w6ff4fY5ejAoUB75/Fae4DMbpZlSm 53L6gxGE01Yq7CqKW0401IUkpO4ZPwDc+Q1QpOgk9j0JUvL/x0tO5IsOrsae8B6MbPvn 1zNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770270408; x=1770875208; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qJA/2IOSYuQFhDc2xvdpqyFU6ndugIR0rttkiRO0dZU=; b=s4e3LBQmatcLx0P82cZJP/7ZQNJ5vII2outuf/wOedffG4cL0YLKnRg/ZmJdsAt3LC DPkmZ8yHkwm/7lIiad/Ul8jqzG4Z+b6mwC+rgAK+cZmkMFlInhd+qa4H3nLwPSihR7Kb dWTU5wTIyYCAOxI9hp6M16LXJOKdMg5X0N4NNOz9NpSmS4x79dkwZUb+d3AhLFNlUzPS yIuKXokjllgjt23bQTEI4ivHyg1ltWFInWiuZY20FvHb42hDaOK2NNoNqfjmdSsojkX1 C0bD3XsP3ZztOCYcjtlMoLDt0NtUdpheAZ50B9yvqq8iPgWKdLLUiWqdo51v3WqpitGz p/9Q== X-Forwarded-Encrypted: i=1; AJvYcCU2YSjtmR8P+eMnFzj19B50P3Wbfot1As1Vn0/eVGlgfAUNqfT4VD7TUs0/uCwK3f9jtk05qEk/zStG9rA=@vger.kernel.org X-Gm-Message-State: AOJu0YyGWlP63es73oP3o5c0tKa2E1hKzi6J7vmLf/nm2bzKufGJPSGi gwPovYmwNJewqRwlP5++mM0AfkXu3ImI3oV/U7raRXTYblHYBwKRsDcc3IlRS+7EuW45EXUZJw7 Lr5sMBcE= X-Gm-Gg: AZuq6aLjDwxhCTivCXfWTcWBSEvp+TvhvgogrvQDBSjMhbwwtFaD66OWl+6pkrPVUko E1ddtgqklrgb9+lwFfgGKi9YRQ+pQrBe/DTxC8qUHA9qpwQ4qoih16KIxMPXt6Jzk3npP3rJL0F TRG0xEZXDDDgvBaN4COzzK8co2hdnDlto5a/IpDM7JSmoENB7Fo5mowDPSvTSZa7oVWCxKOcw2h k9oTRfQsbxRmUE7MUgXZwggZsYqt4qW1nmF66p6okzTc2AXRsyhO90IA2UlLuVrs+NBvUHPWQSp LiVpxh7MimCJJDkb9tSqjAYH2uyai+m+L13ZMnkTA0YPUcCCwx5ArE6rUG/3Cla8P3Ahw8HLhtp SIZqyU+1T+xDbJEIb+jbTdmX7OfHb+bMYioMuublz3rF3NBBtg+dabJPOg4mR8K4fRk4rGUqX4Z FvJViQnP4LY8lHkUe1 X-Received: by 2002:a05:600d:844f:10b0:480:7162:fa48 with SMTP id 5b1f17b1804b1-4830e9492aamr51558415e9.13.1770270408132; Wed, 04 Feb 2026 21:46:48 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48317d299bfsm30190735e9.2.2026.02.04.21.46.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 21:46:47 -0800 (PST) Date: Thu, 5 Feb 2026 08:46:44 +0300 From: Dan Carpenter To: Haroen Tmimi Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix checkpatch.pl warnings in rtw_ieee80211.c. Message-ID: References: <20260204184133.142511-1-tmimiharoen@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260204184133.142511-1-tmimiharoen@gmail.com> On Wed, Feb 04, 2026 at 07:41:33PM +0100, Haroen Tmimi wrote: > 1. Fix "Yoda condition" style issues by moving constants to the right > side of the comparison (e.g., changing "_SUCCESS == val" to > "val == _SUCCESS"). > > 2. Change the _action_public_str array to "static const char * const" > to ensure the array entries are read-only, preventing accidental > modification of the pointers. > These are unrelated things so they should be two patches. But apparently someone else already did at least part of this... regards, dan carpenter