Re: [PATCH] ASoC: fsl: imx-rpmsg: use snd_soc_find_dai_with_mutex() in probe

[Frank Li <Frank.li@nxp.com>]

On Thu, Feb 05, 2026 at 05:24:29AM +0000, Ziyi Guo wrote:
> imx_rpmsg_probe() calls snd_soc_find_dai() without holding client_mutex.
> However, snd_soc_find_dai() has lockdep_assert_held(&client_mutex)
> indicating callers must hold this lock, as the function iterates over the
> global component list.
>
> All other callers of snd_soc_find_dai() either hold client_mutex via the
> snd_soc_bind_card() path or use the snd_soc_find_dai_with_mutex() wrapper.
>
> Use snd_soc_find_dai_with_mutex() instead to fix the missing lock
> protection.
>
> Signed-off-by: Ziyi Guo <n7l8m4@u.northwestern.edu>
> ---
Reviewed-by: Frank Li <Frank.Li@nxp.com>
>  sound/soc/fsl/imx-rpmsg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/imx-rpmsg.c b/sound/soc/fsl/imx-rpmsg.c
> index 53f04d1f3280..76a8e68c1b62 100644
> --- a/sound/soc/fsl/imx-rpmsg.c
> +++ b/sound/soc/fsl/imx-rpmsg.c
> @@ -145,7 +145,7 @@ static int imx_rpmsg_probe(struct platform_device *pdev)
>  	data->dai.ignore_pmdown_time = 1;
>
>  	data->dai.cpus->dai_name = pdev->dev.platform_data;
> -	cpu_dai = snd_soc_find_dai(data->dai.cpus);
> +	cpu_dai = snd_soc_find_dai_with_mutex(data->dai.cpus);
>  	if (!cpu_dai) {
>  		ret = -EPROBE_DEFER;
>  		goto fail;
> --
> 2.34.1
>