From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DD1332826F for ; Fri, 6 Feb 2026 07:44:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770363858; cv=none; b=b4SFazZToyjeX7VZessV+x+EkWsgy+dN/k3cbcpR96pgNxeUfvS5AlIXLyxl6hCJRgDldxLesZPKtO8HIbj2Lu1yJQYMcwwfgKvMxyTRq4JE5U+Q5DaSdJj+vN6vpeuGfroIL8QLgGAovu7WYtBNBhiGBXvH+pE3CVwpt0i5Qxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770363858; c=relaxed/simple; bh=wYE5OneJ/g/mwNt3BOSwejXssQef62ZbTSSfHnVdr4Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XUKdbxRi5llf8VcMgiq4ZIgr24gneoj2z9tPKnZkzqJGL1KPDkdxwHqpjB+ebNUNxK09/v7lBe+7SL/g2/v+xGf2Xzq0wsrAOpk8VWhnRlj0B/W4uzQvtE7KFTArNF68Y1RXXUGXibVD5j015jbnfvlZBBBqQbG127oFwtLhpqQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=DLWCp1dQ; arc=none smtp.client-ip=198.175.65.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="DLWCp1dQ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770363858; x=1801899858; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=wYE5OneJ/g/mwNt3BOSwejXssQef62ZbTSSfHnVdr4Q=; b=DLWCp1dQbfJuXEfNHERGUUvpX8zVdKUEuQAcpI3sZK37GYW55mctk7gw ICAFJ6bect/mQVZdgh43Ad4kZ5jtVUGlpqL21vZXgWsyXjxQpJhTCD1AV QY3LKzXe/vARgMfq/+098Z9TrfZvstMhNHR0LbqwBTsq96cVmaVr5yLGU Yut3YDhbk7KFVPlm2nxnzuQvQHlZkbfdkif3kK5JVmKKyjF3zyd6Ws19r 7peaG9BTgSEQy/ruHjprG6R7bkGnMaRLl0IJBVdfEI2EmLUfIWyYjRHLd O6Q0eLCg8S69KyW6CIGhMKs8o4PrE12dOGXJwpLR4UMqDpCD6CayPHhLN g==; X-CSE-ConnectionGUID: 2ir6xumzTqK6M48wLNoUQg== X-CSE-MsgGUID: Q1sKY0rCTvORsM6x8UBHOQ== X-IronPort-AV: E=McAfee;i="6800,10657,11692"; a="71608550" X-IronPort-AV: E=Sophos;i="6.21,276,1763452800"; d="scan'208";a="71608550" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2026 23:44:18 -0800 X-CSE-ConnectionGUID: NN8Kw4KrRmyqwYzPZfpmNA== X-CSE-MsgGUID: 4C0JrzuqRTexQQEfEBAXAg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,276,1763452800"; d="scan'208";a="210602322" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.202]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Feb 2026 23:44:16 -0800 Date: Fri, 6 Feb 2026 09:44:14 +0200 From: Andy Shevchenko To: Vignesh Raghavendra Cc: Miquel Raynal , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, Richard Weinberger Subject: Re: [PATCH v2 1/1] mtd: cfi_cmdset_0001: Factor out do_write_buffer_locked() to reduce stack frame Message-ID: References: <20260204012630.2211832-1-andriy.shevchenko@linux.intel.com> <87a4xnfu8j.fsf@bootlin.com> <87y0l7gkmo.fsf@bootlin.com> <4d4ab8af-3e09-4e48-a79d-0af3453600c3@ti.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4d4ab8af-3e09-4e48-a79d-0af3453600c3@ti.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Fri, Feb 06, 2026 at 11:26:23AM +0530, Vignesh Raghavendra wrote: > On 05/02/26 23:04, Miquel Raynal wrote: > > On 05/02/2026 at 17:57:17 +02, Andy Shevchenko wrote: > >> On Thu, Feb 05, 2026 at 09:51:56AM +0100, Miquel Raynal wrote: > >>> On 04/02/2026 at 23:12:00 +02, Andy Shevchenko wrote: > >>>> On Wed, Feb 04, 2026 at 02:25:27AM +0100, Andy Shevchenko wrote: > >>>>> Compiler is not happy about used stack frame: > >>>>> > >>>>> drivers/mtd/chips/cfi_cmdset_0001.c: In function 'do_write_buffer': > >>>>> drivers/mtd/chips/cfi_cmdset_0001.c:1887:1: error: the frame size of 1296 bytes is larger than 1280 bytes [-Werror=frame-larger-than=] > >>>>> > >>>>> Fix this by factoring out do_write_buffer_locked(). > >>>> > >>>> My gosh, I already sent a v2 earlier and there were some replies, > >>>> I need to check... > >>> > >>> I'm not sure I get what you mean here? I got no reply (in my inbox) to > >>> your v2. I am letting a bit of time for Vignesh to take a look, but I > >>> know he's busy so I might take it nevertheless by the end of the week as > >>> we are approaching the merge window. > >> > >> I got some strange LKP reports, I need to check them. > >> Please, discard this email thread as we have it there > >> > >> https://lore.kernel.org/r/20260124133730.3454241-1-andriy.shevchenko@linux.intel.com > > > > Ah, this did not reach my inbox, marked SPAM... I'll discard this patch > > for this cycle, feel free to resend once the report has been figured > > out. > > Yeah, things become tricky with CONFIG_MTD_XIP enabled. With > XIP_INVAL_CACHED_RANGE() moved to caller, initial_adr becomes unused > when CONFIG_MTD_XIP=y > > One solution maybe to move calls to XIP_INVAL_CACHED_RANGE(), > ENABLE_VPP(map) and xip_disable() and their complementary functions to > do_write_buffer_locked() as these calls need to repeated for every > writes (if and when we find need to reuse do_write_buffer_locked()) > > Alternately move INVAL_CACHE_AND_WAIT() and everything after that to caller Thanks for the analysis! Can you copy this as the reply to the LKP report? I don't want to have the report and analysis in different threads, I may forgot about this one (and actually I closed this thread for myself). -- With Best Regards, Andy Shevchenko