From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43E372FF164 for ; Fri, 6 Feb 2026 14:08:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770386919; cv=none; b=pqDAPZFQveZeDL61HybhftKGxMWCE2XRoCoZOXXCBKYyuBxuPREeDI8V3GhSUfmFCdyiKxqBwO9jk3nqLaaDNXjN0WBgK7nKlpyePKN1TGyVAxap/GMm4Ke5hgceR61Ya2viF3TAort7x1pPgbF6WvKYL2855q/a2EYFRcp9ujI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770386919; c=relaxed/simple; bh=T4PRRZI/1uJE50RjxFRmitdLn2dzam20FUBAgfu4suM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=U7O6cKCmmrgBF2ZRu0ONFFuzlrABI+caY7mgukuCdG/VII8ceY37+Gm81f46rMheHltjQ23y+ibvPGr0lGMs+Om0Fsiy7nljbGwCTL0FCOX/VlnvxcUXyGQu5s/B4SfK1MdVzwjVBq+JGzsv6/19FGOW5hfj3QN7YjQbyM1CCJM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=PgvR4bfK; arc=none smtp.client-ip=192.198.163.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="PgvR4bfK" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770386919; x=1801922919; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=T4PRRZI/1uJE50RjxFRmitdLn2dzam20FUBAgfu4suM=; b=PgvR4bfKPIKrXO/dTKhM2fSzPAy0S7lg3AmS1ImXbKtUv8VL5XUMPo6h HVls8KiS8T5a2loM+T6LYcmdl6MnscGIojsboY7qbwm1c6Rxq/IAwoQTm P2DEA+eDJMyUT1ctr32oXuATixHl1dVHeFbj18c5bXL5s7J2eqmo8PuMp cFGGwmz3ftb2QVqIHWyXaTwdMONsmAJP9AkKQGHFfKya1yjKgRfbpK8cC Nnp6jLvDEU3K0yfmnuYIS1I1w7QHZ4oY0766mn/Trr9/ZtPHjfH6hUkuW MEtywougqxA4m17NIWGmNJhyNgwuk8OgLC1O+0hhzzJQ8kgN6kexm27rK w==; X-CSE-ConnectionGUID: NBaQozSKQ9GVpXyRdfN/zw== X-CSE-MsgGUID: narH+6hsSM2uKQCPGTycyg== X-IronPort-AV: E=McAfee;i="6800,10657,11693"; a="82331058" X-IronPort-AV: E=Sophos;i="6.21,276,1763452800"; d="scan'208";a="82331058" Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2026 06:08:38 -0800 X-CSE-ConnectionGUID: ZkrHuI//SIS9+paX/fmQ4g== X-CSE-MsgGUID: iQ03ChenQza6pwKk6HFoqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,276,1763452800"; d="scan'208";a="248499059" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.244.202]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2026 06:08:37 -0800 Date: Fri, 6 Feb 2026 16:08:35 +0200 From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: Sudip Mukherjee Subject: Re: [PATCH v1 1/1] parport: serial: Convert comments to indices in cards assignment Message-ID: References: <20260122090601.2380747-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260122090601.2380747-1-andriy.shevchenko@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo On Thu, Jan 22, 2026 at 10:06:01AM +0100, Andy Shevchenko wrote: > Instead of using comments, use explicit indices. This will help to > address an entry in an array by known index and leads to more robust > code. Sudip, any comments on this? -- With Best Regards, Andy Shevchenko