From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9C9C34C9AB for ; Fri, 6 Feb 2026 12:03:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770379428; cv=none; b=SQSnQi2mlNK8PxCVoFqTcL70tJOVbHs3AzJCbdOYlseaeXGliG5LolUksgy6n8hRdDYxZH/y+UOUNXdbiDAjaL37LOnojAiG4BeoB087ebMTfQzFXGS4pquGBt6oqpQGd/XGv8e+0e466HOy1c6DSyWg1zSofAujxfZlJswRcrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770379428; c=relaxed/simple; bh=uy8KSJl1E4N7YPO0LpxK5qPqXXBNu7tHP4Vg5Bk3lZ0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=MHL+Xm+PsxAyXH65iTcyslXQvL/pVYQRzQpirgM1ii2eMbkjMR00DtdcLwcERz0h/7ERo9gOoB2WKRWn4MXlQeiYkUb2/JWm40Rmi36w/IgTK4WxomB2hSZy6vC988/zdazALfk+/P7V+ZWcVzM7hkl1/T80Y+E2godhAEf0SCc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PXMR+MJE; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hzjJ4lv3; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PXMR+MJE"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hzjJ4lv3" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6167XrJe2482242 for ; Fri, 6 Feb 2026 12:03:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= D7T/znkIGcIBDaQtDiqCYQV9+wOLqdbwc+EurdTvLiI=; b=PXMR+MJEslhETkVY MCMDVLvFyILaRh7tUetTxZ1avmPppThdRXrnzIv4eR4QpWJ4qPm406rCNr/yqZVn JZaIJvbDel4i5scGM7hbwIoZjPzdvp05lu2+fOuxhIezU9SM/HdOG7u8GxBr1n4i lAaX6u7WY0lSBMNtQqegg1eL2YFzc0B9fE08f9wpuGcJ1Q/3dIbxycXQDoYfy4FJ Nn5qclHYayIGdoDNZNK03ICt361Xx1Sr4P6bLF+h/mUVPfKlMRQkHVdqOjLBIeQD sr3jLAjcK7bYaYB0Dx4/Q5nFl8y18MXVoazLVUT2M8ZFFvRSi3ms5j+AACWI8Hu8 jynHiw== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c5c170urb-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Feb 2026 12:03:47 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-b630753cc38so4140046a12.1 for ; Fri, 06 Feb 2026 04:03:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770379426; x=1770984226; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=D7T/znkIGcIBDaQtDiqCYQV9+wOLqdbwc+EurdTvLiI=; b=hzjJ4lv3xpv/7OreRoHOONs49TP6jCarw6gXfZYN0SERy2KakzPUrbKtdAE4XmrfYg JXyKSDIn4aF895miPo5yyyAuNvDhX3D/q7cs9yRPe5i/0gY/+ycOwpSWuUnLawNkkpSs XbRrl/qrY6siKlWYpNgUKxbxul+RQUbKOmZOXsbYGaxQfIKokPbQ4yAwRw9M61tlPuMg gn5s6b5vIhIDzcuW6Z5PK/YXc3RTlZhQYOefumwV38Ghj0h9DBNpOTnGf4T9zTGh4YnN JCTNY3fyOKpLgT4gPU1jRkwZ4WrsQ6tppyOIEXhyNsRRlrPrU7SLclq1rnqRHb7EbO49 MdqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770379426; x=1770984226; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D7T/znkIGcIBDaQtDiqCYQV9+wOLqdbwc+EurdTvLiI=; b=VOT9AYOTS7/Xs9cdVPDJzQg1hfyfPCLs9WKardsb+ZmWSvcwylutckukbnnyIbe4Ey kTsr1GFSEh/VZgI7NSYTnhlOPuU+5HM3w7vsazbhIdYYYS7tTxpEiTyEEaT30Hib2Q6J Pw6zFX/J5PN88j8f4a3zYQ5hUBkOpcqz6t8mJ+4zgVSyz1JytL5OMm/rra3OHPQdtRlU 2m3CUbYRaBioazebP3RAiihybJbsU/XEqGcjf43ovFGu56B3d1tGvEd5id/++IZDHVt6 LsQJM2sLlD3/9ZKsCZwugtsZjaA/qR8Cu3qpYDYzY2kpBjqUclNDkrVkTBc5XvnMuBU9 J0Hg== X-Forwarded-Encrypted: i=1; AJvYcCUZ9PrbvB6uUoatTjW1GMttiUL29uj+11Ml2xj+XkEvMIFmG5FOpwaEVPyvtTlbxouyU0wJb8h8nPhArQo=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+fWXWB5nVO9dtbjls0rkqJZBC3zeyYp9BJY8z9aD2cdfW++vu Z/vj6ht6a5tvew80Ez6Gc48g3iMgBMulVdSQEIJHUyWEzd55BZgsOWePBZ6aTxJyOjQMmWx9/6i nSyEYuZKwdkM4PbDww5NLabCSxAYBeNLpf4IX/qX4d+GjP3ePk8bPElRnaLdN6DHH30Q= X-Gm-Gg: AZuq6aK25Ager5pRpKxPcQqS7mI/gxo0b6s488MV9YoRr40KnrQ0KOPl34/YnYTT7zK VX2LIllZ2hQHDOQYBT+gJH7NtEyot6TyrC6yISZEbunq7kktJB9t0vvOPVwyej+EBR9A/M/M0m3 l+KCQMFtGUuAyIe0wPY6AN0G71QsGL8PrazHSbcQY0sJrlulo+/cmjRWEcVPUJzHn6CUwVH1NJC T3Sb3TYGD32f3QJ9ibg6GbfS0uullhAnZhEEA8yrUFCoLhRFKKv8wv/1x2dNOJYWbcAkbXnOLbW RPpUszigqgolEYcNbfh/IBuFjFbxIJnLpDEUcNNp/Eq7+9UBDeWPHe2UjIIJWUuIvu/JRohlNML XufvhWCRsGuS3z5illMOkMSUzfi1h8VNZaFDIVJtikTG4PnM= X-Received: by 2002:a05:6a21:150c:b0:392:e583:b766 with SMTP id adf61e73a8af0-393ad339ac9mr2560259637.42.1770379426372; Fri, 06 Feb 2026 04:03:46 -0800 (PST) X-Received: by 2002:a05:6a21:150c:b0:392:e583:b766 with SMTP id adf61e73a8af0-393ad339ac9mr2560231637.42.1770379425888; Fri, 06 Feb 2026 04:03:45 -0800 (PST) Received: from hu-arakshit-hyd.qualcomm.com ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c6dcb4fbcbdsm2262924a12.4.2026.02.06.04.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 04:03:45 -0800 (PST) Date: Fri, 6 Feb 2026 17:33:38 +0530 From: Abhinaba Rakshit To: Konrad Dybcio Cc: Bjorn Andersson , Konrad Dybcio , Manivannan Sadhasivam , "James E.J. Bottomley" , "Martin K. Petersen" , Neeraj Soni , Herbert Xu , "David S. Miller" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 0/4] Enable ICE clock scaling Message-ID: References: <20260128-enable-ufs-ice-clock-scaling-v4-0-260141e8fce6@oss.qualcomm.com> <7b219a50-6971-4a0c-a465-418f8abd5556@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Proofpoint-GUID: Jmv5udy5GH-EKLsYDMtrEZalOANIa5RU X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjA2MDA4NCBTYWx0ZWRfX0vn08t+YsraD o7uSqkEI34Z+m6vY0Pem/hRe7UiOQiWHa9Iyd7OI625qHzyT4OQGbqN+41KJTAJExTH9Pl/+NuD 2Lg63dO1t0bNI58nF1o6feGe0IB1vH5FEL3CY2Bhb4nkEtJyLgh0JzyUz8aQdt2VVEQaH4nkcGR pmar4Qd/wzEVbAiz/xP40KG9OZjUq3dlpqDdQySWhiLmSY59/aQ1D46bIQEtLP5gJRX8mKlR+Q0 fP1iaX2l/aU/E1detPdT2DP/7mrWo44jQ0RMQGpEbbVk/8jL6PwpHFFPXwfMTpVQwdoeo7+aSl0 yBwxPLduweD/5Gdew2zr/18VUh6vaUoGXgkoFa2yZqXEjBmD2s8ISeFQ/LSI4yMvEY1QY1GBEp/ C0Dhylb1iRecZDSLZdknx4+LHzCbwotsC3jCzhDPTGB5ZKF2gnDSfm8u0blcqiZmxExlrBD0mHP cBuc7xkzo79p7ghNbfA== X-Proofpoint-ORIG-GUID: Jmv5udy5GH-EKLsYDMtrEZalOANIa5RU X-Authority-Analysis: v=2.4 cv=E7TAZKdl c=1 sm=1 tr=0 ts=6985d8a3 cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=LeY25DUbnqDghkOhmf8A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-06_03,2026-02-05_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 spamscore=0 clxscore=1015 bulkscore=0 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602060084 On Mon, Feb 02, 2026 at 04:01:38PM +0100, Konrad Dybcio wrote: > On 2/2/26 7:36 AM, Abhinaba Rakshit wrote: > > On Thu, Jan 29, 2026 at 01:17:51PM +0100, Konrad Dybcio wrote: > >> On 1/28/26 9:46 AM, Abhinaba Rakshit wrote: > >>> Introduce support for dynamic clock scaling of the ICE (Inline Crypto Engine) > >>> using the OPP framework. During ICE device probe, the driver now attempts to > >>> parse an optional OPP table from the ICE-specific device tree node to > >>> determine minimum and maximum supported frequencies for DVFS-aware operations. > >>> API qcom_ice_scale_clk is exposed by ICE driver and is invoked by UFS host > >>> controller driver in response to clock scaling requests, ensuring coordination > >>> between ICE and host controller. > >>> > >>> For MMC controllers that do not support clock scaling, the ICE clock frequency > >>> is kept aligned with the MMC controller’s clock rate (TURBO) to ensure > >>> consistent operation. > >> > >> You skipped that bit, so I had to do a little digging.. > >> > >> This paragraph sounds scary on the surface, as leaving a TURBO vote hanging > >> would absolutely wreck the power/thermal profile of a running device, > >> however sdhci-msm's autosuspend functions quiesce the ICE by calling > >> qcom_ice_suspend() > >> > >> I think you're missing a dev_pm_opp_set(dev, NULL) or so in that function > >> and a mirrored restore in _resume > > > > Thanks for pointing this out, its an important piece which is missed. > > We can use dev_pm_opp_set_rate(dev, 0/min_freq) in _suspend and restore the > > FWIW > > dev_pm_opp_set_rate(0) will drop the rpmh vote altogether and NOT > disable the clock or change its rate > > dev_pm_opp_set_rate(min_freq) will *lower* the rpmh vote and DO > set_rate (the clock is also left on) > > Konrad > Thanks for the info. I guess, dev_pm_opp_set_rate(dev, 0) seems more ideal as this is API is for full quiesce mode and the clocks are anyway gated in the suspend call (clk_disable_unprepare). Abhinaba Rakshit